[No QA] Add Day to the Insights Spend over time group-by options by MelvinBot · Pull Request #102636 · Expensify/App

MelvinBot · 2026-09-30T09:01:34Z

Explanation of Change

Adds Day to the Group by options on the Insights "Spend over time" graph.

Insights keeps its own list of allowed group-by values in INSIGHTS_GROUP_BY_OPTIONS. The earlier daily grouping work added Day to Search, but not to this list. Because the dropdown builds its menu from this list, and URL parsing drops any groupBy value that is not in it, Day never showed up in Insights.

This PR:

Adds CONST.SEARCH.GROUP_BY.DAY to the start of INSIGHTS_GROUP_BY_OPTIONS, so the menu reads Day, Week, Month, Quarter, Year.
Adds DAY to the InsightsFilters['groupBy'] type.
Adds unit tests: groupBy:day round-trips through buildInsightsQueryString and parseInsightsFilters, and the headline chart is grouped by day while supporting charts keep their own group-by.

The default stays Month. Translations, chart config, and SearchUIUtils already handle Day, so no other App changes are needed.

Backend dependency: the backend GetInsights command does not support groupBy:day for this graph yet, and returns 400 Invalid groupBy for insights. A companion internal issue tracks that change. Do not merge this PR until the backend change is deployed.

Fixed Issues

$ #102571
PROPOSAL: #102571 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

AI Tests

Melvin ran these locally. All passed:

npm test on the Insights-related suites (8 suites, 644 tests): insightsFilterParsingTest, insightsQueriesTest, resolveInsightsChartDataTest, resolveDashboardStateTest, useInsightsFilters.test, useInsightDataTest, SearchUIUtilsTest, InsightsControlsTest
npm run typecheck
npm run lint on changed files
npm run fmt (oxfmt) on changed files, with no diff
npm run spell-changed

Not run: the full npm test suite and the Storybook smoke test. CI covers them.

A browser check was attempted, but the tester opened the Search "Group by" menu instead of the Insights one, so it does not confirm this change.

Co-authored-by: daledah <daledah@users.noreply.github.com>

MelvinBot · 2026-09-30T09:01:51Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-addDayGroupByToInsights
git checkout -b claude-addDayGroupByToInsights upstream/claude-addDayGroupByToInsights
git push -u origin claude-addDayGroupByToInsights

Then you can close this PR and open a new one from your fork.

MelvinBot · 2026-09-30T09:16:14Z

🤖 Android test steps verification results: ⚠️ partial

Day now appears in the Insights Group by menu in the right order, and Week and Month still work. Selecting Day and applying it shows a full-page error, which matches the pending backend change; because the PR's Tests section is still a TODO, I tested the linked issue's acceptance criteria.

Step	Status
Group by menu for Spend over time lists Day, Week, Month, Quarter, Year in that order The menu order was exactly Day, Week, Month, Quarter, Year. Month was selected as the default.	✅
Selecting Day and tapping Apply shows daily totals on the graph The whole Insights dashboard was replaced by "Oops... Something went wrong / Your request could not be completed." This matches the backend rejecting groupBy:day. "Try again" sent the same request and failed again. The error screen also hides the Group by control, so there is no in-page way to switch back. I had to use Troubleshoot → Clear cache and restart to recover.	❌
Existing options (Week, then Month) still work Week updated the chart (x-axis "Sep 27 - 30, '26", header "Group by: Week"). Month updated the chart (x-axis "Sep '26", header "Group by: Month").	✅

view run · view recording

MelvinBot · 2026-09-30T09:27:08Z

🤖 Web test steps verification results: ❌ fail

The Insights Group by menu lists Day first, but selecting Day breaks the Spend over time chart because the backend rejects groupBy:day (GetInsights returns jsonCode 400). After that, the Group by control disappears, so there is no way to switch back to Week or Month without reloading.

Step	Status
Group by menu for Spend over time lists Day, Week, Month, Quarter, Year in that order The menu order was exactly Day, Week, Month, Quarter, Year. Month was selected as the default.	✅
Selecting Day and clicking Apply shows daily totals on the graph The Spend over time card was replaced by "Oops... Something went wrong / Your request could not be completed." The GetInsights request returned HTTP 200 with jsonCode 400, so the backend rejected groupBy:day. This matches the pending backend change.	❌
Existing options (Week, then Month) still work Not reachable. After the Day error, the Group by control disappears from the page. The error stayed after "Try again", after leaving and returning to Insights, and after changing the date range to "This month". The Day selection appears to persist, so only a reload or cache clear would recover. On Android, Week and Month worked after a cache clear.	❌

view run · view recording

daledah · 2026-10-02T06:32:36Z

@MelvinBot please unhold this PR since Backend is in prod and open this PR

MelvinBot · 2026-10-02T06:35:48Z

I removed [HOLD Backend] from the PR title.

I couldn't mark the PR ready for review because that action was blocked in my run. daledah, please click Ready for review at the bottom of the PR.

Before you ask for review, fill out the Tests and QA Steps sections. They are still TODO placeholders. The PR body's backend dependency note also still says not to merge. You can remove it now that the backend change is in production.

view run

daledah · 2026-10-02T07:29:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: HybridApp

ios-mweb.mov

iOS: mWeb Safari

ios.mov

MacOS: Chrome / Safari

web.mov

melvin-bot · 2026-10-02T07:34:19Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a62c8bc57

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-10-02T07:39:58Z

 };

-const INSIGHTS_GROUP_BY_OPTIONS = [CONST.SEARCH.GROUP_BY.WEEK, CONST.SEARCH.GROUP_BY.MONTH, CONST.SEARCH.GROUP_BY.QUARTER, CONST.SEARCH.GROUP_BY.YEAR] as const;
+const INSIGHTS_GROUP_BY_OPTIONS = [CONST.SEARCH.GROUP_BY.DAY, CONST.SEARCH.GROUP_BY.WEEK, CONST.SEARCH.GROUP_BY.MONTH, CONST.SEARCH.GROUP_BY.QUARTER, CONST.SEARCH.GROUP_BY.YEAR] as const;


Wait to expose daily grouping until GetInsights supports it

Until the server-side GetInsights change is deployed, selecting this new item persists groupBy:day; the Insights query builder forwards that value to GetInsights, which currently returns 400 Invalid groupBy for insights (as noted in this commit). Any online user who chooses Day will therefore see the full-page error instead of the dashboard. Gate this option on backend availability or land it together with the backend support.

Useful? React with 👍 / 👎.

The BE PR is now on production, and I've tested it thoroughly. The groupBy:day flow is working correctly.

daledah

LGTM

github-actions · 2026-10-02T09:13:09Z

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

JmillsExpensify

LGTM to me as well.

luacmartins

LGTM

github-actions · 2026-10-02T16:20:32Z

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-02T16:24:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102636.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-320c782-106e037-4080ec2b9d7aa76530369c6bf463c2b9ee3ebe9d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-320c782-106e037-188305b4be4132ca00cca04d6127e6d3fae60ad8/index.html

Web 🕸️
https://102636.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-02T16:25:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-10-05T00:21:08Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-05T00:25:11Z

No help site update needed. The Day option only appears in the group-by dropdown on the Insights page, which is behind the INSIGHTS_PAGE beta (InsightsPage.tsx:27). Most users can't see it yet, and no existing article sentence is now incorrect.

view run

OSBotify · 2026-10-05T23:14:46Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.2-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Add Day to the Insights Spend over time group-by options

5a62c8b

Co-authored-by: daledah <daledah@users.noreply.github.com>

MelvinBot assigned daledah Sep 30, 2026

MelvinBot requested a review from a team September 30, 2026 09:01

melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Sep 30, 2026

MelvinBot mentioned this pull request Sep 30, 2026

[Due for payment 2026-10-12] [$175] [Insights][R2][App] Add group-by day to the Spend over time graph #102571

Closed

MelvinBot changed the title ~~[HOLD Backend] Add Day to the Insights Spend over time group-by options~~ Add Day to the Insights Spend over time group-by options Oct 2, 2026

cristipaval marked this pull request as ready for review October 2, 2026 07:34

cristipaval requested a review from a team as a code owner October 2, 2026 07:34

melvin-bot Bot requested review from daledah and removed request for a team October 2, 2026 07:34

melvin-bot Bot requested review from garrettmknight and removed request for a team October 2, 2026 07:34

cristipaval requested review from JmillsExpensify and removed request for garrettmknight October 2, 2026 07:34

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

daledah approved these changes Oct 2, 2026

View reviewed changes

melvin-bot Bot requested review from aldo-expensify, cristipaval and luacmartins October 2, 2026 07:40

This comment has been minimized.

Sign in to view

JmillsExpensify approved these changes Oct 2, 2026

View reviewed changes

cristipaval changed the title ~~Add Day to the Insights Spend over time group-by options~~ [No QA] Add Day to the Insights Spend over time group-by options Oct 2, 2026

cristipaval approved these changes Oct 2, 2026

View reviewed changes

luacmartins approved these changes Oct 2, 2026

View reviewed changes

luacmartins merged commit 320c782 into main Oct 2, 2026
55 of 65 checks passed

luacmartins deleted the claude-addDayGroupByToInsights branch October 2, 2026 16:20

OSBotify mentioned this pull request Oct 4, 2026

Deploy Checklist: New Expensify 2026-10-04 #102948

Closed

59 tasks done

Conversation

MelvinBot commented Sep 30, 2026 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

AI Tests

Uh oh!

MelvinBot commented Sep 30, 2026

Uh oh!

MelvinBot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daledah commented Oct 2, 2026

Uh oh!

MelvinBot commented Oct 2, 2026

Uh oh!

daledah commented Oct 2, 2026 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

daledah Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

daledah left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

This comment has been minimized.

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

OSBotify commented Oct 2, 2026

Uh oh!

OSBotify commented Oct 5, 2026

Uh oh!

MelvinBot commented Oct 5, 2026

Uh oh!

OSBotify commented Oct 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MelvinBot commented Sep 30, 2026 •

edited by luacmartins

Loading

MelvinBot commented Sep 30, 2026 •

edited

Loading

MelvinBot commented Sep 30, 2026 •

edited

Loading

daledah commented Oct 2, 2026 •

edited by luacmartins

Loading