Skip to content

Remove translateLocal from OptionsListUtils/index.ts lib #102608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiceli merged 2 commits into from
Oct 8, 2026
Merged

Remove translateLocal from OptionsListUtils/index.ts lib #102608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea16ca
Remove translateLocal from `OptionsListUtils/index.ts` lib
parasharrajat Sep 30, 2026
1067948
Merge branch 'Expensify:main' into translate/4
parasharrajat Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/CategoryPicker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ function CategoryPicker({
value: searchValue,
label: translate('common.search'),
onChangeText: setSearchValue,
headerMessage: getHeaderMessageForNonUserList(categoryData.length > 0, debouncedSearchValue),
headerMessage: getHeaderMessageForNonUserList(translate, categoryData.length > 0, debouncedSearchValue),
hint: offlineMessage,
// Auto-focus is opt-in (inline-edit popover only) and skipped on touch surfaces to avoid popping the keyboard.
disableAutoFocus: !(shouldAutoFocusSearchInput && canFocusInputOnScreenFocus()),
Expand Down
2 changes: 1 addition & 1 deletion src/components/DestinationPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function DestinationPicker({selectedDestination, policyID, onSubmit, ref}: Desti
label: translate('common.search'),
onChangeText: setSearchValue,
disableAutoFocus: true,
headerMessage: getHeaderMessageForNonUserList(destinationData.length > 0, debouncedSearchValue),
headerMessage: getHeaderMessageForNonUserList(translate, destinationData.length > 0, debouncedSearchValue),
};

return (
Expand Down
2 changes: 1 addition & 1 deletion src/components/TagPicker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ function TagPicker({
const textInputOptions = {
value: searchValue,
onChangeText: setSearchValue,
headerMessage: getHeaderMessageForNonUserList((sections?.at(0)?.data?.length ?? 0) > 0, searchValue),
headerMessage: getHeaderMessageForNonUserList(translate, (sections?.at(0)?.data?.length ?? 0) > 0, searchValue),
label: translate('common.search'),
// Auto-focus is opt-in (inline-edit popover only) and skipped on touch surfaces to avoid popping the keyboard.
disableAutoFocus: !(shouldAutoFocusSearchInput && canFocusInputOnScreenFocus()),
Expand Down
2 changes: 1 addition & 1 deletion src/components/TaxPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ function TaxPicker({
label: translate('common.search'),
value: searchValue,
onChangeText: setSearchValue,
headerMessage: getHeaderMessageForNonUserList((sections.at(0)?.data?.length ?? 0) > 0, searchValue),
headerMessage: getHeaderMessageForNonUserList(translate, (sections.at(0)?.data?.length ?? 0) > 0, searchValue),
};

const updatedSections = deletedTaxOption
Expand Down
4 changes: 2 additions & 2 deletions src/libs/OptionsListUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2908,9 +2908,9 @@ function getHeaderMessage(hasSelectableOptions: boolean, hasUserToInvite: boolea
/**
* Helper method for non-user lists (eg. categories and tags) that returns the text to be used for the header's message and title (if any)
*/
function getHeaderMessageForNonUserList(hasSelectableOptions: boolean, searchValue: string): string {
function getHeaderMessageForNonUserList(translate: LocalizedTranslate, hasSelectableOptions: boolean, searchValue: string): string {
if (searchValue && !hasSelectableOptions) {
return translateLocal('common.noResultsFound');
return translate('common.noResultsFound');
}
return '';
}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Debug/Report/DebugReportActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function DebugReportActions({reportID}: DebugReportActionsProps) {
value: searchValue,
label: translate('common.search'),
onChangeText: setSearchValue,
headerMessage: getHeaderMessageForNonUserList(searchedReportActions.length > 0, debouncedSearchValue),
headerMessage: getHeaderMessageForNonUserList(translate, searchedReportActions.length > 0, debouncedSearchValue),
}),
[debouncedSearchValue, searchValue, searchedReportActions.length, setSearchValue, translate],
);
Expand Down
2 changes: 1 addition & 1 deletion src/pages/DynamicNewReportWorkspaceSelectionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ function DynamicNewReportWorkspaceSelectionPage({route}: NewReportWorkspaceSelec
label: usersWorkspaces.length >= CONST.STANDARD_LIST_ITEM_LIMIT ? translate('common.search') : undefined,
value: searchTerm,
onChangeText: setSearchTerm,
headerMessage: getHeaderMessageForNonUserList(areResultsFound, debouncedSearchTerm),
headerMessage: getHeaderMessageForNonUserList(translate, areResultsFound, debouncedSearchTerm),
};

return (
Expand Down
2 changes: 1 addition & 1 deletion src/pages/EditReportFieldDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function EditReportFieldDropdown({onSubmit, fieldKey, fieldValue, fieldOptions}:
value: searchValue,
label: translate('common.search'),
onChangeText: setSearchValue,
headerMessage: getHeaderMessageForNonUserList(policyReportFieldData.length > 0, debouncedSearchValue),
headerMessage: getHeaderMessageForNonUserList(translate, policyReportFieldData.length > 0, debouncedSearchValue),
};

return (
Expand Down
Loading