[cp staging] Fix bulk action bar blocker - #102582
Conversation
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari2026-09-29.23.20.21.mov |
|
Nice thanks, those are two NABs so lets get this PR in to fix the bug, and krishna can handle the code quality cleanup in his PR here: #102572 |
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…ockers [cp staging] Fix bulk action bar blocker (cherry picked from commit b803ca2) (cherry-picked to staging by Julesssss)
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🔁 Filed a Staging retest request for deploy blockers #102492 after this PR was cherry-picked to staging. |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.95-2 🚀
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
No help site update needed. This PR fixes a deploy blocker by restoring the existing held-expenses header text in the bulk action bar's Approve menu, so no help article sentence becomes incorrect. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.96-0 🚀
|
|
No help site update needed. This PR fixes a deploy blocker by restoring the held-expenses header text in the bulk action bar's Approve menu, so no help article sentence becomes incorrect. |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.99-0 🚀
|
|
No help site update needed. This PR fixes a deploy blocker by restoring the held-expenses header text in the bulk Approve menu, which is an in-app message that explains itself and doesn't make any existing article sentence incorrect. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixes a deploy blocker for bulk actions
Fixed Issues
$ #102492
Tests
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-09-29.at.4.18.20.PM.mov