Skip to content

Implement full support ticket UI behind a beta - #102561

Merged
jasperhuangg merged 61 commits into
mainfrom
codex/pr-1-13-support-tickets
Oct 8, 2026
Merged

jasperhuangg merged 61 commits into
mainfrom
codex/pr-1-13-support-tickets

Conversation

@jasperhuangg

@jasperhuangg jasperhuangg commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

THIS IS BEHIND THE supportTicket BETA. For any related blockers, please demote and assign @jasperhuangg to investigate and fix.

Explanation of Change

Implements the full support ticket UI, including creation, resolution, reopen, and support ticket surveys.
Screenshot 2026-10-07 at 6 06 41 PM

Screenshot 2026-10-07 at 9 41 48 AM

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/684543
$ https://github.com/Expensify/Expensify/issues/684558
$ https://github.com/Expensify/Expensify/issues/684553
PROPOSAL:

Tests

Dev

Setup

Check out https://github.com/Expensify/Web-Expensify/pull/56710 and https://github.com/Expensify/Auth/pull/25179 if they aren't already merged

Create two @team.expensify.com accounts (the support reps) and run the following queries on them. You

INSERT INTO sharedNameValuePairs
    (accountID, ownerAccountID, name, permissions)
VALUES
    (<ACCOUNT_ID>, <FR_PLUS_POLICY_OWNER_ID>, '<FR_PLUS_POLICY_ID>', 'read');
INSERT OR REPLACE INTO nameValuePairs
    (accountID, name, value, created)
VALUES
    (<ACCOUNT_ID>, 'expensify_concierge_selectedQueues',
     '{"primary":["supportal"],"secondary":[]}', DATETIME('now'));

Ensure only 1 rep is in the queue in https://www.expensify.com.dev/concierge/#/ (click "Begin")
Create a policy admin and employee account.

Steps

  1. Create a ticket through Web-Expensify for an admin and policy employee.

    • In English, a ticket created on Sep 30, 2026 for Jane Doe and support rep John Smith is titled Support ticket, Sep 30, 2026: Jane Doe and John Smith.
    • The UI for the support ticket and preview action in the Concierge DM render as expected (see the mockups)
    • Change the App language and verify the header, ticket, preview, and LHN titles update.
    Screenshot 2026-09-30 at 4 12 50 PM
  2. Verify the preview action and support ticket checkbox are unchecked. Hovering over on web shows Your support rep will check this when it is resolved (mock). Tapping it shows a modal with the "Not so fast... Your support rep will check this when it is resolved.
    Screenshot 2026-09-30 at 4 12 27 PM
    Screenshot 2026-09-30 at 4 12 18 PM

  3. The ticket description shows: Hi, I'm <support rep first name>, and I'll work with you until this is fully resolved. If you've already shared details with us, I'll review them before responding so you don't need to repeat yourself. If this is a new issue, let me know what you need help with.

  4. For the policy admin, verify the book a call button opens the ticket rep's calendly link. For the employee, verify the book a call button doesn't render.

  5. Verify the customer can add comments to the support ticket.

  • comments added by the customer cannot be threaded or reacted to
  • the composer context menu only provides an "Add attachment" option.
  1. Click on the report header, verify it renders like this, with the assigned support rep's profile picture
    Screenshot 2026-09-30 at 4 17 32 PM
  2. Switch between the customer and assigned support rep, sending a message from each. Verify both messages appear as normal comments in the ticket.
  3. As the support rep, resolve a ticket.
    • The ticket and Concierge preview checkboxes are checked, the ticket doesn't appear in the #focus mode LHN, stays in Most Recent after reading, and hides the composer.
    • The customer sees This support ticket is resolved. and Reopen ticket. Only the newest post-close survey appears; the customer can select 👍 or 👎, and changing the rating leaves exactly one reaction.
  4. As the customer, reopen it while the original rep is online. Send a message as the customer.
    • The same ticket opens with its history and rep intact, both checkboxes clear, the composer returns, and the resolved footer and survey disappear.
    • A reopened action renders in the ticket.
  5. As the support rep, reply and resolve the ticket again. Verify the support ticket shows as resolved again
  6. Go offline as the original rep, go online as the other rep, then reopen as the customer.
    • Verify a new ticket opens with the new rep. The old ticket stays closed with the checkboxes checked. A handoff comment is posted in the new ticket that reads "Your support rep from this ticket is offline, so I'm taking over! I can see your earlier conversation, so there's no need to repeat anything. What's new since we last talked? Let me know and I'll pick it up from there." and links back to the old ticket correctly.

Staging QA

ping @jasperhuangg to QA

  1. InternalQA:
    • Set expensify_supportTicketQAAssigneeEmail as in PR 1.8 Staging QA step 1 for both a policy employee and admin.
    • Add both policy/admin accounts to the beta
  2. Use dev steps

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not captured.

Android: mWeb Chrome

Not captured.

iOS: Native

Not captured.

iOS: mWeb Safari

Not captured.

MacOS: Chrome / Safari

Not captured.

@OSBotify

This comment has been minimized.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 95.90% <ø> (ø)
...nents/Reactions/ReportActionItemEmojiReactions.tsx 87.50% <ø> (ø)
...ents/ReportActionAvatars/useReportActionAvatars.ts 89.53% <100.00%> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
...igation/helpers/getReportRouteForCurrentContext.ts 85.71% <100.00%> (ø)
src/libs/OptionsListUtils/index.ts 91.37% <100.00%> (+<0.01%) ⬆️
src/libs/ReportActionsUtils.ts 83.73% <100.00%> (+0.05%) ⬆️
src/libs/ReportNameUtils.ts 81.98% <100.00%> (+0.37%) ⬆️
src/libs/ReportUtils.ts 88.65% <100.00%> (+0.05%) ⬆️
...bs/actions/OnyxDerived/configs/reportAttributes.ts 96.65% <100.00%> (ø)
... and 22 more
... and 10 files with indirect coverage changes

Comment thread src/libs/ReportNameUtils.ts Outdated
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@jasperhuangg jasperhuangg changed the title PR 1.13: Show support tickets in App Show support tickets in App Oct 7, 2026
@jasperhuangg jasperhuangg changed the title Show support tickets in App Implement full support ticket UI Oct 7, 2026
Comment thread src/pages/inbox/HeaderView.tsx Outdated
Comment thread src/libs/actions/OnyxDerived/configs/visibleReportActions.ts Outdated
Comment thread src/pages/inbox/report/actionContents/ReportActionMessageContent.tsx Outdated
Comment thread src/components/SupportTicketResolvedFooter.tsx Outdated
@suneox

suneox commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android-steps-1-9.mp4
Android: mWeb Chrome
Step 1 Step 2 step 3
iOS: HybridApp
ios-steps-1-9.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web-steps-1-9.mp4

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product. core design doc issue

@jasperhuangg

Copy link
Copy Markdown
Contributor Author

Just need internal engineer review from @chiragsalian before we can merge this one!

@jasperhuangg jasperhuangg changed the title Implement full support ticket UI Implement full support ticket UI behind a beta Oct 8, 2026
title: translate('initialSettingsPage.talkToAHuman'),
description: translate('initialSettingsPage.helpPage.talkToAHumanDescription'),
icon: icons.ChatBubbles,
iconType: CONST.ICON_TYPE_ICON,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image
Suggested change
iconType: CONST.ICON_TYPE_ICON,
iconType: CONST.ICON_TYPE_ICON,
iconFill: theme.iconSuccessFill,

I can't access the design, but it looks like a success color

@suneox

suneox commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@jasperhuangg I've updated the verification based on the latest OP update. There's just one issue mentioned above, and the test steps in the description are a bit out of order.

UI Verify
android-full-steps.mp4

chiragsalian
chiragsalian previously approved these changes Oct 8, 2026
…-tickets

# Conflicts:
#	tests/unit/ReportUtilsTest.ts
@jasperhuangg
jasperhuangg merged commit 5ef81ba into main Oct 8, 2026
45 of 46 checks passed
@jasperhuangg
jasperhuangg deleted the codex/pr-1-13-support-tickets branch October 8, 2026 17:40
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 8, 2026
90 tasks done
@OSBotify

OSBotify commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.5.6-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. All user-facing changes in this PR are gated behind the supportTicket beta: the new Talk to a human entry point on the Help page only renders when isBetaEnabled(CONST.BETAS.SUPPORT_TICKET) is true, and the rest of the support ticket UI only appears on support ticket reports. Revisit the help site when the beta is removed.

@OSBotify

OSBotify commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

InternalQA This pull request required internal QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants