Use 'See chat history' copy and history icon on the profile chat history row - #102541
Conversation
…ory row Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
melvin-bot
Bot
added
Melvin-Test-Android
Melvin-Test-Web
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/el.ts b/src/languages/el.ts
index 3837c31e..dba28298 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -2246,7 +2246,7 @@ const translations: TranslationDeepObject<typeof en> = {
profileAvatar: 'Εικόνα προφίλ',
customInstructions: 'Προσαρμοσμένες οδηγίες',
copilotIntoAccount: 'Οδηγός εντός λογαριασμού',
- seeChatHistory: 'Προβολή ιστορικού συνομιλίας',
+ seeChatHistory: 'Δείτε το ιστορικό συνομιλιών',
viewAgentHistory: 'Προβολή ιστορικού αντιπροσώπου',
publicSection: {
title: 'Δημόσιο',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index a6af7c82..5b843c67 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -2117,7 +2117,7 @@ const translations: TranslationDeepObject<typeof en> = {
profileAvatar: 'Perfil avatar',
customInstructions: 'Instrucciones personalizadas',
copilotIntoAccount: 'Copilot a la cuenta',
- seeChatHistory: 'Ver historial de chat',
+ seeChatHistory: 'Ver historial del chat',
viewAgentHistory: 'Ver historial del agente',
publicSection: {
title: 'Público',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index fec52187..27ff5d67 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2207,7 +2207,7 @@ const translations: TranslationDeepObject<typeof en> = {
profileAvatar: 'Avatar de profil',
customInstructions: 'Instructions personnalisées',
copilotIntoAccount: 'Copilot dans le compte',
- seeChatHistory: 'Voir l’historique du chat',
+ seeChatHistory: 'Voir l’historique de discussion',
viewAgentHistory: 'Voir l’historique de l’agent',
publicSection: {
title: 'Public',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index db635114..d59c2342 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2194,7 +2194,7 @@ const translations: TranslationDeepObject<typeof en> = {
profileAvatar: 'Avatar profilo',
customInstructions: 'Istruzioni personalizzate',
copilotIntoAccount: "Copilot nell'account",
- seeChatHistory: 'Visualizza cronologia chat',
+ seeChatHistory: 'Vedi cronologia chat',
viewAgentHistory: 'Visualizza cronologia agente',
publicSection: {
title: 'Pubblico',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
🤖 Android test steps verification results: The PR's Tests section is still a TODO, so I tested the behavior described in the PR. For a human user, the row reads "See chat history", shows the History (clock) icon, and opens Search with type:chat and from:; the agent variant could not be reached from a fresh test account.
|
|
🤖 Web test steps verification results: The PR's Tests section is still a TODO, so I tested the behavior described in the PR. For a human user, the row reads "See chat history", shows the History (clock) icon, and opens Search filtered to chats from that user; the agent variant and the JS console could not be checked.
|
|
@MelvinBot Please apply the polyglot parrot patch as mentioned in #102541 (comment) |
Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
|
@MelvinBot Tidy the tests/QA sections with the following test steps. Steps:
|
|
The failing Analysis: 2 tests in Evidence
|
|
I updated the Tests and QA Steps sections of the PR description with your five steps. I removed the TODO placeholders and kept the JS console checkbox in both sections. I didn't change any other part of the description. |
|
Nothing has changed since my earlier analysis. The only failing check is still the same What you need to do: open the failed job and click Re-run failed jobs. I can't trigger reruns from here. Why it's unrelated
|
|
Both failing checks come from code outside this PR, so I didn't push a fix.
Evidence
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp102541-android-hybrid-001.mp4Android: mWeb Chrome102541-mweb-chrome-001.mp4iOS: HybridApp102541-ios-hybrid-001.mp4iOS: mWeb Safari102541-mweb-safari-001.mp4MacOS: Chrome / Safari102541-web-chrome-001.mp4 |
|
@MelvinBot Please tick the boxes in the PR Author Checklist section as I have already verified these in PR Reviewer Checklist as a co-author |
|
I ticked all 38 boxes in the PR Author Checklist, based on your Reviewer Checklist. The rest of the PR description is unchanged. That includes the "Verify that no errors appear in the JS console" boxes under Tests and QA Steps, which are outside the Author Checklist. |
|
@MelvinBot Please mark the PR as ready for review. |
|
I couldn't mark this PR as ready for review. This run doesn't have permission to change the PR's draft status, so it's still a draft. As the assignee, you can click Ready for review at the bottom of the PR page. You can also run |
…MemberDetails Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
|
Fixed the failing checks by merging
The merge had no conflicts. I could not run Jest or ESLint locally because those tools fail in my environment, even on tests that pass in CI. CI will rerun both checks on the new commit.
|
|
🚧 iwiznia has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.5.0-0 🚀
|
|
No help site update is needed. No article under |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀
Bundle Size Analysis (Sentry): |
4 participants
Explanation of Change
The chat history row on the profile page said "View member history" for human members and used a search icon. The label didn't say where the row goes, and the search icon didn't fit a history action.
This PR:
profilePage.viewMemberHistorytranslation key toprofilePage.seeChatHistoryand sets the English copy to "See chat history" (with matching translations in every locale).MagnifyingGlassicon with the existingHistoryicon for both humans and agents, matching the design mockup on the issue.ProfilePageUI tests to expect the new label.The search query and navigation are unchanged.
Fixed Issues
$ #102270
PROPOSAL: #102270 (comment)
Tests
type:chat from:<accountID>).Offline tests
QA Steps
type:chat from:<accountID>).PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari