Repository navigation
[No QA] Update help docs for Release 1: Greenhouse and Classic Parity - #102428
Conversation
Co-authored-by: Garrett Knight <garrettmknight@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot update the docs/articles/new-expensify/connections/Connect-a-recruiting-integration-to-Expensify.md page to follow the patterns for our HR integrations: https://help.expensify.com/articles/new-expensify/connections/Connect-BambooHR-to-Expensify. Each one has it's own page, there isn't a general 'Connect-an-hr-integration page. |
…h HR integration article pattern Co-authored-by: Garrett Knight <garrettmknight@users.noreply.github.com>
|
I renamed the recruiting article to a Greenhouse-specific page that follows the BambooHR article's structure, and pushed it in f6b95c2.
One thing to check: |
This comment has been minimized.
This comment has been minimized.
|
|
||
| - Add Greenhouse candidates who match your import settings to your Expensify workspace. | ||
| - Set each candidate's expense approver, including their recruiter or recruiting coordinator from Greenhouse. | ||
| - Remove candidates from the workspace when they no longer match your import settings. |
There was a problem hiding this comment.
Remove candidates from the workspace when they no longer match your import settings.
Remove this, we don't deprovision.
|
|
||
| - New candidates who match your import settings are added to the workspace. | ||
| - Candidate details are updated to match Greenhouse. | ||
| - Candidates who no longer match your import settings are removed from the workspace automatically. |
There was a problem hiding this comment.
Remove this, we're changing the code for this one.
Updated instructions for importing candidates from Greenhouse to clarify filter usage and sync behavior.
Removed the line about removing candidates from the workspace when they no longer match import settings.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@aimane-chnaif @kadiealexander One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
This comment has been minimized.
This comment has been minimized.
|
@kadiealexander @stephanieelliott ready for review, a couple notes:
|
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
Updated examples for filtering candidate imports using Job stages, Tags, and Offices.
|
@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae316d26f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
Clarified conditions under which the Greenhouse sync complete screen appears after a sync.
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://bfc6bbeb.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.4.96-0 🚀
|
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.4.99-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Adds help docs for the new workspace Recruiting feature, which connects Greenhouse in New Expensify and imports candidates based on filters. Nothing on the help site covered this feature yet, and the NewDot Greenhouse URL was sending people to the Classic webhook steps.
docs/articles/new-expensify/connections/Connect-a-recruiting-integration-to-Expensify.md. It covers who can connect (Control plan, Workspace Admin), how to turn on Recruiting, how to connect Greenhouse, Import settings (you must turn on Job stages or Tags; Offices is optional), Default approver (Basic, Advanced, and Custom approval), sync results, the daily auto-sync (which removes candidates who no longer match), Sync now (limited to 2 per 24 hours), Disconnect, and an FAQ. UI labels matchsrc/languages/en.ts.docs/redirects.csv:new-expensify/connections/Greenhousenow points to the new article instead ofdocs/Hidden/Greenhouse, which was a copy of the Classic webhook instructions.AI tests: I couldn't run
createDocsRoutes.shorverifyRedirect.shlocally, becausenpm cifailed on a Node engine mismatch (the repo needs 26.5.0; the runner has 24.19.0). I checked the redirect by hand instead. The changed line keeps the same source URL, so there's no duplicate, and the new destination isn't a redirect source anywhere, so there's no cycle.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/673061
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari