[chrispader]

The new Onyx SQLite provider requires NitroSQLite 10.2.0. I updated react-native-onyx from 3.0.120 to 3.0.121 and react-native-nitro-sqlite from 9.8.3 to 10.2.0.

Explanation of Change

This integrates the provider changes from Onyx #851. Extensive benchmarks were already completed and reported in that Onyx PR.

Fixed Issues

$ #102424

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14179

Tests

Use an iOS or Android build containing this PR and the linked Mobile-Expensify PR. Sign in before starting.

Message persistence:

1. Open an existing chat.
2. Send a message.
3. Edit the message.
4. Force-close the app.
5. Reopen the app. Verify the edited message appears once and the previous chat history is still visible.

Offline expense and sync:

1. Turn off the network connection.
2. Create a manual expense with a merchant and amount.
3. Force-close the app.
4. Reopen the app while offline. Verify the merchant and amount persist.
5. Restore the network connection. Verify the expense syncs with the same details and no duplicate is created.

Verify there are no JS console errors during either flow.

Offline tests

Covered by the offline expense and sync flow in Tests.

QA Steps

Run the full QA suite on all supported platforms, especially the two flows in Tests. Use a HybridApp staging build containing both linked PRs for native testing.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above

• I wrote clear testing steps that cover the changes made in this PR

  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

• I included screenshots or videos for tests on all platforms

• I ran the tests on all platforms & verified they passed on:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari

• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

• I followed proper code patterns (see Reviewing the code)

  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)

• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

• I followed the guidelines as stated in the Review Guidelines

• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)

• If a new CSS style is added I verified that:

  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

• If new assets were added or existing ones were modified, I verified that:

  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.

• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.

• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.

• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.

• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.

• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

• Verify that no errors appear in the JS console

• Verify that no errors appear in the JS console

• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)

• If the PR adds or modifies the UI:

  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).

Screenshots/Videos

Attach a screenshot of the edited message after relaunch and a screenshot of the synced expense after reconnecting.

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 13 files with indirect coverage changes

[chrispader]

@MelvinBot create a new issue for upgrading NitroSQLite from 9.8.2 (after #101448 has been merged) to latest 10.0.0. NitroSQLite added new features such as prepared statements, independent DB connections and multiple performance improvements.

This requires also updating the peer dependency range in Onyx.

@MelvinBot assign me to the issue and add it to the PR description here and in Expensify/react-native-onyx#851!

[MelvinBot]

I created chore(deps): Upgrade NitroSQLite from 9.8.2 to 10.0.0 and assigned you. It is held on chore(deps): Update NitroSQLite from 9.6.0 to 9.8.0. It covers prepared statements, independent connections, the performance improvements, and the Onyx peer dependency range update.

• This PR: I replaced the ### Fixed Issues link with the new issue and added a "Depends on" line for the 9.8.0 issue.
• chore(deps): Require NitroSQLite 10: Not updated. GitHub returned 403 Resource not accessible by personal access token. Please replace the ### Related Issues link with [Due for payment 2026-11-10] chore(deps): Upgrade NitroSQLite from 9.8.3 to 10.2.0 #102424 yourself.

I found no existing issue for this upgrade.

[melvin-bot]

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-12T17:24:11.193455Z	682344e	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chrispader]

#102135 has been merged, so only holding onto #103208 now!

[chrispader]

@NicolasBonet @ikevin127 the PR is off hold. Feel free to review and merge! Since this has already thoroughly benchmarked and tested in Expensify/react-native-onyx#851, i think we can just merge, right?

[NicolasBonet]

@dmkt9 please confirm everything looks good on your end and add the pr reviewer!

[dmkt9]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.hybrid.mp4

Android: mWeb Chrome

iOS: HybridApp

ios.hybrid.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

[dmkt9]

LGTM

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102422 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-471df890-f89e1f8-9821650952510ae53cb46b12d455781c778ea4b0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-471df890-f89e1f8-023c33fd50e2c24a9c7d2aba34d0f5a42a08c612/index.html

Web 🕸️
https://102422.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.28-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS