[Refactor] Move buildOptimisticTransaction and getUpdatedTransaction out of TransactionUtils/index.ts by MelvinBot · Pull Request #102398 · Expensify/App

MelvinBot · 2026-09-28T09:16:43Z

Explanation of Change

src/libs/TransactionUtils/index.ts was over the 4000-line max-lines ESLint cap and had the rule disabled. This is step 1 of the split plan on the issue. It makes two pure moves:

buildOptimisticTransaction and its TransactionParams and BuildOptimisticTransactionParams types move to TransactionUtils/buildOptimisticTransaction.ts.
getClearedPendingFields, getDistanceMerchantForTransaction, getRecalculatedDistanceMerchant, and getUpdatedTransaction move to TransactionUtils/getUpdatedTransaction.ts.

index.ts goes from 4011 to 3223 lines, so this PR removes the /* eslint-disable max-lines */ header.

The moved code is byte-identical to the original. There are no renames, signature changes, or logic edits. index.ts still exports the same public API through its existing export {…} block, so none of the ~215 files that import @libs/TransactionUtils change, and existing jest.mock('@libs/TransactionUtils', …) mocks keep working.

Notes for reviewers:

The new files import a few helpers back from ./index, which creates an import cycle. I suppressed import/no-cycle with a comment on both sides, following the precedent of ReportNameUtils, which was split out of ReportUtils. The cycle is safe because neither side calls the other at module load. The cycle goes away once later steps of the plan move those helpers out of index.ts.
getDistanceMerchantForTransaction moved with the update helpers. index.ts imports it for getDisplayTransactionWithoutInvalidCommuterExclusion but doesn't re-export it, so it stays private as before.
config/eslint/eslint.seatbelt.tsv: the two grandfathered translateLocal deprecation warnings moved with the code, so this PR moves their allowance from index.ts (3 → 1) to getUpdatedTransaction.ts (2). The total is unchanged.

AI tests run locally:

npm run typecheck: passed
npm run lint on the changed files: passed
npm run spell-changed: passed
Jest: tests/unit/TransactionUtilsTest.ts, TransactionTest, TransactionPreviewUtils.test, MergeTransactionUtilsTest, ViolationUtilsTest, ModifiedExpenseMessageTest, IOUUtilsTest, ReportUtilsTest, TagsOptionsListUtilsTest, all of tests/actions/IOUTest/, tests/ui/LHNItemsPresence.tsx, and the 9 suites that jest.mock('@libs/TransactionUtils'). All passed: 3367 tests. One SplitTest case timed out once while the suites ran in parallel, then passed on rerun, and the full SplitTest.ts suite passed on its own (144/144).
I didn't run the formatter (oxfmt) or the Storybook smoke test in this environment. No component files changed.

Fixed Issues

$ #102012
PROPOSAL: #102012 (comment)

Tests

Open the App
Go to the workspace chat
Submit a manual expense
Verify the expense shows the amount and merchant you entered
Edit the amount
Verify the expense shows the new amount

Verify that no errors appear in the JS console

Offline tests

Same as Tests step

QA Steps

Same as Tests step

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…sactionUtils/index.ts Pure move of buildOptimisticTransaction and the getUpdatedTransaction group into sibling files, re-exported from the TransactionUtils barrel so no consumer imports change. This brings index.ts back under the 4000-line max-lines limit, so the eslint-disable is removed. Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>

MelvinBot · 2026-09-28T09:17:03Z

I created this PR from an upstream branch because I don't have push access to your fork.

To take ownership of this branch and push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-splitTransactionUtilsStep1
git checkout -b claude-splitTransactionUtilsStep1 upstream/claude-splitTransactionUtilsStep1
git push -u origin claude-splitTransactionUtilsStep1

Then you can close this PR and open a new one from your fork.

codecov · 2026-09-28T09:20:41Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/TransactionUtils/index.ts	`93.14% <ø> (-0.48%)`	⬇️
...ibs/TransactionUtils/buildOptimisticTransaction.ts	`94.52% <94.52%> (ø)`
src/libs/TransactionUtils/getUpdatedTransaction.ts	`96.80% <96.80%> (ø)`
... and 160 files with indirect coverage changes

MelvinBot · 2026-09-28T09:22:49Z

🤖 Web test steps verification results: ⚠️ partial

I created a manual expense (12.34 / Test) and edited its amount to 56.78 and its merchant to UpdatedMerchant on dev NewDot web. The app showed no errors, and every network call returned 200. I couldn't read the raw JS console, because the web test tool has no console log command.

Step	Status
Manual expense created with amount 12.34 and merchant Test The Expenses list shows the new row with $12.34 and "Test". `RequestMoney` returned 200.	✅
Editing the amount (12.34 → 56.78) saves correctly The amount field shows $56.78. Report history says: "New amount is '$56.78' (previously '$12.34')". `UpdateMoneyRequestAmountAndCurrency` returned 200.	✅
Editing the merchant (Test → UpdatedMerchant) saves correctly The merchant field shows UpdatedMerchant. Report history says: "New merchant is 'UpdatedMerchant' (previously 'Test')". `UpdateMoneyRequestMerchant` returned 200.	✅
Verify that no errors appear in the JS console Not checked directly: the web test tool can't read console output. As a proxy, I checked the network log for the whole session. No request failed, and no error banner or toast appeared on screen.	⚠️

view run · view recording

MelvinBot · 2026-09-28T09:36:05Z

🤖 Android test steps verification results: ✅ pass

On standalone Android NewDot, I created a manual expense (12.34 / Test), then edited its amount and merchant. Both edits saved correctly, and the JS console showed no errors or crashes.

Step	Status
Manual expense created with amount 12.34 and merchant Test The Expenses list showed "Test, $12.34, Sep 28, Cash" right after creation. The expense detail view showed Amount $12.34 and Merchant Test.	✅
Editing the amount (12.34 → 56.78) saves correctly After Save, the detail view showed "Amount • Cash • Reimbursable, $56.78".	✅
Editing the merchant (Test → Updated Merchant) saves correctly After Save, the detail view showed "Merchant, Updated Merchant".	✅
Verify that no errors appear in the JS console The `ReactNativeJS` logcat stream had zero error-level lines for the whole flow, and no RedBox appeared. It had 4 generic warnings: a receiver type warning, a navigation prop warning, a slow ActivityIndicator warning, and a CurrencyUtils "defaulting to USD" warning. None relate to the moved code, and the expense currency was USD.	✅

view run · view recording

ahmedGaber93 · 2026-09-28T16:56:28Z

+/**
+ * Optimistically generate a transaction.
+ *
+ * @param amount – in cents
+ * @param [existingTransactionID] Reuse this ID when a distance expense already created an empty transaction.
+ */


@MelvinBot This notes still describe the amount and the reused transaction id as if they were separate arguments. The builder takes one set of details. Put the note that the amount is in cents on amount, and put the note about reusing an id when a distance expense already created an empty transaction on existingTransactionID. Remove the argument notes that do not match.

Done in 85a5dca:

TransactionParams.amount now notes that the amount is in cents.

BuildOptimisticTransactionParams.existingTransactionID now notes that the ID is reused when a distance expense already created an empty transaction.

I removed the two @param lines from the function comment.

ESLint passes on the file.

view run

…nsactionID Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>

ahmedGaber93 · 2026-09-28T17:06:32Z

@MelvinBot Please update