Give HTML system messages the wrapping styles the text branch already has by mukhrr · Pull Request #102382 · Expensify/App

mukhrr · 2026-09-28T05:00:08Z

Explanation of Change

System messages that render HTML went into a wrapper carrying no wrapping styles, so a long unbreakable word could not break and the narrow RHP column clipped it. This change puts the existing renderHTML style on that wrapper, so those messages wrap the way plain-text system messages already do.

Fixed Issues

$ #99937
PROPOSAL: #99937 (comment)

Tests

Preconditions: an account that has never used Accounting, a QuickBooks Online company in which the submitter's email does not already exist as a vendor, and a desktop window at least 1280px wide.

Create a workspace and enable Accounting under More features.
Connect QuickBooks Online and wait for the first sync to finish.
In Accounting > Advanced, turn off Auto-create entities.
Open the workspace chat and create one expense.
Submit the report, approve it, then pay it.
Open that report from Reports so it opens in the right-hand pane next to the receipt.
Scroll to the export failure system message and verify the whole message is readable, with the long email address wrapping onto the next line instead of being cut off at the right edge of the column.

Verify that no errors appear in the JS console

Offline tests

The message is rendered from report action data already in Onyx and the change only affects how that text wraps, so network state cannot alter it. To confirm no regression: with the report open in the right-hand pane, turn off your network connection and verify the system message still renders complete and wrapped, then reconnect and verify it is unchanged.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

… has ReportActionItemBasicMessage styles its plain-text branch with chatItemMessage, which carries maxWidth, pre-wrap and break-word. The children branch, used by every <comment><muted-text> system message, rendered into an unstyled View, so the text inside kept word-break: normal. An unbreakable token in the copy, such as the submitter address a QuickBooks export error quotes, then set the block's minimum width and the wide RHP action column clipped every line. styles.renderHTML holds the same three properties and is how the repo already wraps a RenderHTML elsewhere. Both word-break and white-space inherit, so they reach the text node the renderer creates.

melvin-bot · 2026-09-28T05:00:15Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mukhrr · 2026-09-28T07:16:35Z

@Krishna2323 this is ready now

garrettmknight

Looks good from a product perspective

Krishna2323 · 2026-10-02T07:58:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: HybridApp

ios_hybrid.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

Krishna2323 · 2026-10-02T07:58:32Z

@mukhrr please merge main

Krishna2323

LGTM!

OSBotify · 2026-10-02T14:21:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-02T14:56:13Z

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-02T15:00:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102382.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ba7c8b4-48df62a-5d756cbd709ac38bf735a9a8e0d7f210d27cda2d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ba7c8b4-48df62a-188305b4be4132ca00cca04d6127e6d3fae60ad8/index.html

Web 🕸️
https://102382.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-05T00:20:59Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.5.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-05T00:24:55Z

No help site update is needed. This PR is a layout bug fix that lets long words in system messages wrap instead of being cut off, and no help article describes that behavior.

view run

OSBotify · 2026-10-05T23:14:37Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.2-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

mukhrr requested review from a team as code owners September 28, 2026 05:00

melvin-bot Bot assigned mukhrr Sep 28, 2026

melvin-bot Bot requested a review from Krishna2323 September 28, 2026 05:00

melvin-bot Bot requested review from garrettmknight and removed request for a team September 28, 2026 05:00

garrettmknight approved these changes Sep 28, 2026

View reviewed changes

Krishna2323 approved these changes Oct 2, 2026

View reviewed changes

melvin-bot Bot requested a review from marcochavezf October 2, 2026 08:05

marcochavezf approved these changes Oct 2, 2026

View reviewed changes

marcochavezf merged commit ba7c8b4 into Expensify:main Oct 2, 2026
42 of 44 checks passed

OSBotify mentioned this pull request Oct 4, 2026

Deploy Checklist: New Expensify 2026-10-04 #102948

Closed

59 tasks done

melvin-bot Bot mentioned this pull request Oct 5, 2026

[Due for payment 2026-10-12] RHP - System message is truncated #99937

Closed

1 of 7 tasks

Krishna2323 mentioned this pull request Oct 13, 2026

Add Super Wide RHP Routes #75886

Merged

52 of 54 tasks

Navigation Menu

Repository navigation

Give HTML system messages the wrapping styles the text branch already has - #102382

Give HTML system messages the wrapping styles the text branch already has#102382
marcochavezf merged 1 commit into
Expensify:mainfrom
mukhrr:fix/99937

mukhrr commented Sep 28, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Sep 28, 2026

Uh oh!

mukhrr commented Sep 28, 2026

Uh oh!

garrettmknight left a comment

Uh oh!

Krishna2323 commented Oct 2, 2026 •

edited

Loading

Uh oh!

Krishna2323 commented Oct 2, 2026

Uh oh!

Krishna2323 left a comment

Uh oh!

Uh oh!

OSBotify commented Oct 2, 2026

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

OSBotify commented Oct 5, 2026

Uh oh!

MelvinBot commented Oct 5, 2026

Uh oh!

OSBotify commented Oct 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mukhrr commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 28, 2026

Uh oh!

mukhrr commented Sep 28, 2026

Uh oh!

garrettmknight left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Oct 2, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 2, 2026

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

OSBotify commented Oct 5, 2026

Uh oh!

MelvinBot commented Oct 5, 2026

Uh oh!

OSBotify commented Oct 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mukhrr commented Sep 28, 2026 •

edited

Loading

Krishna2323 commented Oct 2, 2026 •

edited

Loading