Skip to content

Refresh Home data with OpenHomePage - #102341

Merged
blimpich merged 6 commits into
mainfrom
blimpich-openHomePage
Sep 29, 2026
Merged

Refresh Home data with OpenHomePage#102341
blimpich merged 6 commits into
mainfrom
blimpich-openHomePage

Conversation

@blimpich

@blimpich blimpich commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Calls the new command OpenHomePage when the home page is loaded.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/668261
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Open a new browser tab.
  2. Open the browser's developer tools and go to the Network tab.
  3. Go to https://staging.new.expensify.com and sign in.
  4. Confirm an OpenHomePage request is sent once Home loads.
  5. Go to a different tab, such as Inbox.
  6. Go back to Home.
  7. Confirm a new OpenHomePage request is sent.
  • Verify that no errors appear in the JS console

Screenshots/Videos

@codecov

codecov Bot commented Sep 25, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/API/types.ts 100.00% <ø> (ø)
src/libs/actions/HomePage.ts 100.00% <100.00%> (ø)
src/pages/home/HomePage.tsx 100.00% <100.00%> (ø)
... and 18 files with indirect coverage changes

@blimpich blimpich changed the title [HOLD Auth#24883, Web#56494] Refresh Home data with OpenHomePage [HOLD] Refresh Home data with OpenHomePage Sep 26, 2026
@blimpich
blimpich marked this pull request as ready for review September 29, 2026 00:40
@blimpich
blimpich requested review from a team as code owners September 29, 2026 00:40
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team September 29, 2026 00:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T00:53:25.269163Z 89f2ae9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@blimpich blimpich changed the title [HOLD] Refresh Home data with OpenHomePage [HOLD][NO QA] Refresh Home data with OpenHomePage Sep 29, 2026
@melvin-bot
melvin-bot Bot requested review from Gonals and removed request for a team September 29, 2026 00:41
@melvin-bot

melvin-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@blimpich
blimpich requested review from flodnv and rlinoz and removed request for Gonals and JmillsExpensify September 29, 2026 00:41
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Sep 29, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89f2ae91ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pages/home/HomePage.tsx Resolved
@blimpich blimpich changed the title [HOLD][NO QA] Refresh Home data with OpenHomePage [NO QA] Refresh Home data with OpenHomePage Sep 29, 2026
@blimpich blimpich changed the title [NO QA] Refresh Home data with OpenHomePage Refresh Home data with OpenHomePage Sep 29, 2026
@blimpich blimpich mentioned this pull request Sep 29, 2026
Merged
2 tasks done
@blimpich
blimpich merged commit 8543f30 into main Sep 29, 2026
38 of 39 checks passed
@blimpich
blimpich deleted the blimpich-openHomePage branch September 29, 2026 22:29
@blimpich

blimpich commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Merging as this is a blocker for getting the renewals PRs

@github-actions

github-actions Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102341.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8543f30-68912d2-a0cc74c5aa9990fb7bfc9e196d4135d8a8590181/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8543f30-68912d2-c398f3860db8f9bab347a7dd419624d34fef2b66/index.html
Android iOS
Web 🕸️
https://102341.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Sep 30, 2026
Closed
66 tasks done
@OSBotify

OSBotify commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.96-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

MelvinBot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

No help site update is needed: this PR only refreshes Home data in the background when you open Home, so it adds no new feature and changes nothing an existing article describes.

view run

@MelvinBot MelvinBot mentioned this pull request Sep 30, 2026
Closed
1 of 7 tasks
@OSBotify

OSBotify commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.99-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

No help site update needed. This PR only adds a background OpenHomePage request that refreshes Home data when you open Home or reconnect. It doesn't add, rename, or remove any feature, setting, or step that a help article describes.

view run

@OSBotify

OSBotify commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@rlinoz rlinoz rlinoz approved these changes
@flodnv flodnv Awaiting requested review from flodnv

Assignees

@blimpich blimpich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blimpich @OSBotify @MelvinBot @flodnv @rlinoz