You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// TODO: These must be filled out, or the issue title must include "[No QA]."
Verify that no errors appear in the JS console
PR Author Checklist
I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I added steps for local testing in the Tests section
I added steps for the expected offline behavior in the Offline steps section
I added steps for Staging and/or Production testing in the QA steps section
I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If a new CSS style is added I verified that:
A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
The assets are optimized and compressed (for SVG files, run npm run compress-svg)
The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
This PR adds one new article, XERO45-Export-Error.md, documenting how to resolve the XERO45 export error in Xero, and applies a link-casing fix (Connect-to-Xero to Connect-To-Xero) across three existing troubleshooting articles. The new article is well-structured and clearly written. The casing fixes are correct: the actual target file is Connect-To-Xero.md, so these edits repair broken relative links.
Scores Summary
Readability: 9/10 - Clear, concise prose with logical flow, sequential numbered steps, and a strong FAQ. Easy to scan.
AI Readiness: 9/10 - Complete YAML frontmatter including a precise internalScope with explicit exclusions, task-based headings throughout, correct hierarchy (single title heading plus FAQ, only sub-headings for sections), full feature names, and good keyword coverage.
Style Compliance: 6/10 - Mostly compliant, but the navigation phrasing violates naming conventions (see below).
Key Findings
Prohibited navigation language: Step 2 uses "Navigate to Workspaces > [Workspace Name] > Accounting". The phrase "Navigate to" is explicitly listed as prohibited in HELPSITE_NAMING_CONVENTIONS.md. The TEMPLATE.md pattern is a single unified path: "Go to Settings > Workspaces > Workspace Name > Accounting".
Split/awkward navigation: The steps split navigation across step 1 (Settings) and step 2 (Workspaces > ... > Accounting). Prefer the template single-step "Go to Settings > Workspaces > [Workspace Name] > Accounting" for consistency with the rest of the Xero troubleshooting set.
Navigation menu phrasing: "left-side navigation menu" does not match the convention standard wording ("in the navigation tabs on the left").
Positives: Excellent internalScope that disambiguates this article from the XERO45 sync error and mapping config; correct button bolding (Sync Now, Reconnect, Allow Access, Export to, Xero); descriptive cross-link anchor text with a relative link, placed outside numbered steps; strong, question-based FAQ.
Link-casing fixes are correct and necessary; verified target file is Connect-To-Xero.md.
Recommendations
Replace "Navigate to" with "Go to" and consolidate the navigation into a single step matching TEMPLATE.md: "Go to Settings > Workspaces > [Workspace Name] > Accounting".
Align the menu reference with the naming conventions ("navigation tabs on the left") or the template "Go to Settings" form for consistency across the Xero troubleshooting articles.
Files Reviewed
docs/articles/expensify-classic/connections/xero/Troubleshooting/Export-Errors/XERO45-Export-Error.md (new) - High quality; only the navigation phrasing needs adjustment.
The article is within a hub that makes sense, and the navigation is correct
All processes, screenshots, and examples align with current product behavior.
All links within the doc have been verified for correct destination and functionality.
I have verified the readability of the article
The article's language is clear, concise, and free of jargon.
The grammar, spelling, and punctuation are correct.
The article contains at least one image, or that an image is not necessary
I have verified the formatting of the article
The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
The article has proper text spacing and breaks for readability.
I have verified the article has the appropriate tone and style
The article's tone is professional, friendly, and suitable for the target audience.
The article's tone, terminology, and voice are consistent throughout.
I have verified the overall quality of the article
The article is not missing any information, nor does it contain redundant information.
The article fully addresses user needs.
I have verified that all requested improvements have been addressed
@marufsharifi@zanyrenney One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds a help article for the XERO45 export error, as only articles for the sync form of the error exist currently.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/679834
PROPOSAL: N/A
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari