Queue bulk mark-as-exported for the full matching search under select-all by ishpaul777 · Pull Request #102206 · Expensify/App

ishpaul777 · 2026-09-24T15:26:33Z

Explanation of Change

Wires up the App side of bulk "Mark as exported" from Search. Today, when "Select all matching" is checked, clicking "Mark as exported" for a connection only marks the reports currently loaded on the page, since it sends the finite list of loaded report IDs.

This change sends the search query to a new QueueBulkMarkAsExported Auth command instead, so the backend resolves and marks every matching report on that connection, the same way bulk pay already works. When the user has a specific, finite selection (not "select all matching"), the existing per-report export / manually-exported flow is unchanged.

Fixed Issues

$ #101106
PROPOSAL:

Tests

Connect a workspace to an accounting integration (e.g. Xero) and set your account as the exporter for that connection.
Create more approved, unexported reports than fit on a single Search results page (e.g. 60+), so pagination is in effect.
Go to Search > Reports, filtered to reports ready to export.
Click "Select all" so "Select all matching X" is active, covering more reports than are currently loaded.
Open the bulk actions menu and click "Mark as exported" for the connection.
Verify the selection clears and a success sound plays.
After the background jobs run (wait for few seconds), verify every matching report across all pages is marked as exported, not just the ones on the loaded page.
Repeat with a smaller, specific selection (not "select all matching") and verify the existing per-report export / manually-exported modal flow still works unchanged.

Verify that no errors appear in the JS console

Offline tests

Queuing this command requires connectivity to reach the backend, matching the existing bulk pay action. When offline, the write command queues in Onyx like any other Search bulk action and sends once the connection is restored.

Verify that no errors appear in the JS console

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-09-24.at.9.21.43.PM.mov

…-all

…bulk-mark-as-exported

melvin-bot · 2026-09-24T15:26:41Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-09-24T15:31:16Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/hooks/useSearchBulkActions.ts	`76.70% <95.00%> (+0.18%)`	⬆️
src/libs/actions/Search.ts	`65.57% <0.00%> (+0.19%)`	⬆️
... and 202 files with indirect coverage changes

…ported

JmillsExpensify

Change explanation and testing steps LGTM.

trjExpensify · 2026-09-28T13:05:24Z

@mananjadhav can you review this today, please? Eager to close this out for the customer. Thanks!

mananjadhav · 2026-09-28T13:38:17Z

Yes. I’ll finish the review today. I did a quick review earlier. Will work on the comments today and finish the checklist.

mananjadhav · 2026-09-28T15:38:27Z

+                    // set, so the partial-export and export-again modals below (built from page-scoped counts) do
+                    // not apply. Send the query instead of the loaded IDs, the same way bulk pay does, so the
+                    // backend resolves and marks every matching report on this connection, not just this page.
+                    const handleMarkAllMatchingAction = () => {


question: Offline still queues the command, clears the selection, and plays the success sound. Is that right?

yes i think its fine we do that or do you suggest we should block this offline?

Yes. I think we should block it like we do for other actions, wdyt?

okay sounds good fixed!

mananjadhav · 2026-09-28T15:40:27Z

@ishpaul777 No test covers queueBulkMarkAsExported. Can we add one for select all (serialized query + connection, no markAsManuallyExported), one for a limited selection (still markAsManuallyExported), and if needed one for offline (modal, command not queued).

mananjadhav · 2026-09-28T15:59:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

NA

Android: mWeb Chrome

NA

iOS: HybridApp

NA

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

web-queued-mark-as-exported-1.mov

web-queued-mark-as-exported-2.mov

mananjadhav · 2026-09-28T15:59:58Z

@ishpaul777 Left a few comments before the checklist.

mananjadhav

Just one last comment about the offline behavior.

Can be merged once covered.

Beamanator · 2026-09-28T18:51:12Z

sorry got a comment here: #102206 (comment) 🙏

QBO and Intuit Enterprise Suite share the same connectionName, so Auth can't yet tell them apart; it will read this once the backend fix lands.

Only set for a QBO connection that is the Intuit Enterprise Suite variant, reusing the existing ACCOUNTING_INTEGRATION_ALIASES pattern instead of inventing a new boolean.

Beamanator · 2026-09-29T15:26:57Z

Looks like we're just waiting on https://github.com/Expensify/Web-Expensify/pull/56543 (merged today) to get deployed to staging, then we can continue testing this PR 🙏

…ported

ishpaul777 · 2026-10-01T16:47:26Z

@mananjadhav can you please rereview last few changes since your approval

…ported

ishpaul777 · 2026-10-01T16:55:45Z

Reopening to retrigger CI

Beamanator · 2026-10-01T22:30:22Z

I guess this is off hold again, right? Ready for another round of testing? 🙏

ishpaul777 · 2026-10-01T22:40:14Z

Yes!

Beamanator · 2026-10-02T16:08:55Z

Bump @mananjadhav 🙏

mananjadhav · 2026-10-02T19:42:10Z

Reviewed the code changes again. All good.

Beamanator

LGTM

Beamanator · 2026-10-02T20:23:41Z

checklist CI checks aren't passing, can y'all help figure out why?

Matches reviewer feedback on PR Expensify#102206 to interleave each step with its code instead of one upfront comment block.

Beamanator

LGTM! Thanks!

Beamanator · 2026-10-02T20:54:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-10-02T20:56:00Z

🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-02T20:58:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-02T21:00:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102206.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7dcf9f0-9e26f17-d7b03c8ed40c5ebe1075e03773fef1f08db2c101/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7dcf9f0-9e26f17-dd7caf1340a20c89d5156e7ea72ccafccae7eb6c/index.html

Web 🕸️
https://102206.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-05T00:20:53Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.5.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-05T00:24:46Z

No help site update needed. This is a bug fix: Mark as exported with Select all now marks every matching report, not just the loaded page, which is what users already expect. No sentence in an existing article becomes incorrect.

view run

OSBotify · 2026-10-05T23:14:31Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.2-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

ishpaul777 added 2 commits September 18, 2026 17:44

Queue bulk mark-as-exported for the full matching search under select…

2594e4e

…-all

Merge remote-tracking branch 'upstream/main' into ishpaul/682672-app-…

8bbf5cf

…bulk-mark-as-exported

ishpaul777 requested review from a team as code owners September 24, 2026 15:26

melvin-bot Bot requested review from JmillsExpensify and mananjadhav and removed request for a team September 24, 2026 15:26

melvin-bot Bot assigned ishpaul777 Sep 24, 2026

Merge branch 'Expensify:main' into ishpaul/682672-app-bulk-mark-as-ex…

a9426d8

…ported

JmillsExpensify previously approved these changes Sep 25, 2026

View reviewed changes

mananjadhav reviewed Sep 28, 2026

View reviewed changes

Comment thread src/hooks/useSearchBulkActions.ts Outdated

Add tests for select-all vs limited-selection mark-as-exported

e93d5b0

ishpaul777 dismissed JmillsExpensify’s stale review via e93d5b0 September 28, 2026 16:36

mananjadhav approved these changes Sep 28, 2026

View reviewed changes

melvin-bot Bot requested a review from Beamanator September 28, 2026 17:17

Block bulk mark-as-exported offline under select-all, matching bulk pay

5cd51e9

ishpaul777 added 2 commits September 29, 2026 00:30

Send isIntuitEnterpriseSuite so Auth can scope past connectionName

91de9c9

QBO and Intuit Enterprise Suite share the same connectionName, so Auth can't yet tell them apart; it will read this once the backend fix lands.

Send qboIntegrationAlias instead of a boolean flag

372a57c

Only set for a QBO connection that is the Intuit Enterprise Suite variant, reusing the existing ACCOUNTING_INTEGRATION_ALIASES pattern instead of inventing a new boolean.

Merge branch 'Expensify:main' into ishpaul/682672-app-bulk-mark-as-ex…

191864b

…ported

mananjadhav mentioned this pull request Oct 1, 2026

[Due for payment 2026-10-12] [Bug] Mark as exported processes only the first page after Reports “Select all matching” #101106

Closed

Merge branch 'Expensify:main' into ishpaul/682672-app-bulk-mark-as-ex…

6b071ec

…ported

ishpaul777 closed this Oct 1, 2026

ishpaul777 reopened this Oct 1, 2026

ishpaul777 requested a review from mananjadhav October 1, 2026 22:40

mananjadhav approved these changes Oct 2, 2026

View reviewed changes

Beamanator previously approved these changes Oct 2, 2026

View reviewed changes

Comment thread tests/unit/hooks/useSearchBulkActionsExportTest.ts Outdated

Split Given/When/Then test comments onto separate lines

5e2c4c7

Matches reviewer feedback on PR Expensify#102206 to interleave each step with its code instead of one upfront comment block.

ishpaul777 dismissed Beamanator’s stale review via 5e2c4c7 October 2, 2026 20:42

Beamanator approved these changes Oct 2, 2026

View reviewed changes

Beamanator merged commit 7dcf9f0 into Expensify:main Oct 2, 2026
34 of 40 checks passed

OSBotify mentioned this pull request Oct 4, 2026

Deploy Checklist: New Expensify 2026-10-04 #102948

Closed

59 tasks done

Conversation

ishpaul777 commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 24, 2026

Uh oh!

codecov Bot commented Sep 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Sep 28, 2026

Uh oh!

mananjadhav commented Sep 28, 2026

Uh oh!

mananjadhav Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mananjadhav commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Sep 28, 2026

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Sep 28, 2026

Uh oh!

Beamanator commented Sep 29, 2026

Uh oh!

ishpaul777 commented Oct 1, 2026

Uh oh!

ishpaul777 commented Oct 1, 2026

Uh oh!

Beamanator commented Oct 1, 2026

Uh oh!

ishpaul777 commented Oct 1, 2026

Uh oh!

Beamanator commented Oct 2, 2026

Uh oh!

mananjadhav commented Oct 2, 2026

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Beamanator commented Oct 2, 2026

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Sep 24, 2026 •

edited

Loading

codecov Bot commented Sep 24, 2026 •

edited by github-actions Bot

Loading

mananjadhav commented Sep 28, 2026 •

edited

Loading

mananjadhav commented Sep 28, 2026 •

edited

Loading

Beamanator commented Oct 2, 2026 •

edited

Loading