`MenuItem` decomposition - html value by war-in · Pull Request #102170 · Expensify/App

war-in · 2026-09-24T13:18:21Z

Explanation of Change

Adds MenuItem.FieldValueHTML leaf (renders HTML values, optional characterLimit) and MenuItemField.Content (name/value/placeholder cell taking any value leaf). Migrates legacy shouldRenderAsHTML/shouldParseTitle/shouldParseHelperText rows to the composable API; helper text goes through FormHelpMessage; static config arrays in touched pages are inlined as JSX.

Fixed Issues

$ #100312
PROPOSAL:

Tests

HTML and markdown values

Open a workspace chat > + > Assign task. Set a title with markdown (e.g. *bold* _italic_) and a multi-line description with a link
Verify that the Title and Description rows render the formatted text (bold/italic/link), that the "Required" hint shows on the Title row only while it's empty, and that each row opens its edit page
Create the task, open a room > Details > Description, set a description longer than 100 characters with markdown, and verify that the row shows the formatted text not truncated with "..." and opens the description page
Open a chat > Details > Private notes with notes from you and another member. Verify that notes render as HTML, your note has a chevron and opens the editor, and the other member's note is shown at full opacity, has no chevron and isn't pressable
Go to Account > Agents > pick an agent, verify that the Instructions row renders the markdown prompt (truncated when long) and opens the prompt editor

Helper text

Go to Workspaces > pick a workspace with Rules enabled and approvals (Workflows) disabled > Categories > pick a category (and Tags > pick a tag, single-level tags)
Verify that the Approver row is disabled and the "enable workflows" helper text with a working link is shown below it, and that the category "Description hint" row renders its HTML value and opens its page
On a workspace connected to NetSuite, open Accounting > Export > Out-of-pocket expenses. Verify that "Export as" shows its helper text below, rows for default vendor / journal posting account / preference appear only for the matching export destination, and each row opens its selector (with a red dot when the setting has an error). Open Export > Travel billing and verify the helper text is shown under "Export as"

Inlined rows

Go to Account > Rules > New rule. Verify that the "Merchant" row under "When expense contains" shows "Required", and after tapping Save with it empty shows "This field is required" below the row
Verify that the rows under "Apply updates" (merchant, category, tags, tax, description, reimbursable, billable, add to report) render with the same order and conditions as on main, the description renders markdown, and each row opens its page
In Reports search, select multiple expenses > More > Edit multiple. Verify that all fields (amount, description, merchant, date, category, tags, tax, billable, reimbursable, attendees) render in the same order as on main, locked fields are disabled without a chevron, the description renders markdown, and each enabled row opens its editor

Offline tests

N/A - UI-only refactor, no API or Onyx changes.

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-09-24T13:52:45Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MenuItem/index.ts	`100.00% <ø> (ø)`
...MenuItem/leaves/content/MenuItemFieldValueHTML.tsx	`100.00% <100.00%> (ø)`
.../MenuItem/leaves/helpText/BaseMenuItemHelpText.tsx	`100.00% <100.00%> (ø)`
...ents/MenuItem/leaves/helpText/MenuItemHelpText.tsx	`100.00% <100.00%> (ø)`
src/components/MenuItem/presets/MenuItemField.tsx	`100.00% <100.00%> (ø)`
.../components/MenuItem/presets/MenuItemFieldHTML.tsx	`100.00% <100.00%> (ø)`
...uestConfirmationList/sections/DescriptionField.tsx	`81.08% <100.00%> (+1.08%)`	⬆️
src/pages/DynamicReportDetailsPage.tsx	`82.04% <100.00%> (+0.04%)`	⬆️
src/pages/settings/Agents/EditAgentPage.tsx	`92.00% <100.00%> (+0.21%)`	⬆️
src/pages/PrivateNotes/PrivateNotesListPage.tsx	`0.00% <0.00%> (ø)`
... and 11 more
... and 13 files with indirect coverage changes

melvin-bot · 2026-09-24T13:56:16Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2026-09-25T11:23:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-09-28.at.17.50.25.mov

war-in · 2026-09-28T09:12:57Z

@Pujan92 review addressed!

Pujan92

LGTM!

roryabraham · 2026-09-29T11:24:58Z

LGTM, but conflicts

# Conflicts: # src/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx # src/components/MoneyRequestConfirmationList/sections/ReportField.tsx # tests/ui/MoneyRequestReportFooter.tsx

github-actions · 2026-09-29T12:58:34Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-29T13:01:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-29T13:02:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102170.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e5308fa-be6570d-69d9739ea7440c9ce99ec4ed3abc3c2dba3bfb31/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e5308fa-be6570d-b22fd04a6001024d264931615d88f8a4df407697/index.html

Web 🕸️
https://102170.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-30T01:08:51Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.96-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-09-30T01:13:04Z

No help site update is needed. This PR refactors MenuItem rows to a composable API without changing any user-facing labels, settings, or workflows, so no help article sentence becomes incorrect.

view run

m-natarajan · 2026-09-30T02:43:46Z

@war-in @Pujan92
HTML and markdown values:
Step: 4 Private notes flow is outdated, Will validate the rest. Can you please confirm the same?

jponikarchuk · 2026-09-30T05:21:40Z

Deploy Blocker #102618 was identified to be related to this PR.

war-in · 2026-09-30T09:23:23Z

Step: 4 Private notes flow is outdated, Will validate the rest. Can you please confirm the same?

@m-natarajan oh right, I verified it locally while implementing, so let's skip it as not reachable on prod. Do you know if this flow is going to be back? 🤔

OSBotify · 2026-09-30T14:46:35Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-30T14:59:14Z

No help site update is needed. This PR refactors how menu rows render HTML values and helper text. It doesn't add, rename, remove, or change any user-facing feature, label, or workflow, so no existing article is now wrong.

view run

OSBotify · 2026-09-30T23:43:31Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

war-in added 4 commits September 24, 2026 15:10

feat: add MenuItemFieldValueHTML

2520243

refactor: migrate applicable callsites to MenuItemFieldValueHTML

b95fed6

test: remove unnecessary mocks

6a56cef

refactor: migrate PrivateNotesListPage MenuItem to the composable API

7c6fd20

melvin-bot Bot assigned war-in Sep 24, 2026

war-in added 2 commits September 24, 2026 15:34

fix: wrap help message with <comment> so it renders tooltips

0e210c6

test: fix outdated test

dcfd890

war-in marked this pull request as ready for review September 24, 2026 13:56

war-in requested review from a team as code owners September 24, 2026 13:56

melvin-bot Bot requested review from Pujan92 and dylanexpensify and removed request for a team and dylanexpensify September 24, 2026 13:56

github-actions Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread src/pages/workspace/categories/CategorySettingsPage.tsx Resolved

github-actions Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread src/pages/workspace/tags/DynamicTagSettingsPage.tsx Resolved

github-actions Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/netsuite/export/DynamicNetSuiteExportExpensesPage.tsx Resolved

github-actions Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/netsuite/export/NetSuiteTravelBillingConfigurationPage.tsx Resolved

fix: add MenuItemHelpTextHTML.tsx

9bcd753

MelvinBot mentioned this pull request Sep 25, 2026

MenuItem — composition over configuration #96202

Open

Pujan92 reviewed Sep 25, 2026

View reviewed changes

war-in added 3 commits September 28, 2026 10:54

Merge branch 'main' into war-in/menuitem-decomposition-htm-value

3b35885

fix: move helpText outside trailing

a1f5bf8

refactor: add MenuItemFieldHTML.tsx

5f9728b

Pujan92 approved these changes Sep 28, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham September 28, 2026 12:22

roryabraham previously approved these changes Sep 29, 2026

View reviewed changes

war-in added 2 commits September 29, 2026 13:31

Merge branch 'main' into war-in/menuitem-decomposition-htm-value

30b1ac7

# Conflicts: # src/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx # src/components/MoneyRequestConfirmationList/sections/ReportField.tsx # tests/ui/MoneyRequestReportFooter.tsx

chore: post-merge fixes

822106a

war-in dismissed roryabraham’s stale review via 822106a September 29, 2026 11:40

roryabraham approved these changes Sep 29, 2026

View reviewed changes

roryabraham merged commit e5308fa into Expensify:main Sep 29, 2026
35 of 36 checks passed

OSBotify mentioned this pull request Sep 30, 2026

Deploy Checklist: New Expensify 2026-09-30 #102590

Closed

66 tasks done

MelvinBot mentioned this pull request Sep 30, 2026

[$175] Split-When splitting second expense in group, Amount field gets overlapped #102615

Closed

1 of 7 tasks

applause-bot Bot mentioned this pull request Sep 30, 2026

Task - Description with morethan 100 characters is not truncated. #102618

Closed

2 of 7 tasks

jponikarchuk mentioned this pull request Sep 30, 2026

[$175] MenuItem decomposition Phase 3 — MenuItemWithTopDescription replacement preset #100312

Open

Conversation

war-in commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Sep 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pujan92 commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

war-in commented Sep 28, 2026

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Sep 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

OSBotify commented Sep 29, 2026

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

OSBotify commented Sep 30, 2026

Uh oh!

MelvinBot commented Sep 30, 2026

Uh oh!

m-natarajan commented Sep 30, 2026

Uh oh!

jponikarchuk commented Sep 30, 2026

Uh oh!

war-in commented Sep 30, 2026

Uh oh!

OSBotify commented Sep 30, 2026

Uh oh!

MelvinBot commented Sep 30, 2026

Uh oh!

OSBotify commented Sep 30, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

war-in commented Sep 24, 2026 •

edited

Loading

codecov Bot commented Sep 24, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented Sep 25, 2026 •

edited

Loading