Repository navigation
[Insights] fix: Confirm page is not cleared when reopened from Create expense button on Insights - #102141
Conversation
… expense button on Insights
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@truph01 please prioritize this review when you're online! |
|
I am on it now |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariScreen.Recording.2026-09-25.at.00.55.20.movMacOS: Chrome / SafariScreen.Recording.2026-09-25.at.00.51.51.mov |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.94-0 🚀
|
|
No help site changes are required for this PR. This PR fixes a bug. The Create expense button on the empty Insights page now passes the existing draft transaction IDs to What I checked
I did not create a docs PR because no changes are needed. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Passes
draftTransactionIDstostartMoneyRequestinstead of undefined, to make the clearing of draft transaction work correctly.Fixed Issues
$ #102066
PROPOSAL: N/A
Tests
insightsPagebeta.Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-24.o.11.33.54.mov