Repository navigation
Show scroll bars on workspace table pages - #102064
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🚧 dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@dannymcclain @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Tests really well for me 👍 |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-10-07.at.2.06.16.PM.mov |
PR ReviewThe approach looks good overall: you measure the scrollbar, shrink the dynamic column widths, and pad the stuck header. I found one bug and two things to confirm. 1. Page header is clipped when columns overflow (bug)
To reproduce: set scroll bars to Always and open a page-header table such as Members. Narrow the window until the columns scroll horizontally, then check the right edge of the filter bar. Fix: pass 2. Native now shows scroll indicators (please confirm)Removing 3. PR description
Checked and fine
|
|
You're right: the padding was intentional and should be restored.
Fix: revert the change in Correction to my earlier reviewI said the padding "does look unused" because this page's |
It's not actually clipped (thanks to padding) but padding is reduced. Screen.Recording.2026-10-07.at.2.30.16.PM.mov |
|
Above are no blockers |
JS00001
left a comment
There was a problem hiding this comment.
This feels really great, every day our tables get better and better!
|
@Krishna2323 lets go ahead and fix Situ's comments above before merging |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.5-0 🚀
|
|
No help site update is needed. This PR only shows the OS scroll bar on existing lists and tables, and no article under |
|
Deploy Blocker #103427 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.5-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #101361
PROPOSAL:
Tests
Setup
(On a Mac set to "When scrolling", the bars fade in and out instead. That's also correct, but the alignment checks below won't show anything.)
Workspace tables — the new bar
Workspace tables — sticky header alignment
Side panes
Empty and filtered states
Narrow layout and mobile
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-09-24.07-59-04.mp4