Skip to content

Show scroll bars on workspace table pages - #102064

Merged
JS00001 merged 8 commits into
Expensify:mainfrom
Krishna2323:fix/101361-table-scroll-bars
Oct 7, 2026
Merged

JS00001 merged 8 commits into
Expensify:mainfrom
Krishna2323:fix/101361-table-scroll-bars

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #101361
PROPOSAL:

Tests

Setup

  1. On macOS, open System Settings → Appearance → Show scroll bars → Always. On Windows/Linux, this is already the default.
  2. Verify the setting by opening any long page and confirming a scroll bar is visible without scrolling.

(On a Mac set to "When scrolling", the bars fade in and out instead. That's also correct, but the alignment checks below won't show anything.)

Workspace tables — the new bar

  1. Open Settings → Workspaces → [any workspace] → Members on a wide screen, with enough members to scroll.
  2. Verify a vertical scroll bar is visible on the right.
  3. Verify the bar runs the full height of the page, not just the rows below the column header.
  4. Scroll to the bottom and back to the top. Verify the bar moves with the content and no columns shift sideways.
  5. Repeat steps 1–4 on Categories, Tags, Taxes, and Expensify Cards.

Workspace tables — sticky header alignment

  1. Open Members with enough members to scroll.
  2. Scroll down until the column header sticks to the top.
  3. Verify the right edge of the sticky header lines up with the right edge of the rows below it.
  4. Verify the last column's text isn't cut off at the right edge.
  5. Scroll back to the top and verify the header returns to its normal position, still aligned with the rows.
  6. Repeat on Expensify Cards and Company Cards. These three tables size their columns based on content, so they exercise different code.

Side panes

  1. Open Inbox on a wide screen with enough chats for the left list to scroll.
  2. Verify a scroll bar is visible on the left list.
  3. Scroll to the bottom and back. Verify the content doesn't jump sideways as the bar appears or disappears.
  4. Repeat for Account Settings, the Search sidebar (saved searches), a workspace's settings menu, and the main chat window.

Empty and filtered states

  1. Open Settings → Workspaces → [any workspace] → Categories.
  2. Search until no rows match.
  3. Verify the empty state is centered with no stray gap on the right.
  4. Clear the search.
  5. Verify the rows return and the column header is aligned with them.

Narrow layout and mobile

  1. Resize the browser until the table switches to the narrow card layout.
  2. Verify the rows render as cards and look the same as production.
  3. Repeat on iOS and Android.
  4. Verify the scroll indicator floats above the content and nothing is clipped, same as production.
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_hybrid.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-09-24.07-59-04.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 changed the title Fix/101361 table scroll bars Show scroll bars on workspace table pages Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/LHNOptionsList/LHNOptionsList.tsx 78.68% <ø> (ø)
src/components/Table/Table.tsx 91.72% <100.00%> (+0.11%) ⬆️
...rc/hooks/useVerticalScrollbarWidth/index.native.ts 100.00% <100.00%> (ø)
src/pages/Search/SearchTypeMenuWide.tsx 0.00% <ø> (ø)
src/pages/settings/InitialSettingsPage.tsx 97.95% <ø> (ø)
src/pages/workspace/WorkspaceInitialPage.tsx 85.56% <100.00%> (ø)
src/components/Table/TableBody.tsx 94.64% <80.00%> (-0.48%) ⬇️
src/components/Table/TableContext.tsx 63.63% <0.00%> (-6.37%) ⬇️
src/hooks/useVerticalScrollbarWidth/index.ts 0.00% <0.00%> (ø)
... and 619 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚧 dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@Krishna2323
Krishna2323 marked this pull request as ready for review September 24, 2026 13:02
@Krishna2323
Krishna2323 requested review from a team as code owners September 24, 2026 13:02
@melvin-bot
melvin-bot Bot requested review from dannymcclain, situchan and trjExpensify and removed request for a team September 24, 2026 13:02
@melvin-bot

melvin-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

@dannymcclain @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 24, 2026 13:02
Comment thread src/components/Table/TableBody.tsx Outdated
trjExpensify
trjExpensify previously approved these changes Sep 24, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Tests really well for me 👍

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@situchan

situchan commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-07.at.2.06.16.PM.mov

Comment thread src/pages/workspace/WorkspaceInitialPage.tsx
@MelvinBot

Copy link
Copy Markdown
Contributor

PR Review

The approach looks good overall: you measure the scrollbar, shrink the dynamic column widths, and pad the stuck header. I found one bug and two things to confirm.

1. Page header is clipped when columns overflow (bug)

Table.tsx:521 still puts the outer tableWidth in context. TableBody.tsx:299 uses that value to size the sticky page header in column-scroll mode. That header sits inside the scroller, whose visible width is now tableWidth - scrollbarWidth. As a result, the right ~15px of the page header (search, buttons) gets cut off behind the vertical bar.

To reproduce: set scroll bars to Always and open a page-header table such as Members. Narrow the window until the columns scroll horizontally, then check the right edge of the filter bar.

Fix: pass tableWidth: contentWidth in the context value. TableBody is its only consumer, so nothing else changes.

2. Native now shows scroll indicators (please confirm)

Removing showsVerticalScrollIndicator={false} turns indicators on for iOS and Android as well. This affects the LHN (LHNOptionsList.tsx:163), Account Settings (InitialSettingsPage.tsx:176), and the narrow table list. That may be intended, but the "Narrow layout and mobile" test says "same as production", which isn't accurate for these screens. Please confirm with design, or keep the prop false on native only.

3. PR description

Explanation of Change and PROPOSAL are empty. Please fill them in, including why the pb14 removal in WorkspaceInitialPage is safe. I checked: the bottom tab bar renders in normal flow with shouldShowFloatingButtons={false}, so the padding does look unused.

Checked and fine
  • Callback ref churn: the inline ref and measureScrollbarRef aren't manually memoized. React Compiler Compliance passes for these files, so the compiler keeps them stable and the ResizeObserver isn't rebuilt on every render.
  • Empty state: unmounting FlashList calls measureScrollbarRef(null), which resets the width to 0. The empty ScrollView isn't measured, so it doesn't need the inset.
  • Non-sticky column header: it renders inside the scroller, so it's already aligned. Only the FlashList StickyHeader target needs the padding, and that's the only place it's applied.
  • CI: all checks pass except the reviewer checklist and independent-approval checks.

view run

@MelvinBot

Copy link
Copy Markdown
Contributor

You're right: the padding was intentional and should be restored.

pb14 (56px) was added in Add primary receipt scan option on mobile and web - v2 by commit d120ea7 ("add 56px bottom padding to the WorkspaceInitialPage"). It fixed [$50] mWeb - Scan - Scan button overlaps with "Go to workspace" chevron in workspace page. The floating Scan button covered the right side of the last item in the workspace menu. That's the same overlap your "after" video shows on More features.

Fix: revert the change in WorkspaceInitialPage.tsx:257 back to [styles.flexColumn, styles.pb14].

Correction to my earlier review

I said the padding "does look unused" because this page's bottomContent renders NavigationTabBar with shouldShowFloatingButtons={false}. That copy is only the swipe-back duplicate. The real tab bar still renders FloatingCameraButton and FloatingGPSButton over the page on narrow layouts (NavigationTabBar/index.tsx:201-208). So the padding is still needed.


view run

@situchan

situchan commented Oct 7, 2026

Copy link
Copy Markdown
Contributor
  1. Page header is clipped when columns overflow

It's not actually clipped (thanks to padding) but padding is reduced.
Only reproducible in Expensify Card page for now.

Screen.Recording.2026-10-07.at.2.30.16.PM.mov

@situchan

situchan commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Above are no blockers

@melvin-bot
melvin-bot Bot requested a review from JS00001 October 7, 2026 13:38
JS00001
JS00001 previously approved these changes Oct 7, 2026

@JS00001 JS00001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels really great, every day our tables get better and better!

@JS00001

JS00001 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

@Krishna2323 lets go ahead and fix Situ's comments above before merging

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@JS00001
JS00001 merged commit 857a0bd into Expensify:main Oct 7, 2026
36 of 38 checks passed
@melvin-bot
melvin-bot Bot requested a review from JS00001 October 7, 2026 18:07
@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Oct 7, 2026
68 tasks done
@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR only shows the OS scroll bar on existing lists and tables, and no article under docs/articles mentions scroll bars or says they're hidden.


view run

@unzig21

unzig21 commented Oct 8, 2026

Copy link
Copy Markdown

Deploy Blocker #103427 was identified to be related to this PR.

@OSBotify

OSBotify commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.5-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants