Repository navigation
Conversation
Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
40 tasks done
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Feel free to reopen if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to Drop the Vendor column from the Spend table when no workspace has the vendor feature.
That PR made the Vendor column in Spend depend on at least one workspace having vendor matching active, everywhere the column is read: the Spend table, the expense table on a report, Display > Edit columns, the sort options, grouped views, and the Current view CSV export. Before it, a saved column list kept rendering an empty Vendor column after the accounting connection went away.
The help site never documented the Vendor column at all, so members had no way to know it exists or why it disappears. This PR documents both.
Changes:
docs/articles/new-expensify/reports-and-expenses/Using-Reports-in-New-Expensify.md— adds Vendor to the list of columns you can pick under Display > Edit columns, plus a note that it is offered only while a workspace has vendor matching active and that other saved columns are unaffected when it goes away.docs/articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online.md— adds how to show the Vendor column in Spend and what happens to it when QuickBooks Online vendor matching stops.docs/articles/new-expensify/connections/sage-intacct/Manage-Vendor-Matching-for-Sage-Intacct.md— same two sections for Sage Intacct.Only the QuickBooks Online and Sage Intacct paths are documented, because the Xero, Rillet, and Business Central paths are still behind the vendor matching beta.
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. UI labels (Spend, Display, Edit columns, Vendor, Current view, Export company card expenses as) were verified againstsrc/languages/en.tsrather than a live browser, since browser verification was unavailable in this run.Fixed Issues
$ #101859
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — help site content only, no App code changes.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.