[NOQA] fix: start telemetry spans with no parent by OlimpiaZurek · Pull Request #101877 · Expensify/App

OlimpiaZurek · 2026-09-22T13:40:48Z

Explanation of Change

startSpan in src/libs/telemetry/activeSpans.ts creates every Manual* span. When the caller gives no parent, Sentry attaches the new span to whatever span is active on the scope. startSpan now passes forceTransaction: true in that case, so the span starts as its own transaction. It still carries the trace ID and parent span ID, so Sentry keeps it on the same trace.

A span started with a parent stays under it, so the send-message phase spans still nest under the visible span.
An explicit forceTransaction always wins. OnyxDerived sets it to false because its recomputes are short, use onlyIfParent, and should join the open transaction instead of each sending one of their own.

Root cause

Since the Sentry SDK upgrade in #100711, a tap leaves a ui.action.touch idle span on the scope, and our spans became its children. That idle span ends about a second after the last activity under it, and @sentry/core then force-ends any child still running:

// @sentry/core idleSpan.js
childSpan.setStatus({code: SPAN_STATUS_ERROR, message: "cancelled"});
childSpan.end(endTimestamp);

The span is cut short and marked span.status:cancelled. Dashboards filter span.status:ok, so the capture never reaches a chart at all.

Why `ManualShutterToConfirmation` is hit hardest

It is tap-triggered, so an idle span is on the scope when it opens. It stays open across capture, navigation and mount, so it is almost always still running when that idle span closes, and it loses 84% against 54% for ManualConfirmationMount. It is also mobile-only, so nothing dilutes the loss: ManualOpenReport loses 67% on mobile too, but desktop dominates its board figure and it barely moved.

The board number went up rather than down because iOS lost 77% of captures against Android's 20%, leaving a pool that went from 44% to 52% Android while Android runs about 2.5x iOS here. On a build from before the upgrade, iOS p75 went 166 to 165 and Android p75 went 315 to 313 week over week.

Fixed Issues

$ #102071
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-09-23T10:35:32Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2026-09-23T10:37:17Z

Can review if a C+ review is required.

trjExpensify · 2026-09-24T00:03:12Z

PR doesn’t need product input as a performance tooling PR. Unassigning and unsubscribing myself.

Krishna2323

The description still says parentSpan: null, but the code uses forceTransaction, which keeps the trace link. Please update it and fill in the Tests and QA sections.

Krishna2323 · 2026-09-24T18:26:23Z

    startTimeForLog: number;
 };

+type TrackedSpanOptions = StartSpanOptions & {inheritScope?: boolean};


NAB: Can we drop inheritScope and have OnyxDerived pass forceTransaction: false? The ?? already respects it, and the other five callers set forceTransaction directly.

Krishna2323 · 2026-09-24T18:26:50Z

                    parentSpan,
                    // A span with no parent is sent as its own transaction, one per recompute.
                    onlyIfParent: true,
+                    inheritScope: true,


NAB: forceTransaction: false here does the same thing through Sentry's own option. That lets us delete TrackedSpanOptions and the destructuring in startSpan.

Krishna2323 · 2026-09-24T18:27:23Z


+import type {StartSpanOptions} from '@sentry/core';
+
+const mockStartInactiveSpan = jest.fn((options: StartSpanOptions) => ({


NAB: Could this match the typed mock in ActiveSpansBenchmarkTest.ts:17 (jest.fn<MockInactiveSpan, [StartSpanOptions]>)? The options field on the fake span also looks unused.

Krishna2323 · 2026-09-24T18:28:18Z

+
+        it('lets a caller opt back into the span on the scope', () => {
+            // Given a caller that asks to inherit, as the Onyx derived recomputes do because they are short and want whatever transaction is open
+            const options = {name: 'InheritingSpan', inheritScope: true};


NAB: This never runs OnyxDerived, so removing its opt-out wouldn't fail anything. Could we assert forceTransaction is false next to onlyIfParent in onyxDerivedComputeSpanTest.ts:93?

OlimpiaZurek · 2026-09-25T10:57:13Z

The description still says parentSpan: null, but the code uses forceTransaction, which keeps the trace link. Please update it and fill in the Tests and QA sections.

Applied all suggestions and updated the PR description.
PR is marked as NOQA, so there's no need to fill in the Tests and QA sections.

Krishna2323 · 2026-09-25T17:29:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Krishna2323

LGTM!

Krishna2323 · 2026-09-30T12:03:47Z

@Julesssss friendly bump

Julesssss · 2026-10-02T00:33:34Z

Sorry, been delayed by app deploy this week 😩

github-actions · 2026-10-02T00:33:47Z

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-02T00:36:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-02T00:38:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #101877.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4b994e6-33d70ef-0fe98f201cb516014ec446bef72a697fd8d2c10d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4b994e6-33d70ef-c0edaaef58fc08dabd1415aa9fc358b37b4b5690/index.html

Web 🕸️
https://101877.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-05T00:20:41Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-05T00:24:31Z

No help site update is needed. This PR only changes how internal Sentry telemetry spans start, so nothing in the app looks or works differently for users.

view run

OSBotify · 2026-10-05T23:14:19Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.2-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

fix: start telemetry spans with no parent

b205b26

melvin-bot Bot assigned OlimpiaZurek Sep 22, 2026

fix: keep telemetry spans out of the scope's transaction

399af78

OlimpiaZurek marked this pull request as ready for review September 23, 2026 10:35

OlimpiaZurek requested review from a team as code owners September 23, 2026 10:35

melvin-bot Bot requested a review from Krishna2323 September 23, 2026 10:35

melvin-bot Bot requested review from trjExpensify and removed request for a team September 23, 2026 10:35

OlimpiaZurek mentioned this pull request Sep 23, 2026

[Metrics] ManualShutterToConfirmation - Optimize "Confirm details" page rendering after receipt capture #83503

Open

cristipaval mentioned this pull request Sep 23, 2026

[Due for payment 2026-10-12] [Metrics] Prevent manual telemetry spans from being cancelled after the Sentry SDK upgrade #102071

Closed

trjExpensify removed their request for review September 24, 2026 00:03

Krishna2323 reviewed Sep 24, 2026

View reviewed changes

replace inheritScope with forceTransaction

c7530a6

Krishna2323 approved these changes Sep 27, 2026

View reviewed changes

melvin-bot Bot requested review from Julesssss and cristipaval September 27, 2026 22:02

cristipaval approved these changes Sep 28, 2026

View reviewed changes

Julesssss approved these changes Oct 2, 2026

View reviewed changes

Julesssss merged commit 4b994e6 into Expensify:main Oct 2, 2026
37 of 39 checks passed

OSBotify mentioned this pull request Oct 4, 2026

Deploy Checklist: New Expensify 2026-10-04 #102948

Closed

59 tasks done

sumo-slonik mentioned this pull request Oct 14, 2026

Search Router open: restore option cache hits, skip empty-query navigation work, profile on native #103982

Draft

6 of 38 tasks


		import type {StartSpanOptions} from '@sentry/core';

		const mockStartInactiveSpan = jest.fn((options: StartSpanOptions) => ({

Conversation

OlimpiaZurek commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Root cause

Why ManualShutterToConfirmation is hit hardest

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 23, 2026

Uh oh!

Krishna2323 commented Sep 23, 2026

Uh oh!

trjExpensify commented Sep 24, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

OlimpiaZurek commented Sep 25, 2026

Uh oh!

Krishna2323 commented Sep 25, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Sep 30, 2026

Uh oh!

Uh oh!

Julesssss commented Oct 2, 2026

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

OSBotify commented Oct 2, 2026

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

OSBotify commented Oct 5, 2026

Uh oh!

MelvinBot commented Oct 5, 2026

Uh oh!

OSBotify commented Oct 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

OlimpiaZurek commented Sep 22, 2026 •

edited

Loading

Why `ManualShutterToConfirmation` is hit hardest