Skip to content

[no QA] Docs updates for E/A#101385 Cancelled reservations excluded from Upcoming travel - #101487

Open
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-upcoming-travel-home
Open

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-upcoming-travel-home

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for [Bug] Hide cancelled reservations from Upcoming (Expensify/App#101385), which stopped canceled travel reservations from appearing in the Upcoming travel section on Home.

The Home help article already documented the Upcoming travel section, but it stated the opposite of the new behavior:

Canceled reservations stay in the list and are labeled Canceled.

That sentence is now wrong, so this updates the docs to match:

docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md

  • Corrected the Upcoming travel section: canceled reservations are excluded from Home, and the canceled reservation still appears inside the trip with the Canceled label.
  • Updated the Why don't I see the Upcoming travel section? FAQ so canceled reservations don't count toward the 7-day window. A member whose only reservation in that window is canceled now sees no section at all, which is a new way for the section to be hidden and the most likely reason someone searches for help.
  • Added a Why did my canceled booking disappear from the Upcoming travel section? FAQ, since "my trip vanished from Home" reads like a bug rather than intended behavior.
  • Added canceled-reservation search terms to keywords.

docs/articles/travel/managing-trips/Canceling-Travel-Arrangements.md

  • Added a Where does a canceled booking go on Home? FAQ. Members hit this question right after canceling, so the answer belongs in the cancel article too, not only in the Home article.

Authoring compliance: only ## headings, each starting with a question word; UI labels bolded and matched exactly against src/languages/en.ts (Upcoming travel, Canceled, Flight to …, Hotel in …, Car rental in …, Train to …, Today, In 1 day, In 1 week); relative cross-links only; no new screenshots, since the change is behavioral rather than a new control to locate. npm run spell-changed reports 0 issues.

Fixed Issues

$ #101054
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — help site markdown only, no app UI changes.

Android: mWeb Chrome

N/A — help site markdown only, no app UI changes.

iOS: Native

N/A — help site markdown only, no app UI changes.

iOS: mWeb Safari

N/A — help site markdown only, no app UI changes.

MacOS: Chrome / Safari

N/A — help site markdown only, no app UI changes.


@rlinoz, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 17, 2026 22:39
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 17, 2026
@rlinoz
rlinoz marked this pull request as ready for review September 18, 2026 11:47
@melvin-bot

melvin-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

@melvin-bot
melvin-bot Bot requested review from bfitzexpensify and removed request for a team September 18, 2026 11:47
@melvin-bot

melvin-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-18T12:00:41.556373Z e3f7651 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

## Why don’t I see the Upcoming travel section?

The **Upcoming travel** section only appears when you have at least one reservation starting in the next 7 days on a trip where you are listed as a traveler. If you have no reservation in that window, or the only upcoming trips are ones you booked for someone else, the section won’t be visible.
The **Upcoming travel** section only appears when you have at least one reservation starting in the next 7 days on a trip where you are listed as a traveler. Canceled reservations don’t count toward this. If you have no reservation in that window, the only reservations in that window are canceled, or the only upcoming trips are ones you booked for someone else, the section won’t be visible.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability: This sentence packs three parallel "if" conditions into one comma-separated run-on ("If you have no reservation in that window, the only reservations in that window are canceled, or the only upcoming trips are ones you booked for someone else..."), which is hard to scan. Per HELP_AUTHORING_GUIDELINES.md (concise, scannable, clear), consider breaking the conditions into a short bulleted list, e.g. "The section won't be visible if: you have no reservation in the next 7 days; the only reservations in that window are canceled; or the only upcoming trips are ones you booked for someone else."

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR is a small, well-scoped documentation follow-up to a behavior change (canceled reservations are now excluded from the Upcoming travel section on Home). It corrects a now-inaccurate sentence, refines an existing FAQ, adds two new FAQ entries, and expands keywords. Both changed files stay within their single workflow and reflect the new behavior accurately.

Scores Summary

  • Readability: 9/10 - New sentences are clear, scannable, and benefit-focused. The em-dash phrasing in the canceled booking sentence reads well but a comma or period would be marginally cleaner.
  • AI Readiness: 9/10 - New FAQ headings are full question-form, feature-specific, and match real search intent. Keywords were expanded with realistic canceled-reservation search phrases. internalScope and metadata are already present and appropriately unchanged.
  • Style Compliance: 10/10 - UI labels Upcoming travel and Canceled are bolded and match src/languages/en.ts exactly. Cross-links are relative with descriptive anchor text. Heading rules followed (only ## headings, question-word starts, FAQ exempt).

Key Findings

  • Accurate correction: the previously reversed sentence about canceled reservations is now consistent with the shipped behavior in PR [Bug] Hide cancelled reservations from Upcoming #101385.
  • Strong bidirectional cross-linking between the Home overview and the Canceling Travel Arrangements article, each using descriptive relative anchors, exactly per Cross-Linking Standards.
  • The new FAQ preempting a looks-like-a-bug concern is good AI-retrieval and support-deflection design.
  • No screenshots added, correctly justified since the change is behavioral rather than a new control to locate.

Recommendations

  • Optional polish: replace the em-dash in the canceled booking sentence with a period or comma for slightly cleaner prose. Non-blocking.
  • No required changes. Changes are compliant with all three governance documents.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md - Compliant. Corrected Upcoming travel behavior, refined and added FAQs, expanded keywords.
  • docs/articles/travel/managing-trips/Canceling-Travel-Arrangements.md - Compliant. Added a focused FAQ with correct UI labels and a relative cross-link.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#101385 Cancelled reservations excluded from Upcoming travel [no QA] Docs updates for E/A#101385 Cancelled reservations excluded from Upcoming travel Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants