Conversation
Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| ## Why don’t I see the Upcoming travel section? | ||
|
|
||
| The **Upcoming travel** section only appears when you have at least one reservation starting in the next 7 days on a trip where you are listed as a traveler. If you have no reservation in that window, or the only upcoming trips are ones you booked for someone else, the section won’t be visible. | ||
| The **Upcoming travel** section only appears when you have at least one reservation starting in the next 7 days on a trip where you are listed as a traveler. Canceled reservations don’t count toward this. If you have no reservation in that window, the only reservations in that window are canceled, or the only upcoming trips are ones you booked for someone else, the section won’t be visible. |
There was a problem hiding this comment.
Readability: This sentence packs three parallel "if" conditions into one comma-separated run-on ("If you have no reservation in that window, the only reservations in that window are canceled, or the only upcoming trips are ones you booked for someone else..."), which is hard to scan. Per HELP_AUTHORING_GUIDELINES.md (concise, scannable, clear), consider breaking the conditions into a short bulleted list, e.g. "The section won't be visible if: you have no reservation in the next 7 days; the only reservations in that window are canceled; or the only upcoming trips are ones you booked for someone else."
HelpDot Documentation ReviewOverall AssessmentThis PR is a small, well-scoped documentation follow-up to a behavior change (canceled reservations are now excluded from the Upcoming travel section on Home). It corrects a now-inaccurate sentence, refines an existing FAQ, adds two new FAQ entries, and expands keywords. Both changed files stay within their single workflow and reflect the new behavior accurately. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
Explanation of Change
Help site follow-up for [Bug] Hide cancelled reservations from Upcoming (
Expensify/App#101385), which stopped canceled travel reservations from appearing in the Upcoming travel section on Home.The Home help article already documented the Upcoming travel section, but it stated the opposite of the new behavior:
That sentence is now wrong, so this updates the docs to match:
docs/articles/new-expensify/getting-started/Expensify-Home-Overview.mdkeywords.docs/articles/travel/managing-trips/Canceling-Travel-Arrangements.mdAuthoring compliance: only
##headings, each starting with a question word; UI labels bolded and matched exactly againstsrc/languages/en.ts(Upcoming travel,Canceled,Flight to …,Hotel in …,Car rental in …,Train to …,Today,In 1 day,In 1 week); relative cross-links only; no new screenshots, since the change is behavioral rather than a new control to locate.npm run spell-changedreports 0 issues.Fixed Issues
$ #101054
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — help site markdown only, no app UI changes.
Android: mWeb Chrome
N/A — help site markdown only, no app UI changes.
iOS: Native
N/A — help site markdown only, no app UI changes.
iOS: mWeb Safari
N/A — help site markdown only, no app UI changes.
MacOS: Chrome / Safari
N/A — help site markdown only, no app UI changes.
@rlinoz, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.