[CP Both] Release DualEntry vendor matching from the beta - #101459
Conversation
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cedc7f5871
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
cedc7f5 to
88c9543
Compare
This comment has been minimized.
This comment has been minimized.
88c9543 to
647281b
Compare
Beamanator
changed the title
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…g-beta-from-dualentry [CP Both] Release DualEntry vendor matching from the beta (cherry picked from commit 8388853) (cherry-picked to staging by Beamanator)
…g-beta-from-dualentry [CP Both] Release DualEntry vendor matching from the beta (cherry picked from commit 8388853) (cherry-picked to production by Beamanator)
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.84-4 🚀
|
…59-35370059055-1 🍒 Cherry pick PR #101459 to production 🍒
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.84-4 🚀
|
|
🤖 Yes, help site changes are required. Draft PR: Docs updates for E/A#101459 DualEntry vendor matching now generally available This PR made DualEntry vendor matching generally available — What the docs PR does:
What it deliberately does not change: the Xero and Rillet articles. Both integrations still require the UI labels verified and howConfirmed against the merged source and, where reachable, the live web app:
A live-UI pass confirmed the More features and Accounting row labels and the Organize section heading. The Vendors row and the Vendor field could not be exercised end to end, because the test account has no DualEntry connection — those labels come from the merged code. Checks run on the docs branch: @Beamanator, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🤖 Already done — no second PR created. The draft help site PR from the earlier request is still open and current: [No QA] Docs updates for E/A#101459 DualEntry vendor matching now generally available Confirmed changes were required. This PR made DualEntry vendor matching generally available — What the docs PR does:
Current state: draft ✅, Checks and UI label verificationCI on the docs PR: UI labels used in the article, taken from the merged source and confirmed against the live web app where reachable:
A live-UI pass confirmed the More features and Accounting row labels and the Organize section heading. The Vendors row and the Vendor field could not be exercised end to end, because the test account has no DualEntry connection — those labels come from the merged code. @Beamanator, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.85-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.86-0 🚀
|
…roduction-101459-35370059055-1 Revert "🍒 Cherry pick PR #101459 to production 🍒"
|
🤖 Still done — no new PR created. The draft help site PR from the earlier request is open and current: [No QA] Docs updates for E/A#101459 DualEntry vendor matching now generally available Since my last reply, the ExpensifyHelp preview deployed. You can read the new article before approving:
Current state: draft ✅, Nothing else in this PR needs docs. Xero and Rillet still require the @Beamanator, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.89-0 🚀
|
|
🤖 No new PR — the help site work for this PR is already done and passing CI. Draft help site PR: [No QA] Docs updates for E/A#101459 DualEntry vendor matching now generally available — draft, New since my last comment: CI has finished on the docs PR. Everything passes, including Recap of what it changes, so you don't have to scroll back:
@Beamanator, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.90-0 🚀
|
|
🤖 Nothing new to do — the help site work is done, and here is the rendered preview. Draft help site PR: [No QA] Docs updates for E/A#101459 DualEntry vendor matching now generally available — draft, The one thing I hadn't surfaced yet: OSBotify deployed a live preview, so you can read the new article as it will publish rather than reviewing raw markdown.
I'll stop re-reporting this on repeat triggers. If you want something changed in the article, reply with what to change and I'll push it to the docs PR. @Beamanator, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
5 participants
🤖 Posted by Codex, an AI coding agent acting for @Beamanator.
Explanation of Change
Makes configured DualEntry workspaces eligible for vendor matching without the
vendorMatchingbeta. The shared beta remains required for Xero and Rillet.The Vendors More Features row now treats DualEntry as generally available, and the product-marketing CTA hydrates a fallback workspace's accounting connection even when the beta is disabled so it can route a configured DualEntry workspace to Vendors.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/682769
PROPOSAL: N/A
Tests
vendorMatchingbeta and connect/configure DualEntry.Offline tests
N/A
QA Steps
Same as tests. Tag me / @heyjennahay to test
PR Author Checklist
N/A
Screenshots/Videos
Not applicable — this changes feature eligibility and navigation only; it does not change the UI layout.