[No QA] Fix import/no-cycle - part 12 by LukasMod · Pull Request #101419 · Expensify/App

LukasMod · 2026-09-17T12:25:50Z

Explanation of Change

Task.ts, IOU/Hold.ts, and Session/index.ts each import the Report actions hub (src/libs/actions/Report/index.ts) or actions/Link to reach one helper that has nothing else to do with those files. This PR moves each helper into a leaf module and points the caller at it, so no caller needs the hub for it anymore.

Changes

`Report/reportActionSubscribers.ts`

New leaf holding notifyNewAction and subscribeToNewActionEvent. The registry is a module-scope array that imports only the ReportAction type.
Every caller imports the leaf directly:
- useReportActionsNewActionLiveTail and MoneyRequestReportActionsList for subscribing.
- Task.ts, IOU/Hold.ts, Chronos.ts, and seven IOU payment flows (PayMoneyRequest, PerDiem, RejectMoneyRequest, SendInvoice, SendMoney, Split, TrackExpense) for notifying.
Report/index.ts keeps its own import for addActions, createNewReport, and showReportActionNotification, and no longer re-exports either name.
24 test files stubbed notifyNewAction on the hub. 22 of those mocks existed only for that stub and are removed. The four suites that assert on it (RequestMoneyTest, PayMoneyRequestTest, SplitTest, RejectMoneyRequestTest) now mock the leaf.

`actions/TaskDeletion.ts`

New leaf holding deleteTask, clearTaskErrors, and getNavigationUrlOnTaskDelete.
Those three were the only reason Task.ts imported the hub: they need navigateToConciergeChatAndDeleteReport, getMostRecentReportID, and optimisticReportLastData.
TaskView and DynamicReportDetailsPage import them from the new path. Bodies and comments are unchanged.

`src/libs/buildOldDotURL.ts` and `src/libs/openExternalLink.ts`

New leaves extracted from actions/Link.ts.
buildOldDotURL reads the current email from CurrentUserStore, which replaces the ONYXKEYS.SESSION mirror Link.ts kept for it.
It cannot live in UrlUtils: CONFIG.ts imports UrlUtils and Environment imports CONFIG, so that placement would add a cycle.
Session/index.ts imports both leaves and drops Link.ts entirely.
Link.ts still re-exports openExternalLink, since 27 modules import it from there, and drops the buildOldDotURL re-export that knip flagged once Session stopped using it.

Cycle count tested with `npx oxlint`

Counting import/no-cycle findings only:

	Findings	Files
Merge base	259	78
This branch	256	78

Parts 8 through 11 are still open and remove parallel paths, so the combined drop is larger than what any single branch shows on its own.

Nothing here touches the UI or adds a dependency.

Fixed Issues

$ #99650
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Test 1: Live message in the open report

Covers notifyNewAction in its new module. Smoke check only: the list renders from the report actions data, so this catches load and runtime errors, not a missed notification.

In the A window, open Report 1:1 and leave it on screen.
In the B window, send a message into Report 1:1.
Back in the A window, confirm the message renders without reloading or navigating away.
Send one message from each side. Confirm both render correctly.

Test 2: Delete a task that is the only comment

Covers deleteTask, getNavigationUrlOnTaskDelete, and the Task/TaskDeletion import path in DynamicReportDetailsPage.

Open the task, then its details, then delete it.
Confirm the app lands on the parent report.
Confirm the task preview is gone from the parent.
Confirm no console errors.

Test 3: OldDot link keeps the email param

Covers buildOldDotURL and openExternalLink. The email now comes from CurrentUserStore instead of the mirror Link.ts used to keep, so that param is the thing to watch.

Open Settings, then Troubleshoot, then Go to Expensify Classic.
Confirm the external tab opens an OldDot URL containing email=<your email>, with a single separator before it and no doubled ? or &.
Confirm OldDot opens you as signed in. An authToken in the URL is expected, though a missing one is also fine: the request for it falls back to no token.
Turn the network off and repeat. Confirm the URL still carries email=<your email> and now has no authToken.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mov

Android: mWeb Chrome

android.web.mov

iOS: Native

ios.native.mov

iOS: mWeb Safari

ios.web.mov

MacOS: Chrome / Safari

Test1:

web.1.mov

Test2:

web-2.mov

Test 3:

web-3.mov

codecov · 2026-09-17T12:29:57Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...equestReportView/MoneyRequestReportActionsList.tsx	`86.62% <ø> (ø)`
src/components/ReportActionItem/TaskView.tsx	`85.71% <ø> (ø)`
src/libs/actions/Chronos.ts	`75.86% <ø> (ø)`
src/libs/actions/IOU/Hold.ts	`93.42% <ø> (ø)`
src/libs/actions/IOU/PayMoneyRequest.ts	`81.46% <ø> (ø)`
src/libs/actions/IOU/PerDiem.ts	`75.74% <ø> (ø)`
src/libs/actions/IOU/RejectMoneyRequest.ts	`83.82% <ø> (ø)`
src/libs/actions/IOU/SendInvoice.ts	`93.18% <ø> (ø)`
src/libs/actions/IOU/SendMoney.ts	`90.36% <ø> (ø)`
src/libs/actions/IOU/Split.ts	`77.71% <ø> (ø)`
... and 10 more
... and 13 files with indirect coverage changes

Move the new-action subscriber registry into Report/reportActionSubscribers and the task deletion paths into Task/TaskDeletion, so action modules can notify subscribers or cancel a task without importing the Report hub. buildOldDotURL and openExternalLink become leaves too, which lets actions/Session drop its dependency on actions/Link. Each hub keeps re-exporting the names callers still reach it for, so those imports are unchanged. Drop the buildOldDotURL re-export from actions/Link and the SubscriberCallback type export, both dead once Session moved to the leaf. import(no-cycle) findings drop 264 -> 261 on this base; the wider -55 in the plan stays gated on parts 8-11 landing.

…eport-action-subscribers-v1

LukasMod · 2026-09-18T07:49:54Z

@codex review

…eport-action-subscribers-v1 # Conflicts: # src/libs/actions/Session/index.ts

LukasMod · 2026-09-18T09:42:03Z

@MelvinBot review

MelvinBot · 2026-09-18T10:02:11Z

🤖 Reviewed the diff and drove the three test flows on web. No behavior change found — the moved bodies are line-for-line identical apart from the import renames, and all three flows pass live. Four things to fix, none blocking correctness.

1. The move silently dropped 8 explanatory comments

This is the main one. A "bodies unchanged" refactor is exactly the kind of diff a reviewer skims, so comment loss slips through. Every one of these existed on main and is gone:

Lost comment	New location
`/** Cancels a task by setting the report state to SUBMITTED and status to CLOSED */`	`Task/TaskDeletion.ts:55`
`// If the task report is the last visible action in the parent report, we should navigate back to the parent report`	`Task/TaskDeletion.ts:75`
`// Update optimistic data for parent report action if the report is a child report and the task report has no visible child`	`Task/TaskDeletion.ts:131`
`/** Calculate the URL to navigate to after a task deletion */` + `@param`/`@returns`	`Task/TaskDeletion.ts:33`
`// If no parent report, try to navigate to most recent report`	`Task/TaskDeletion.ts:47`
`// Delete the task preview in the parent report`	`Task/TaskDeletion.ts:214`
`/** Enables the Report actions file to let the ReportActionsList know … @returns Remove subscriber for report id /` + `/* Notify the ReportActionsList that a new comment has arrived */`	`reportActionSubscribers.ts:15`
`// If the URL contains # or ?, we can assume they don't need to have the ? token to start listing url parameters.`	`buildOldDotURL.ts:25`
`/** @param shouldSkipCustomSafariLogic When true, we will use Linking.openURL even if the browser is Safari. */`	`openExternalLink.ts:3`

The new file-header docblocks are good, but they explain why the file exists, not what the code does. Please carry the originals over — the shouldSkipCustomSafariLogic and ?-vs-& ones in particular are non-obvious.

2. `Task.ts` and `Task/` now collide

src/libs/actions/Task.ts and src/libs/actions/Task/ are the only sibling file-plus-directory pair under src/libs/actions/ — IOU/, Report/, Policy/, Session/, and Welcome/ all have no sibling .ts. It resolves today only because Task/ has no index.ts. The day someone adds one, @userActions/Task silently changes meaning and every existing jest.mock('@libs/actions/Task') retargets with it.

Either put the new file at src/libs/actions/TaskDeletion.ts (flat, matching Chronos.ts and the rest), or finish the split and move Task.ts to Task/index.ts. Since later parts of this series will keep carving up Task.ts, the second is probably the better investment.

3. `buildOldDotURL` landed in `actions/`, `openExternalLink` in `libs/`

buildOldDotURL writes no Onyx, calls no API, and dispatches nothing — it is a pure string builder, same as openExternalLink, which you put in src/libs/. @libs/UrlUtils already exports buildSecureDownloadURL, which builds the same shape of OldDot URL with an encoded email param. Co-locating them there would be the most consistent home. Was actions/ deliberate?

4. Dead mock in `SessionTest`

tests/actions/SessionTest.ts:59 still stubs buildOldDotURL and openExternalLink on @libs/actions/Link, but Session/index.ts no longer imports Link at all. The two new mocks below it are what the assertions actually hit now. Drop the @libs/actions/Link factory unless something else in that module graph needs it.

One question

The two subscribers — useReportActionsNewActionLiveTail.ts:6 and MoneyRequestReportActionsList.tsx:40 — still reach subscribeToNewActionEvent through the hub, which is what forces the hub re-export to stay. Pointing them at the leaf is a two-line change that would let you delete the re-export. I assume the blocker is useReportActionsNewActionLiveTailTest.ts:68, which mocks @libs/actions/Report and would need retargeting — deferring to a later part is fine, just confirming that's the reason and not an oversight.

What I verified, and what I couldn't

Equivalence checks that passed:

buildOldDotURL's email source swap is a true no-op. CurrentUserStore subscribes to the same ONYXKEYS.SESSION key and reads the same .email field as the mirror Link.ts kept; the only difference is null vs '', which the ?? '' absorbs. It also initializes earlier, since Log pulls it in.
The three moved Task functions are byte-identical modulo API.write → write, ReportActionsUtils.doesReportHaveVisibleActions → named import, and ReportUtils.canUserPerformWriteAction → canUserPerformWriteActionReportUtils.
No dangling callers: nothing outside Task/TaskDeletion.ts still imports deleteTask, clearTaskErrors, or getNavigationUrlOnTaskDelete from the Task hub.
Task.ts keeps real uses of Navigation, Onyx, and ReportActionsUtils, so no imports were orphaned; Link.ts still uses asyncOpenURL directly at two call sites.
Report/index.ts imports both names at line 279 and re-exports them at 9011/9033, so the hub path is intact.
The three new @typescript-eslint/no-unsafe-type-assertion suppressions match an established pattern — 28 other files in src already use it.
No new cycle from TaskDeletion → @userActions/Report: Report/index.ts imports nothing from Task.

Couldn't run locally (sandbox blocked npx): oxlint -c .oxlintrc.no-cycle.json and jest, so I did not independently reproduce the 264 → 261 count. CI covers the rest — typecheck, ESLint, knip-vs-main, and all 8 test shards pass. The only red check is Check independent approval, which is unrelated.

Live web run — all 3 test-plan flows pass

Ran against this branch (0e3d221) in a headless browser.

Step	Status
Test 1 — live message renders in the open report Sent a message in a plain report; it rendered inline with no navigation and no reload.	✅
Test 2 — delete a task, land on the parent Created a task, opened Details, deleted it. Landed back on the parent report with the task preview gone.	✅
Test 3 — OldDot link keeps the email param Captured URL: `https://www.expensify.com.dev/inbox?authToken=<token>&email=melvinbottestuser%2B...%40gmail.com` — correct email, single `&` before `email=`, no doubled separators. The host then failed DNS, which is a CI sandbox limit, not an app defect.	✅
No JS console errors agent-device does not expose a console reader on web. Proxy check: no in-app error banners in any capture, and the network log showed only expected API calls (OpenReport, CancelTask, OpenTroubleshootSettingsPage, OpenOldDotLink). Worth a human confirming the console directly.	⚠️

I did not test the offline variant of Test 3, so the "no authToken when offline" assertion is unverified.

…libs, drop dead Link mock

… hub re-export

…op hub re-export

melvin-bot · 2026-09-18T13:06:37Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify · 2026-09-18T19:22:47Z

No product review needed.

…eport-action-subscribers-v1 # Conflicts: # src/libs/actions/Link.ts

thelullabyy · 2026-09-21T12:18:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-09-21.at.22.44.49.mov

Screen.Recording.2026-09-21.at.22.44.15.mov

github-actions · 2026-09-21T16:42:12Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-21T16:45:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-21T16:48:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #101419.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e2da3cb-fdcaa24-b09d020abd0274ff69151bb24c008ff70a1cb246/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e2da3cb-fdcaa24-147e58ec2f5fbfa3cf0df5675d58cac77762de9d/index.html

Web 🕸️
https://101419.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-21T19:04:15Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.91-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-21T19:09:53Z

No help site changes are required, so I did not create a draft PR.

This PR is an internal refactor that moves helpers out of Report/index.ts and actions/Link.ts into leaf modules to break import/no-cycle findings. Every changed line is an import path, a moved function body, or a test mock. Nothing changes what a customer sees or does.

How I checked

No documentation or copy files touched. All 50 changed files live under src/libs, src/components, src/pages, and tests. No docs/, no src/languages/*.ts, no .md.
No UI or product behavior change. The three component and page files (MoneyRequestReportActionsList.tsx, TaskView.tsx, DynamicReportDetailsPage.tsx) each change 1–2 lines, and only to point an import at the new module path. Function bodies and comments moved unchanged into Report/reportActionSubscribers.ts, actions/TaskDeletion.ts, buildOldDotURL.ts, and openExternalLink.ts.
No new strings. The only new English text in the diff is test case names in buildOldDotURLTest.ts, openExternalLinkTest.ts, and reportActionSubscribersTest.ts.
No new or changed feature, tab, setting, or button. There is no new entry point for a help article to describe, and no existing article step becomes stale.
The PR is labeled [No QA] and the description states "Nothing here touches the UI or adds a dependency," which matches what the diff shows.

The closest thing to a behavior touch is buildOldDotURL now reading the current email from CurrentUserStore instead of the ONYXKEYS.SESSION mirror. That is a source change for the same value. The Settings > Troubleshoot > Go to Expensify Classic flow works exactly as documented today, so no article needs an edit.

@LukasMod, no linked help site PR was needed for this one. If you expect a customer-visible change I missed, reply with the flow and I will re-check and open the draft PR.

OSBotify · 2026-09-23T05:55:00Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.91-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned LukasMod Sep 17, 2026

LukasMod force-pushed the fix/no-cycle-part12-report-action-subscribers branch 3 times, most recently from be1e316 to 876c8a6 Compare September 17, 2026 12:54

LukasMod force-pushed the fix/no-cycle-part12-report-action-subscribers branch from 876c8a6 to 78d61c1 Compare September 17, 2026 13:22

Merge remote-tracking branch 'origin/main' into fix/no-cycle-part12-r…

367a993

…eport-action-subscribers-v1

Merge remote-tracking branch 'origin/main' into fix/no-cycle-part12-r…

0e3d221

…eport-action-subscribers-v1 # Conflicts: # src/libs/actions/Session/index.ts

LukasMod added 3 commits September 18, 2026 12:49

Restore split comments, flatten TaskDeletion, move buildOldDotURL to …

8a30d41

…libs, drop dead Link mock

Point new-action subscribers at reportActionSubscribers leaf and drop…

36c7faf

… hub re-export

Move notifyNewAction importers to reportActionSubscribers leaf and dr…

9f7f65e

…op hub re-export

LukasMod marked this pull request as ready for review September 18, 2026 13:06

LukasMod requested review from a team as code owners September 18, 2026 13:06

melvin-bot Bot requested review from joekaufmanexpensify and thelullabyy and removed request for a team September 18, 2026 13:06

melvin-bot Bot removed the request for review from a team September 18, 2026 13:06

github-actions Bot reviewed Sep 18, 2026

View reviewed changes

Comment thread src/libs/actions/TaskDeletion.ts Outdated

github-actions Bot reviewed Sep 18, 2026

View reviewed changes

Comment thread src/libs/actions/TaskDeletion.ts Outdated

github-actions Bot reviewed Sep 18, 2026

View reviewed changes

Comment thread src/libs/actions/TaskDeletion.ts Outdated

Drop the three type assertions in TaskDeletion

6253406

joekaufmanexpensify removed their request for review September 18, 2026 19:22

Merge remote-tracking branch 'origin/main' into fix/no-cycle-part12-r…

505d6ec

…eport-action-subscribers-v1 # Conflicts: # src/libs/actions/Link.ts

thelullabyy approved these changes Sep 21, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham September 21, 2026 16:15

roryabraham approved these changes Sep 21, 2026

View reviewed changes

roryabraham merged commit e2da3cb into Expensify:main Sep 21, 2026
35 of 37 checks passed

OSBotify mentioned this pull request Sep 21, 2026

Deploy Checklist: New Expensify 2026-09-21 #101773

Closed

70 tasks done

MelvinBot mentioned this pull request Sep 21, 2026

Android - Expense - Report field value jumps when navigating from one report to another #101798

Closed

1 of 7 tasks

melvin-bot Bot mentioned this pull request Sep 23, 2026

Fix import/no-cycle that are currently silent #99650

Open

Conversation

LukasMod commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Changes

Report/reportActionSubscribers.ts

actions/TaskDeletion.ts

src/libs/buildOldDotURL.ts and src/libs/openExternalLink.ts

Cycle count tested with npx oxlint

Fixed Issues

Tests

Test 1: Live message in the open report

Test 2: Delete a task that is the only comment

Test 3: OldDot link keeps the email param

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LukasMod commented Sep 18, 2026

Uh oh!

LukasMod commented Sep 18, 2026

Uh oh!

MelvinBot commented Sep 18, 2026

1. The move silently dropped 8 explanatory comments

2. Task.ts and Task/ now collide

3. buildOldDotURL landed in actions/, openExternalLink in libs/

4. Dead mock in SessionTest

One question

Uh oh!

melvin-bot Bot commented Sep 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joekaufmanexpensify commented Sep 18, 2026

Uh oh!

thelullabyy commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Sep 21, 2026

Uh oh!

OSBotify commented Sep 21, 2026

Uh oh!

github-actions Bot commented Sep 21, 2026

Uh oh!

OSBotify commented Sep 21, 2026

Uh oh!

MelvinBot commented Sep 21, 2026

Uh oh!

OSBotify commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LukasMod commented Sep 17, 2026 •

edited

Loading

`Report/reportActionSubscribers.ts`

`actions/TaskDeletion.ts`

`src/libs/buildOldDotURL.ts` and `src/libs/openExternalLink.ts`

Cycle count tested with `npx oxlint`

codecov Bot commented Sep 17, 2026 •

edited by github-actions Bot

Loading

2. `Task.ts` and `Task/` now collide

3. `buildOldDotURL` landed in `actions/`, `openExternalLink` in `libs/`

4. Dead mock in `SessionTest`

thelullabyy commented Sep 21, 2026 •

edited

Loading