Repository navigation
upgrade: bump @shopify/flash-list to v2.3.2 - #101354
Beamanator merged 2 commits into
Conversation
|
|
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I'm opening this PR for review though I haven't added the recordings for iOS native because I'm getting a simulator error due to compatibility along with XCode 27. I'll add the ios native recordings once that issue will be solved. In the meantime, I've opened the PR for review because I don't think ios native recording should block the PR review. Thanks. |
|
@mananjadhav Could you please test the Hybrid app too, I don't have access to Hybrid app? Thanks. |
|
@Beamanator Can you please run the adhoc builds for iOS and Android |
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
fixed merge conflicts |
|
From this comment, I've added the recordings for iOS native. Thanks |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb Chromemweb-chrome-scroll.moviOS: HybridAppios-scroll.mp4iOS: mWeb Safarimweb-safari-scroll.movMacOS: Chrome / Safariweb-list-scroll-1.movweb-list-scroll-2.movweb-list-scroll-3.mov |
mananjadhav
left a comment
There was a problem hiding this comment.
Issues with my Android so skipped but tested on all other platforms.
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.92-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR upgrades
@shopify/flash-listfrom2.3.0to2.3.2to solve the issue where the transaction detail chat did not remain at the newest message after the user scrolled away and sent another message..The transaction detail chat uses an inverted FlashList. After we scroll away from the newest message and send another message, the App correctly calls
scrollToIndex({index: 0})to scroll back to it. However, FlashList could run a delayedscrollToEnd()afterward, which overrides the App's scroll and moves the chat away from the newest message.FlashList
2.3.2includes the fix from Shopify FlashList PR #2290. The fix prevents the delayed automatic scroll from running whilescrollToIndex()is updating the list position.The existing FlashList patches have also been updated to apply to
2.3.2.Fixed Issues
$ #99559
PROPOSAL: #99559 (comment)
Tests
Precondition: Account has at least one workspace.
Offline tests
Same as Test
QA Steps
Same as Test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-native.mov
Android: mWeb Chrome
Android-mweb.mov
iOS: Native
iOS-native.mov
iOS: mWeb Safari
iOS-safari.mp4
MacOS: Chrome / Safari
macOS-web.mp4