Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Three tests in
tests/navigation/NavigateTests.tsxfail onmainand break the Jest job.This is a semantic merge conflict between two PRs that each passed CI on their own:
Insightsscreen toTestTabNavigatorand shifted every seeded tab route index by one.TestTabNavigatordeclaresInsightsbetweenSearch_Fullscreen_NavigatorandSettings_Split_Navigator. React Navigation rehydrates the seeded state against that declaration, so it inserts the missingInsightsroute at position 3. That pushesWorkspace_Navigatorfrom index 4 to index 5. The three tests then readroutes.at(4), get theSettings_Split_Navigatorroute, and every assertion on its nested state returnsundefined.The fix adds
{name: SCREENS.INSIGHTS}to the seeded state of the three tests, bumps the focusedindexfrom 4 to 5, and readsroutes.at(5)for the Workspace navigator. This matches what the other eleven tests in the file already do. No production code changes.Failing run: https://github.com/Expensify/App/actions/runs/34632498401/job/103372459817
Fixed Issues
$
PROPOSAL:
Tests
npx jest tests/navigation/NavigateTests.tsx.npx jest tests/navigation.mainand runnpx jest tests/navigation/NavigateTests.tsx.Offline tests
Not applicable. This PR only changes Jest test fixtures.
QA Steps
Not applicable. This PR only changes Jest test fixtures and does not touch production code.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not applicable. This PR only changes Jest test fixtures.
Android: mWeb Chrome
Not applicable. This PR only changes Jest test fixtures.
iOS: Native
Not applicable. This PR only changes Jest test fixtures.
iOS: mWeb Safari
Not applicable. This PR only changes Jest test fixtures.
MacOS: Chrome / Safari
Not applicable. This PR only changes Jest test fixtures.