Skip to content

Fix Workspace navigation tests after Insights tab addition #101024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiceli merged 2 commits into from
Sep 17, 2026
Merged

Fix Workspace navigation tests after Insights tab addition #101024

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24dfb78
Fix Workspace navigation tests after Insights tab addition
nabi-ebrahimi Sep 12, 2026
356455c
Merge branch 'main' into fix/100987-workspace-navigation-test-tab-order
nabi-ebrahimi Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions tests/navigation/NavigateTests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,12 @@ const mockedGetIsNarrowLayout = jest.mocked(getIsNarrowLayout);
const mockedUseResponsiveLayout = jest.mocked(useResponsiveLayout);

/**
* Looks the Workspace navigator up by name rather than by a hardcoded index, so adding a tab to TAB_SCREENS
* doesn't silently shift the index and make these assertions read `undefined`.
* Looks the Tab and Workspace navigators up by name rather than by hardcoded indexes, so adding or reordering routes
* doesn't silently shift an index and make these assertions read `undefined`.
*/
function getWorkspaceNavigatorState() {
return navigationRef.current
?.getRootState()
.routes.at(0)
?.state?.routes.findLast((route) => route.name === NAVIGATORS.WORKSPACE_NAVIGATOR)?.state;
const tabNavigatorState = navigationRef.current?.getRootState().routes.findLast((route) => route.name === NAVIGATORS.TAB_NAVIGATOR)?.state;
return tabNavigatorState?.routes.findLast((route) => route.name === NAVIGATORS.WORKSPACE_NAVIGATOR)?.state;
}

describe('Navigate', () => {
Expand Down Expand Up @@ -283,6 +281,7 @@ describe('Navigate', () => {
{name: SCREENS.HOME},
{name: NAVIGATORS.REPORTS_SPLIT_NAVIGATOR},
{name: NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR},
{name: SCREENS.INSIGHTS},
{name: NAVIGATORS.SETTINGS_SPLIT_NAVIGATOR},
{name: NAVIGATORS.WORKSPACE_NAVIGATOR},
],
Expand Down
Loading