[No QA] Docs updates for E/A#100872 document Upcoming travel section on Home - #101001
Conversation
Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@RachCHopkins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
I can't see this on staging, for a customer I know has a trip coming up |
|
This is from a customer, I think we had a window where there was bug on this, but it is fixed with the latest auth deploy, can you check again please @RachCHopkins
|
|
🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.4.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.4.86-0 🚀
|
|
🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.4.89-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |


Explanation of Change
Documentation-only follow-up to #100872, which changed where the Upcoming travel section on Home gets its data and, more importantly, changed which reservations it shows.
Before that PR, Upcoming travel only listed trips where the signed-in member was the owner of the trip chat. After it, the section lists reservations where the signed-in member is a traveler on the booking. That is a user-visible behavior change, and the help site had no coverage of the section at all —
Expensify-Home-Overview.mdenumerated every other Home section but omitted Upcoming travel.This PR updates
docs/articles/new-expensify/getting-started/Expensify-Home-Overview.mdto:## How the Upcoming travel section works on Homesection describing the 7-day window, the traveler-based filter, the row format, canceled reservations, and what selecting a row does.## Why don’t I see the Upcoming travel section?FAQ entry covering the two reasons the section is hidden.keywordsandinternalScopemetadata so the new content is retrievable.No other article needed a change.
articles/travel/managing-trips/View-Upcoming-and-Past-Trips.mddocuments the Trips view inside the travel tool, which this PR did not touch; the new section cross-links to it rather than duplicating it. The rest of #100872 is an internal data-source refactor (readingtripDatafrom report name-value-pairs instead of report data) with no user-facing surface.Behavior documented here was read from the code on the PR branch: the 7-day window comes from
CONST.UPCOMING_TRAVEL_WINDOW_DAYS, the traveler filter and row copy fromsrc/pages/home/UpcomingTravelSection/, and the section title fromhomePage.upcomingTravelinsrc/languages/en.ts. The Home tab label was confirmed against the live web UI; the Upcoming travel section itself could not be observed live because the test account has no booked trips, so please confirm the described behavior.Fixed Issues
$ #100872
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — this PR only changes a help site Markdown article and ships no app code.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@rlinoz, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.