Repository navigation
[No QA] Docs updates for E/A#99235 Save button for settlement frequency and conversion fees - #100895
Conversation
…ersion fees Co-authored-by: truph01 <truph01@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot Mark this PR as ready |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@truph01 @johncschuster One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🤖 Done — this PR is now Ready for review. PullerBear picked it up and assigned One thing left for you: the Tests and QA Steps sections still contain the All checks pass except view run · no recording available |
HelpDot Documentation ReviewOverall AssessmentThis PR adds two new task-based Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
@MelvinBot Resolve conflict |
…t-frequency-currency-fees-save # Conflicts: # docs/articles/new-expensify/workspaces/Workspace-Workflows.md
|
🤖 Conflict resolved and pushed — the branch now contains current What conflicted:
How I resolved it: kept both sections verbatim, with the currency conversion fees section first (it belongs with the other Payments sections) and the Advanced tab section after it, separated by the usual VerificationDiffing the resolved file against Whole-PR diff against I also added the blank line before the trailing Tests: this is a Markdown-only change under Merge commit: |
|
A preview of your ExpensifyHelp changes have been deployed to https://b4eed55c.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.92-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
#99235 changed two single-select settings pages so a selection is staged locally and only written when the user clicks Save (WCAG 3.2.2 "On Input", part of the batch in #74834):
Previously, clicking an option saved it immediately (and navigated away). Now nothing is saved until Save is clicked, Save is disabled while the staged selection matches the saved value, and leaving the page without saving keeps the existing value.
The help site described the Settlement frequency setting but never gave steps for changing it, and Currency conversion fees was not documented at all. This PR documents both flows with the required Save step:
docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-US.md— new section How to change your Expensify Card settlement frequency, including the Plaid + positive 90-day balance requirement for switching to Monthly.docs/articles/new-expensify/workspaces/Workspace-Workflows.md— new section How to choose who pays currency conversion fees under the Payments sections, noting the row appears only when Payments is enabled with a connected reimbursement bank account and is not available on every workspace.Labels are taken verbatim from
src/languages/en.ts(workspace.expensifyCard.settlementFrequency,frequency.daily,frequency.monthly,workflowsCurrencyConversionFeesPage.title,companyPays,employeePays) and from the row rendering insrc/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx. Both sections followdocs/HELP_AUTHORING_GUIDELINES.md(task-based##headings, sequential steps) anddocs/HELPSITE_NAMING_CONVENTIONS.md(bold, sentence-case UI labels).Fixed Issues
$ #74834
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests they ran before marking this PR as "Ready for review".
// This PR only changes Markdown under
docs/articles; no app code is touched.Offline tests
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR as "Ready for review".
// Documentation-only change: no app behavior changes.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.