Skip to content

[No QA] Docs updates for E/A#99235 Save button for settlement frequency and conversion fees - #100895

Merged
stephanieelliott merged 2 commits into
mainfrom
claude-docs-settlement-frequency-currency-fees-save
Sep 23, 2026
Merged

stephanieelliott merged 2 commits into
mainfrom
claude-docs-settlement-frequency-currency-fees-save

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#99235 changed two single-select settings pages so a selection is staged locally and only written when the user clicks Save (WCAG 3.2.2 "On Input", part of the batch in #74834):

  • Settlement frequency (Workspaces > [Workspace Name] > Expensify Card > Settings) — Daily / Monthly
  • Currency conversion fees (Workspaces > [Workspace name] > Workflows > Payments) — Company pays / Employee pays

Previously, clicking an option saved it immediately (and navigated away). Now nothing is saved until Save is clicked, Save is disabled while the staged selection matches the saved value, and leaving the page without saving keeps the existing value.

The help site described the Settlement frequency setting but never gave steps for changing it, and Currency conversion fees was not documented at all. This PR documents both flows with the required Save step:

  • docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-US.md — new section How to change your Expensify Card settlement frequency, including the Plaid + positive 90-day balance requirement for switching to Monthly.
  • docs/articles/new-expensify/workspaces/Workspace-Workflows.md — new section How to choose who pays currency conversion fees under the Payments sections, noting the row appears only when Payments is enabled with a connected reimbursement bank account and is not available on every workspace.

Labels are taken verbatim from src/languages/en.ts (workspace.expensifyCard.settlementFrequency, frequency.daily, frequency.monthly, workflowsCurrencyConversionFeesPage.title, companyPays, employeePays) and from the row rendering in src/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx. Both sections follow docs/HELP_AUTHORING_GUIDELINES.md (task-based ## headings, sequential steps) and docs/HELPSITE_NAMING_CONVENTIONS.md (bold, sentence-case UI labels).

Fixed Issues

$ #74834
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests they ran before marking this PR as "Ready for review".
// This PR only changes Markdown under docs/articles; no app code is touched.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR as "Ready for review".
// Documentation-only change: no app behavior changes.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…ersion fees

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 10, 2026 22:55
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 10, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99235 Save button for settlement frequency and conversion fees [No QA] Docs updates for E/A#99235 Save button for settlement frequency and conversion fees Sep 10, 2026
@OSBotify

This comment has been minimized.

@truph01

truph01 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Mark this PR as ready

@MelvinBot
MelvinBot marked this pull request as ready for review September 15, 2026 08:44
@melvin-bot

melvin-bot Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @johncschuster

@melvin-bot
melvin-bot Bot requested review from johncschuster and truph01 and removed request for a team September 15, 2026 08:45
@melvin-bot

melvin-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

@truph01 @johncschuster One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

MelvinBot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now Ready for review. PullerBear picked it up and assigned stephanieelliott as reviewer.

One thing left for you: the Tests and QA Steps sections still contain the // TODO: placeholders. I don't fill those out on a human's behalf, so please replace them (or confirm the [No QA] / docs-only wording you want) before review.

All checks pass except Check independent approval, which just reflects that the PR hasn't been approved yet.


view run · no recording available

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds two new task-based ## sections documenting the new Save-button behavior for two single-select settings: Settlement frequency (Expensify Card) and Currency conversion fees (Workflows). Both additions are well-scoped, clearly written, and align closely with the HelpDot governance files. Only the newly added lines were evaluated.

Scores Summary

  • Readability: 9/10 - Clear, sequential numbered steps and concise explanatory prose. The paragraph explaining the Save-disabled behavior is slightly dense and could be trimmed for scannability, but it reads well.
  • AI Readiness: 9/10 - Both headings are full How to... task-based phrases with feature-specific wording, use exact UI labels, and only ## heading depth is introduced. Metadata/YAML is outside the diff and was not scored.
  • Style Compliance: 8/10 - UI labels are bold and in correct sentence case, taken verbatim from en.ts. Section names (Payments, Settings, Workflows) are correctly referenced. One deviation from the navigation standard (see findings).

Key Findings

  • Strong adherence to task-based ## heading rules (HELP_AUTHORING_GUIDELINES.md Section 2) - both start with 'How to' and are feature-specific and searchable.
  • Excellent UI-label fidelity: Daily, Monthly, Company pays, Employee pays, Settlement frequency, Currency conversion fees, and Save are all bold, sentence-case, and match the product UI.
  • Availability/prerequisite conditions (Plaid + 90-day balance for Monthly; Payments enabled with a connected reimbursement bank account for currency conversion fees) are stated explicitly and up front - good conditional clarity.
  • Navigation deviation: the phrasing 'on the left on web, and at the bottom on mobile' differs from the standard unified sentence in HELPSITE_NAMING_CONVENTIONS.md ('on the left on web, on the bottom on mobile'). Minor, but should be normalized for consistency.
  • The workspace placeholder casing is inconsistent between the two files ([Workspace Name] vs [Workspace name]).

Recommendations

  • Normalize navigation phrasing to the exact standard: 'In the navigation tabs (on the left on web, on the bottom on mobile)'.
  • Use consistent casing for the workspace placeholder across both files ([Workspace name]).
  • Optionally split the dense Save-behavior paragraph into two shorter sentences for scannability.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-US.md - New section 'How to change your Expensify Card settlement frequency'. Compliant; minor navigation phrasing note.
  • docs/articles/new-expensify/workspaces/Workspace-Workflows.md - New section 'How to choose who pays currency conversion fees'. Compliant; minor navigation phrasing note.

Note: Detailed line-by-line feedback has been provided as inline comments.

johncschuster
johncschuster previously approved these changes Sep 16, 2026
@truph01

truph01 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Resolve conflict

…t-frequency-currency-fees-save

# Conflicts:
#	docs/articles/new-expensify/workspaces/Workspace-Workflows.md
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Conflict resolved and pushed — the branch now contains current main with no conflicts.

What conflicted: docs/articles/new-expensify/workspaces/Workspace-Workflows.md — one hunk. Both sides added a new section at the same spot, so nothing actually disagreed:

  • This PR: ## How to choose who pays currency conversion fees
  • main: ## How to automate report compliance on the Advanced tab (added by a separate docs PR)

How I resolved it: kept both sections verbatim, with the currency conversion fees section first (it belongs with the other Payments sections) and the Advanced tab section after it, separated by the usual --- rule.

Verification

Diffing the resolved file against main shows the currency conversion fees section as the only addition — nothing from main was dropped:

@@ -110,6 +110,21 @@ Only the authorized payer is prompted to pay reports...
 
 ---
 
+## How to choose who pays currency conversion fees
+
+When you reimburse in a different currency, conversion fees may apply...
+
+1. In the navigation tabs..., click **Workspaces > [Workspace name] > Workflows**.
+2. Under **Payments**, click **Currency conversion fees**.
+3. Select **Company pays** or **Employee pays**.
+4. Click **Save**.
+
+Selecting an option does not change the setting on its own...
+
+**Currency conversion fees** appears under **Payments** only when...
+
+---
+
 ## How to automate report compliance on the Advanced tab

Whole-PR diff against main is 2 files changed, 29 insertions(+) — purely additive, matching the PR's original intent. Set-Up-and-Manage-the-Expensify-Card-US.md merged cleanly and was not touched.

I also added the blank line before the trailing ---. Without it, Markdown would have parsed the preceding paragraph plus --- as a setext <h2> instead of a horizontal rule.

Tests: this is a Markdown-only change under docs/articles, and the resolution introduced no new prose — both sides were kept byte-for-byte. I could not run cspell locally in this environment, but since no new words were written, CI's spell check is the authoritative gate and should be unaffected.

Merge commit: 6182b58. Note that per this repo's history policy I merged main in rather than rebasing, so your original commit is untouched.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

@stephanieelliott
stephanieelliott merged commit e354b9a into main Sep 23, 2026
24 of 25 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docs-settlement-frequency-currency-fees-save branch September 23, 2026 00:10
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.92-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants