Skip to content

[Home][Design polish] Use the one-color Concierge icon in the page header - #100833

Closed
grgia wants to merge 1 commit into
mainfrom
georgia-concierge-header-icon
Closed

grgia wants to merge 1 commit into
mainfrom
georgia-concierge-header-icon

Conversation

@grgia

@grgia grgia commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The Concierge button in the top right of page headers now renders a one-color Concierge glyph in the same style as the search icon next to it.

An account avatar is about to move into the top right of every header. The Concierge button there used the full-color Concierge avatar, so two round avatars would sit side by side and there would be no visual difference between your own account and an app action. The header button (SidePanelButton) now draws the flat Concierge icon at the default icon size with the theme icon color, exactly like the search button.

  • assets/images/concierge.svg replaced with the new one-color asset from design
  • Same asset backs the "Explain" report action context menu item
  • Web and native button variants both updated

Fixed Issues

$ #100827
PROPOSAL:

Tests

  1. Sign in and open the Home page.
  2. Verify the top right shows the search icon and, next to it, a flat one-color Concierge icon (triangle with eye and two sparkles) in the same gray as the search icon.
  3. Verify the icon is the same size as the search icon and is centered in its tap target.
  4. Click the Concierge icon and verify the help side panel opens (web) or the Concierge chat opens (native).
  5. Switch to dark mode and verify the icon color follows the theme.
  6. Open a report, long press or right click a Concierge message that has reasoning, and verify the "Explain" menu item shows the same one-color icon.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests. The icon is a bundled asset and does not depend on network state.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ponents/SidePanel/SidePanelButton/index.native.tsx 100.00% <100.00%> (ø)
.../SidePanel/SidePanelButton/SidePanelButtonBase.tsx 0.00% <0.00%> (ø)
... and 4 files with indirect coverage changes

@grgia

grgia commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 89dbb7268b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100833.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://100833.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@grgia

grgia commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
image

@grgia

grgia commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Closing for #100832

@grgia grgia closed this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant