Repository navigation
Use named import in canFocusInputOnScreenFocus - #100614
Conversation
Seatbelt-Operation: s08-16be74c9-a9a8626-sign-1
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Seatbelt-Operation: main-update-100614-20261016-sign-0c70716d
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-10-16.at.18.06.57.mov |
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - The code changes are correct and safe, so I have nothing to raise on it. No regression risk.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.5.15-1 🚀
|
|
No help site update is needed. This PR only switches |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
src/libs/canFocusInputOnScreenFocus/index.tsnow calls the namedcanUseTouchScreenimport instead of the same function through theDeviceCapabilitiesnamespace. The negation and focus decision remain unchanged.Fixed Issues
$ #94739
PROPOSAL: #94739 (comment)
Tests
Focused lint, formatting, and helper behavior checks passed. Six related autofocus tests passed.
Offline tests
The import change does not alter network handling, so it adds no distinct offline case.
QA Steps
Use a non-touch desktop browser.
1. Email autofocus.
2. Code autofocus.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Recordings (2)
pr100614-current-head-code-autofocus-desktop.mp4
pr100614-current-head-email-autofocus-desktop.mp4