[CP Staging] Hide Merge Reports functionality behind beta - #100523
Conversation
|
@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a140934edb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
[CP Staging] Hide Merge Reports functionality behind beta (cherry picked from commit b662a70) (cherry-picked to staging by mountiny)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.73-3 🚀
|
|
🤖 No help site changes are required — no draft PR created. This PR gates the existing "Merge reports" bulk action behind the new Merging reports was never documented on the help site, so there is nothing to remove or qualify:
Per the authoring guidelines, beta-gated features shouldn't be documented until they're generally available. Once the @Gonals, no help site PR was needed for this change, so there's nothing for you to review or mark |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.74-0 🚀
|
|
🤖 No help site changes are required, so I did not create a docs PR. This PR only adds a beta gate (
Why no docs update is neededReport merging is not documented anywhere on the help site today, so there is nothing to remove or caveat. I searched Per @Gonals, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR (Note: there is no linked help site PR — none was needed. If you'd rather I pre-write the article now so it's ready when the beta ships, reply with |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.74-2 🚀
|
Explanation of Change
We have a few (small) bugs on staging for this functionality. Instead of reverting the whole thing, which would be a pain,, let's hide it behind a beta:
#100512
#100502
#100497
Fixed Issues
$
PROPOSAL:
Tests
With an account NOT on the beta:
Confirm it is visible if the account is on the beta
Offline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari