[No QA] Docs updates for E/A#97951 Bulk editing one tag level preserves other levels - #100483
Conversation
Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot mark this PR as ready for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@sobitneupane @RachCHopkins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Done — this PR is now marked Ready for review. One thing to fix before a reviewer picks it up: the All checks pass except |
HelpDot Documentation ReviewOverall AssessmentThis PR is a focused, well-executed help-site follow-up to a behavior change in bulk tag editing (E/A#97951). It updates the Edit-Expenses.md article to replace outdated "values are overwritten" language with accurate documentation of how multi-level Tags behave when using Edit multiple. Changes are limited to one article and cover the metadata, a new explanatory section, a supporting bullet, an FAQ entry, and a cross-link. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a documentation-only change with a single modified file; feedback is captured in this summary. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5dbf3aea0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@stephanieelliott do you want to make the changes so that I can merge? |
This comment has been minimized.
This comment has been minimized.
Updated internalScope to clarify tag configuration details.
|
Yep, thanks @RachCHopkins! All set |
|
A preview of your ExpensifyHelp changes have been deployed to https://097c70ef.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.4.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.4.86-0 🚀
|
|
🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.4.89-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site follow-up for #97951, which changed how Edit multiple applies a tag edit. Before that fix, bulk editing one tag level overwrote the whole tag string on every selected expense and wiped the levels the user never touched. The fix applies the edit per transaction, so only the edited level changes.
docs/articles/new-expensify/reports-and-expenses/Edit-Expenses.mddocumented the old behavior with the blanket line "Existing values are overwritten with the new values you enter." This PR updates that article to describe the current behavior:## How multi-level Tags are updated when you edit multiple expenses, covering independent Tags (untouched levels keep each expense's own value) and dependent Tags (levels above the edited one are kept, levels below are cleared because their options depend on the level that changed).## What happens after you edit expensesnoting that only the tag levels you edit are changed.keywordsandinternalScopeto cover multi-level tag bulk editing.Written against
docs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md: one workflow per article, task-based##headings only, UI-exact bolded labels (Edit multiple), a single#title plus# FAQ, and relative links placed outside numbered steps.No other article documents bulk tag editing, so this is the only file that needed a change.
Fixed Issues
$ #97356
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// This is a documentation-only change, so verification means confirming the article text matches current app behavior.
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@sobitneupane, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.