[No QA] Correct Expensify Travel plan availability in help article - #100229
Conversation
Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @zanyrenney |
|
@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 664190e26e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - All travel activity is visible in one place | ||
|
|
||
| Expensify Travel is available globally and included with every Expensify plan. | ||
| Expensify Travel is available globally on the Collect and Control plans. |
There was a problem hiding this comment.
Align the FAQ with the paid-plan restriction
For readers using a Submit workspace, this correction is contradicted by the FAQ answer at line 60, which still says that “Any workspace can use Expensify Travel.” Since the app redirects Submit workspaces to the upgrade flow, the article remains misleading unless that answer is also limited to Collect and Control workspaces.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single-line factual correction to Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This change is a single line, so no separate inline comments were necessary. |
|
A preview of your ExpensifyHelp changes have been deployed to https://09e2a84e.helpdot.pages.dev ⚡️ Updated articles: |
zanyrenney
left a comment
There was a problem hiding this comment.
completed checklist and all good to go here.
|
🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.4.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The help article Enable Expensify Travel on a workspace said Expensify Travel is "included with every Expensify plan." That is not what the app does — a Submit workspace that toggles Travel on is redirected into the upgrade flow rather than having Travel enabled, so Collect is the real minimum plan.
The gate lives in the Travel toggle at
src/pages/workspace/WorkspaceMoreFeaturesPage/index.tsx:600, which callstryNavigateToSubmitWorkspaceUpgradewith thetravelSubmitalias. That helper, atsrc/libs/PolicyUtils.ts:1448, navigates any Submit policy to the workspace upgrade page and returnstrueso the caller never enables the feature. There is no Control-only check on Travel anywhere, so Collect and Control are both supported.This corrects the one inaccurate sentence in the article so the docs match the behavior. Docs-only change — no app code is touched.
Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — help site markdown only, no app behavior changes.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.AI Tests
Docs-only change (one line of markdown in
docs/articles/). No app code, TypeScript, or styles were touched, so the App required-local bundle (lint,typecheck,jest,storybook) has nothing in scope to exercise.npm run prettierandnpm run spell-changed—node_modulesis not installed in this environment and dependency install was unavailable. The change is a single prose sentence introducing no new vocabulary and no formatting constructs, so both checks should pass in CI.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari