Skip to content

[No QA] Correct Expensify Travel plan availability in help article - #100229

Merged
zanyrenney merged 1 commit into
mainfrom
claude-travelPlanHelpDocFix
Sep 7, 2026
Merged

zanyrenney merged 1 commit into
mainfrom
claude-travelPlanHelpDocFix

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The help article Enable Expensify Travel on a workspace said Expensify Travel is "included with every Expensify plan." That is not what the app does — a Submit workspace that toggles Travel on is redirected into the upgrade flow rather than having Travel enabled, so Collect is the real minimum plan.

The gate lives in the Travel toggle at src/pages/workspace/WorkspaceMoreFeaturesPage/index.tsx:600, which calls tryNavigateToSubmitWorkspaceUpgrade with the travelSubmit alias. That helper, at src/libs/PolicyUtils.ts:1448, navigates any Submit policy to the workspace upgrade page and returns true so the caller never enables the feature. There is no Control-only check on Travel anywhere, so Collect and Control are both supported.

This corrects the one inaccurate sentence in the article so the docs match the behavior. Docs-only change — no app code is touched.

Fixed Issues

$
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — help site markdown only, no app behavior changes.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

AI Tests

Docs-only change (one line of markdown in docs/articles/). No app code, TypeScript, or styles were touched, so the App required-local bundle (lint, typecheck, jest, storybook) has nothing in scope to exercise.

  • Could not run: npm run prettier and npm run spell-changednode_modules is not installed in this environment and dependency install was unavailable. The change is a single prose sentence introducing no new vocabulary and no formatting constructs, so both checks should pass in CI.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 2, 2026 22:41
@jamesdeanexpensify
jamesdeanexpensify marked this pull request as ready for review September 2, 2026 22:43
@melvin-bot

melvin-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @zanyrenney

@melvin-bot
melvin-bot Bot requested review from zanyrenney and removed request for a team September 2, 2026 22:43
@melvin-bot

melvin-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 664190e26e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- All travel activity is visible in one place

Expensify Travel is available globally and included with every Expensify plan.
Expensify Travel is available globally on the Collect and Control plans.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align the FAQ with the paid-plan restriction

For readers using a Submit workspace, this correction is contradicted by the FAQ answer at line 60, which still says that “Any workspace can use Expensify Travel.” Since the app redirects Submit workspaces to the upgrade flow, the article remains misleading unless that answer is also limited to Collect and Control workspaces.

Useful? React with 👍 / 👎.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single-line factual correction to docs/articles/travel/company-setup/Enable-Travel-on-a-Workspace.md. It replaces the inaccurate claim that Expensify Travel is "included with every Expensify plan" with "available globally on the Collect and Control plans," aligning the documentation with actual app behavior (Submit workspaces are redirected to the upgrade flow, making Collect the real minimum). This is a docs-only, correctness-focused change with a tightly scoped diff.

Scores Summary

  • Readability: 10/10 - Clear, concise declarative sentence. Well-formed and scannable, consistent with the surrounding prose.
  • AI Readiness: 9/10 - Uses the full feature name (Expensify Travel) and names plans explicitly (Collect, Control), matching the plan vocabulary in TEMPLATE.md. Improves factual retrievability. No headings or metadata were touched by the diff, so nothing to fault there.
  • Style Compliance: 9/10 - "Collect" and "Control" are correct plan terminology per the template's plan list. Plan names are not UI buttons/tabs/toggles, so bold formatting is correctly not applied.

Key Findings

  • The corrected sentence resolves a factual inaccuracy and is well supported by the code references cited in the PR description.
  • Terminology (feature name, plan names) is consistent with the governance files and the rest of the article.
  • The change is minimal, low-risk, and introduces no new vocabulary or formatting constructs.
  • No structural, heading, metadata, or navigation elements were modified, so those governance areas are out of scope for this review.

Recommendations

  • No blocking issues. The single-line change is accurate and compliant.
  • Optional: confirm with the plan-availability source of truth that no other plan (e.g., legacy tiers) should be listed, so the article stays accurate over time.

Files Reviewed

  • docs/articles/travel/company-setup/Enable-Travel-on-a-Workspace.md - Approved. One-line factual correction; accurate and style-compliant.

Note: This change is a single line, so no separate inline comments were necessary.

@github-actions github-actions Bot changed the title Correct Expensify Travel plan availability in help article [No QA] Correct Expensify Travel plan availability in help article Sep 2, 2026
@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://09e2a84e.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 4, 2026

@zanyrenney zanyrenney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completed checklist and all good to go here.

@zanyrenney
zanyrenney merged commit ba8c68a into main Sep 7, 2026
21 of 23 checks passed
@zanyrenney
zanyrenney deleted the claude-travelPlanHelpDocFix branch September 7, 2026 09:36
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants