Repository navigation
[No QA] Docs updates for E/A#98753 Document Domains navigation suggestions in Search - #100222
Conversation
Co-authored-by: Nabi <nabi-ebrahimi@users.noreply.github.com>
|
I reviewed the documentation changes and confirmed they match the implemented behavior in #98753. @MelvinBot mark this PR as ready for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @lschurr |
|
@marufsharifi @lschurr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR updates Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This assessment is based solely on the proposed diff. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.92-0 🚀
|
|
@stephanieelliott Can I check it off the list if no need QA? |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site follow-up for #98753, which adds Domain navigation suggestions to Search.
Navigating-New-Expensify.mddocumented the Search "Go to" destinations as Home, Inbox, Spend, Workspaces, and Account, so it no longer matched the product. This PR updates that article to cover what #98753 shipped:## How to jump to a domain page using Searchsection for the Domain members, Domain admins, Groups, and SAML suggestions, including matching by domain name and the domain name shown on the right of each row.description,keywords, andinternalScopeso the article is retrievable for domain-navigation searches.Labels were verified against the live UI on web rather than taken from the diff: Search shows
Go to Account,Go to Domains,Go to Home,Go to Inbox,Go to Spend, andGo to Workspaces, and the Domains page is reached through the left navigation Workspaces item, which has Workspaces and Domains tabs. The domain subpage labels (Domain members, Domain admins, Groups, SAML) come from thedomainstrings insrc/languages/en.ts, because the test account administers no domain and could not render those rows.Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: one#title plus# FAQ,##sections only, task-based headings, bolded UI labels using the exact UI casing, and a relative cross-link.No product code is changed — this PR touches one Markdown file under
docs/articles.Fixed Issues
$ #92752
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// The human co-author must fill out the QA steps before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@nabi-ebrahimi, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.