Repository navigation
feat: remove isNewManualExpenseFlowEnabled beta flag - #100215
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e25e242ad
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosiOS: Native
MacOS: Chrome / SafariScreen.Recording.2026-06-21.at.18.17.32.mov |
|
How you getting on with the review, @ikevin127? |
|
Will complete today. |
🟠 Merge order against the still-open #99947This branch is based on a
Land #99947 first, then rebase this one and strip the remaining cc @thelullabyy |
|
✅ Completed code-review. Awaiting this comment and the other code-related comments to be addressed first before moving forward. |
…ve-beta-flag-93854-part-6
|
@ikevin127 I don't think this is blocked by any PR - we are good to merge it |
|
@trjExpensify @ikevin127 I resolved conflicts, please check. Thank you |
|
Dammit, we picked up one more conflict @thelullabyy. |
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - All important comments addressed, tests well, hopefully no reverts this time.
|
@puneetlath can you review again and merge when you're next online? TY! |
|
In the meantime, @thelullabyy conflict. 👍 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.75-0 🚀
|
|
Yes — help site changes are required. Draft PR: #100752 Removing the What changed for usersAfter selecting Manual, you land straight on the expense details form. Amount is an inline field there alongside Merchant, Date, and Description, and the primary button reads Create expense. The separate amount screen with Next is gone. Articles updated
Alongside the flow change, the PR also fixes stale button labels: Create Expense → Create expense, Submit expense → Create expense, Submit → Create expense, and Split → Split expense. How the wording was verifiedLive UI (NewDot web)
Code
Checks run: One thing left openThis PR also ships the Merchant, Amount, and Date fields on the Scan tab confirmation screen — the subject of #93854. Those fields come from the same code path, but the browser session ended before I could walk that flow, so I changed no Scan-flow wording rather than guess at it. Tell me if you want it documented and I'll add it. @thelullabyy, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR view run · no recording available |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #93854
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-21.at.15.43.27.mov