Fix unresponsive LHN report tap after returning to Inbox from a Settings RHP

[fedirjh]

Explanation of Change

On narrow layouts, tapping an archived chat—or any report—in the LHN could fail to navigate. showReportPage treated a report matching Navigation.getTopmostReportId() or isActiveReport() as already open and blocked the navigation.

However, the LHN is displayed on the Inbox screen on narrow layouts, where no report is currently visible. getTopmostReportId() uses findLast(SCREEN.REPORT) to resolve a report from the reports split stack, so it can return a report left behind in that stack.

For example, this can happen after opening a report, navigating to a Settings RHP through the “add address” prompt, and returning to Inbox. The stale report was incorrectly considered active, making its LHN row appear unresponsive. The same report remained accessible through Search because Search follows a different navigation path.

The updated guard now behaves as follows:

• On narrow layouts, navigation is blocked only when the Inbox screen is not active, preserving protection against quick repeated taps while a report is transitioning.
• When the narrow-layout sidebar is focused on Inbox, tapping a report always navigates.
• On wide layouts, the existing behavior is preserved: tapping the currently open report remains blocked.

Because isActiveReport no longer affects this decision, the unused prop and its supporting callback were removed from SidebarLinks and SidebarLinksData. getTopmostReportId() itself remains unchanged because it has more than 20 other consumers.

Fixed Issues

$ #99731
PROPOSAL:

Tests

1. Log in to an Expensifail account.
2. Create a workspace and configure its address.
3. Enable distance rates.
4. In workspace settings, enable Exclude commutes and configure the office and home locations.
5. Invite User B to the workspace, then remove them.
6. On Android or iOS, log in as User B.
7. From Search, open the archived workspace chat.
8. Tap the address prompt.
9. Return to the LHN by tapping the Inbox tab.
10. Tap the archived chat row.
11. Verify the archived chat opens and the row is responsive.
12. Verify the archived chat can still be opened from Search.
13. Verify tapping different LHN rows opens the corresponding reports.

• Verify that no errors appear in the JS console

Offline tests

Same as tests — navigation behavior is client-side and unaffected by network state.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: Native

CleanShot.2026-09-02.at.13.17.13.mp4

[melvin-bot]

@FitseTLT @robertjchen @grgia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-02T13:26:50.879411Z	776f804	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[grgia]

NAB

[FitseTLT]

So you guys agree that this part of the expected behavior is not correct?

After removing user, concierge add address button must not be shown.

@fedirjh @Gonals

No worries Looks like you agreed on that on the thread.

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/inbox/sidebar/SidebarLinks.tsx	100.00% <100.00%> (+6.45%)	⬆️
src/pages/inbox/sidebar/SidebarLinksData.tsx	100.00% <100.00%> (ø)
... and 7 files with indirect coverage changes

[FitseTLT]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-09-03.19-44-04.mp4

Android: mWeb Chrome

2026-09-03.19-46-51.mp4

iOS: HybridApp

2026-09-03.20-49-38.mp4

iOS: mWeb Safari

2026-09-03.19-48-57.mp4

MacOS: Chrome / Safari

2026-09-03.19-39-34.mp4

[FitseTLT]

LGTM

[grgia]

@fedirjh

[github-actions]

🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100167.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8ae9c69-1c13481-ede698d26d774d5b43680dac00667730b94e8279/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8ae9c69-1c13481-ca9834eb2028ad74772a17a64f9edbcb8cea0f0f/index.html

Web 🕸️
https://100167.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.73-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[MelvinBot]

🤖 No help site changes are required for this PR, so I did not create a draft docs PR.

This is an internal navigation-guard fix. It changes nothing a help site article documents:

• No user-facing feature, label, or copy change. The diff only touches the showReportPage guard in src/pages/inbox/sidebar/SidebarLinks.tsx, removes the now-unused isActiveReport prop from src/pages/inbox/sidebar/SidebarLinksData.tsx, and adds tests/unit/SidebarLinksTest.tsx. No tab names, settings labels, buttons, or strings changed.
• It restores already-documented behavior rather than introducing new behavior. Selecting a chat in the Inbox tab is supposed to open that chat, and docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md already describes the Inbox tab and its All, Unread, and To-dos filters that way. The bug made a row appear unresponsive; the fix makes it match what the article already says.
• Nothing in docs/articles describes the broken state. I searched the articles for archived-chat and Inbox navigation coverage. The only archived-chat references are in Delete-a-Workspace.md and unrelated integration troubleshooting pages, and none document the tap behavior this PR changed. Per HELP_AUTHORING_GUIDELINES.md, help articles describe what a customer does and sees, not internal navigation-stack state, so there is no accurate place to add anything here.

Bug fixes that return the product to its documented behavior do not need a docs update. If you would still like an article change — for example a troubleshooting note about archived chats — tell me which article and I will open the draft PR.

@fedirjh, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

---

view run · view recording

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android