[No QA] Fix import/no-cycle - part 6

[LukasMod]

Explanation of Change

Move the expense-flow starters out of ReportUtils.

ReportUtils imported four action modules. Each import closed a cycle back into ReportUtils:

Changes:

• Moved the three functions and their GetAddExpenseDropdownOptionsParams / CreateDraftTransactionParams types into a new src/libs/actions/IOU/StartExpenseFlows.ts.
• Removed the four action-module imports from ReportUtils, plus the imports only those functions used.
• Updated 7 consumers and 4 test files to import from @userActions/IOU/StartExpenseFlows.

The new module imports ReportUtils. That is a one-way edge: nothing inside the cycle cluster imports StartExpenseFlows, so it is a sink and does not get reported.

Two things reviewers should look at

1. createDraftTransactionAndNavigateToParticipantSelector now reads the current user from its params everywhere.

In ReportUtils this function mixed two sources for the same values. It took currentUserAccountID and currentUserEmail as params and used them at three sites, but at seven other sites it read deprecatedCurrentUserAccountID and deprecatedCurrentUserEmail, the module-scope lets that ReportUtils mirrors from ONYXKEYS.SESSION via Onyx.connect. Those lets cannot be exported (import/no-mutable-exports):

The mix was an accident of history, not a design:

• refactor getTaskAssigneeChatOnyxData to use session data from useOnyx #85828 renamed the module vars to deprecated* as a "migrate to useOnyx" marker. No behavior change.
• Part 4: Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Policy/Policy.ts #87566 added the two params so createDraftWorkspace could stop reading the session itself. It replaced only the two reads on that call path and left the rest.
• refactor createDraftTransactionAndNavigateToParticipantSelector to use useOnyx data #93550 and [Submit] Update "Submit to someone" to two options to allow for Submit workspace creation #94319 added new branches later and copied the neighbouring deprecatedCurrentUserAccountID idiom, even though the param was already in scope.

2. One as Transaction assertion moved with the code.

In ReportUtils an eslint-seatbelt allowance covered it. In a new file it is a hard error, so it carries an eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion.

Effect on import/no-cycle

Measured with oxlint 1.80.0, import/no-cycle isolated.

Applied to	findings before	findings after	files in cycles before	files in cycles after
main alone	482	476	131	131
main + parts 1-5	330	279	89	80

On its own this removes 6 findings. Once parts 1-5 land it removes 51 findings and 9 files.

• npx jest ReportUtilsTest CreateDraftTransactionTest TrackExpenseTest AddExpenseActionButtonTest:

Fixed Issues

$ #99650
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Pure code move plus a change of where one function reads the current user's account ID and email. Test the flows that moved and are reachable.

Note: the "Categorize it" and "Share it with my accountant" whisper buttons are behind Permissions.canUseTrackFlows(), which currently returns false, so the CATEGORIZE and SHARE branches cannot be reached from the UI. They are covered by unit tests instead (9 direct calls in CreateDraftTransactionTest / TrackExpenseTest).

Test 1: Add expense dropdown

1. Sign in as a workspace member. Open the workspace chat and create an expense so an open expense report exists.
2. Open that expense report and press the "Add expense" dropdown.
3. Verify the options "Create expense", "Track distance" and "Add existing expense" are listed.
4. Pick "Create expense". Verify the amount step opens and the expense lands on the same report after confirming.
5. Go back to the report. Pick "Track distance". Verify the distance step opens.
6. Track an expense in your self DM first, then return to the report and pick "Add existing expense". Verify the unreported-expense picker opens and lists it.

Test 2: Track expense whisper

1. Open your self DM and create an expense there so it is tracked, not submitted.
2. Under the tracked expense, verify Concierge shows three buttons: "Submit to a friend", "Submit to my employer" and "Nothing for now".
3. Press "Submit to a friend". Verify the participant picker opens listing individuals and workspaces.
4. Go back. Press "Submit to my employer". With exactly one paid workspace: verify you land on the confirmation page with that workspace's expense chat as the report.
5. Press "Nothing for now" on another tracked expense. Verify the whisper is dismissed.

Test 3: Transaction header

1. Open the tracked expense's transaction thread. Press "More" in the header.
2. Verify "Send to someone" opens the participant picker and "Submit to my employer" behaves as in Test 2

Offline tests

QA Steps

• Verify that no errors appear in the JS console

Same as tests.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.native.mov

Android: mWeb Chrome

android.web.mov

iOS: Native

ios.native.mov

iOS: mWeb Safari

ios.web.mov

MacOS: Chrome / Safari

web-1.mov

web-2-3.mov

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../components/MoneyRequestHeaderSecondaryActions.tsx	0.45% <ø> (ø)
...stReportView/MoneyRequestReportTransactionList.tsx	0.28% <ø> (ø)
...neyRequestReportPreview/AddExpenseActionButton.tsx	100.00% <ø> (ø)
src/hooks/useExpenseActions.ts	66.19% <ø> (ø)
src/libs/ReportUtils.ts	87.18% <ø> (-0.06%)	⬇️
src/pages/DynamicReportDetailsPage.tsx	69.78% <ø> (ø)
...ox/report/actionContents/ChatActionableButtons.tsx	88.37% <ø> (ø)
...u/request/step/DynamicIOURequestStepAccountant.tsx	0.00% <ø> (ø)
src/libs/actions/IOU/StartExpenseFlows.ts	89.81% <89.81%> (ø)
... and 6 files with indirect coverage changes

[melvin-bot]

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[LukasMod]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 7900c7d54c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[LukasMod]

rebased from main

[thelullabyy]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-09-11.at.03.40.42.mov

[thelullabyy]

LGTM. 1 note can be done in next PRs, we can move functions UT in tests/unit/ReportUtilsTest.ts to new files since they are not existed in ReportUtils.ts anymore

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100164.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3f6cf8f-1bb335e-ae05264d5db938f09e0febdc81f2e44b0480d471/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3f6cf8f-1bb335e-636ae696199f9d41681b9401a3a561f89665bc17/index.html

Web 🕸️
https://100164.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.76-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 No help site changes are required for this PR. I did not create a docs PR.

This is a pure internal refactor. It moves three functions out of ReportUtils into a new module to break an import/no-cycle chain. Nothing a customer sees changes — no new feature, no renamed screen, no new setting, no copy change.

How I verified this

I diffed every added and removed line and matched them up. Every asymmetric line falls into one of three buckets:

1. Import path changes — for example from './actions/Report' → from '@userActions/Report', and 7 consumers plus 4 test files switching to src/libs/actions/IOU/StartExpenseFlows.ts.
2. Variable source change — deprecatedCurrentUserAccountID / deprecatedCurrentUserEmail → the currentUserAccountID / currentUserEmail params already in scope. Same values, different read site.
3. Comments and an eslint-disable for the as Transaction assertion that moved with the code.

The only user-facing strings in the diff are three translate() calls that moved verbatim:

• iou.createExpense → Create expense
• iou.trackDistance → Track distance
• iou.addExistingExpense → Add existing expense

Each appears once as a removed line and once as an added line, byte-identical. The Add expense dropdown options, the Track expense whisper buttons, and the transaction header More actions all render exactly as before.

The PR is also labeled [No QA], which matches this reading.

@LukasMod, please confirm you agree that no help site update is needed here. If you think a docs change is warranted after all, reply with @MelvinBot and what should be documented, and I'll open the draft PR.

---

view run · no recording available

[LukasMod]

agree that no help site update is needed here

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.76-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android