[No QA] Docs updates for E/A#99644 document locked cash expense default on splits - #100109
Conversation
Co-authored-by: truph01 <truph01@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://174938ef.helpdot.pages.dev ⚡️ Updated articles: |
|
@MelvinBot Mark this PR as ready |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @lschurr |
|
@hoangzinh @truph01 @lschurr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🤖 Done — this PR is now Ready for review. Checks: all green. The only failure is One thing left for you: the |
HelpDot Documentation ReviewOverall AssessmentThis PR is a focused, well-scoped help-site follow-up to E/A#99644. It documents that the Cash expense default rule can lock a cash expense's reimbursable value and that, when locked, the Reimbursable toggle disappears on the expense and on every split created from it. The change touches two files with a total of 7 additions and 3 deletions: an expanded bullet in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f505e2a1fd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site follow-up for #99644, which forces a split's
reimbursablevalue to the workspace default when the Cash expense default rule locks the field.The help site didn't describe this behavior.
Workspace-Rules.mdonly said the rule lets you "choose whether cash expenses are reimbursable by default", which doesn't distinguish the two selectable defaults from the two fixed Always modes, andSplit-Expenses.mdsaid nothing about the Reimbursable toggle disappearing on splits. That gap is what makes the (now correct) behavior look like a bug to members.Two targeted edits:
docs/articles/new-expensify/workspaces/Workspace-Rules.md— expanded the Cash expense default bullet to name all four options (Reimbursable, Non-reimbursable, Always reimbursable, Always non-reimbursable), define what counts as a cash expense, and state that an Always option fixes the value and hides the Reimbursable toggle on the expense and on every split created from it.docs/articles/new-expensify/reports-and-expenses/Split-Expenses.md— added an FAQ entry,## Why don’t I see the Reimbursable toggle on a split?, covering both the locked-rule case and imported company card expenses, which are always non-reimbursable.Keywords in both files were extended so the new content is retrievable.
All labels were verified against the live UI on web before writing: the setting is Cash expense default; its four options are Reimbursable, Non-reimbursable, Always reimbursable, and Always non-reimbursable; the split entry point is Split under More; and the toggle label is Reimbursable. With Always non-reimbursable selected, a split row showed only Description, Category, Date, and Report — no Reimbursable field. With Reimbursable selected, the toggle was present on the split row.
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: UI labels are bold and use exact UI casing, the new heading is a question-word FAQ heading at##, and the cross-link uses a relative URL with descriptive anchor text.UI verification screenshots
Cash expense default options:
Split row with Always non-reimbursable selected — no Reimbursable field:
Split row with Reimbursable selected — Reimbursable toggle present:
Fixed Issues
$ #99140
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Documentation-only change — no app code is touched. Review the rendered Markdown and confirm the described behavior matches the current product.
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests before marking this PR as "ready for review", or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.