Conversation
Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #98600, which changed the company card add-feed gate from "any copilot" to "limited/submitter copilots only". A Full Access copilot can now open the add-new-feed flow (direct feed, commercial feed, and spreadsheet/BYOC import); a Limited Access copilot still gets the no-access view.
The help site never mentioned copilots on the feed-setup articles, so it read as admin-only. This adds the copilot access rule to each "Who can…" section and answers the question once in the copilot article.
Files changed
docs/articles/new-expensify/connect-credit-cards/Set-up-a-Direct-Company-Card-Feed-Connection.md— added the copilot access rule to "Who can set up a direct company card feed connection", plus copilot keywords andinternalScopeaudience.docs/articles/new-expensify/connect-credit-cards/Set-up-a-Commercial-Card-Feed-Connection.md— same change for "Who can set up a commercial card feed connection".docs/articles/new-expensify/connect-credit-cards/Import-Company-Card-Transactions-From-a-Spreadsheet.md— same change for "Who can import company card transactions from a spreadsheet". Also corrected UI labels to match the product: Company Cards → Company cards and Add card / Add Card → Add cards.docs/articles/new-expensify/settings/Act-as-a-Copilot.md— new FAQ entry: "Can I add a company card feed as a Copilot?"How UI labels were verified
The live-UI check could not run — the handed-off browser session never got past the splash screen, so sign-in was impossible. Labels were taken from
src/languages/en.tsonmaininstead:workspace.companyCards.addCardsisAdd cardsandworkspace.moreFeatures.companyCards.titleisCompany cards. Access levels render asFull/Limitedindelegate.role; the articles use the existing help site wording Full Access / Limited Access for consistency withAct-as-a-CopilotandManage-Copilot-Access.Note: #98600 lifts only the client-side gate. If the backend does not yet permit a full-access copilot's add-feed call, these articles will overstate what works — please confirm before marking this ready for review.
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md.npm run spell-changedpasses on all four files.Fixed Issues
$ #98328
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests before marking this PR "ready for review". This is a docs-only change, so verification means confirming the described behavior matches the product: a Full Access copilot can complete the add-new-feed flow (direct, commercial, and spreadsheet import) end to end, and a Limited Access copilot still sees the no-access message after selecting Add cards.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR "ready for review", or add "[No QA]" to the title since this changes help site content only.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@shubham1206agra, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.