Skip to content

Docs updates for E/A#98600 full-access copilots can add card feeds - #100095

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsCopilotAddCardFeed
Draft

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsCopilotAddCardFeed

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to #98600, which changed the company card add-feed gate from "any copilot" to "limited/submitter copilots only". A Full Access copilot can now open the add-new-feed flow (direct feed, commercial feed, and spreadsheet/BYOC import); a Limited Access copilot still gets the no-access view.

The help site never mentioned copilots on the feed-setup articles, so it read as admin-only. This adds the copilot access rule to each "Who can…" section and answers the question once in the copilot article.

Files changed

  • docs/articles/new-expensify/connect-credit-cards/Set-up-a-Direct-Company-Card-Feed-Connection.md — added the copilot access rule to "Who can set up a direct company card feed connection", plus copilot keywords and internalScope audience.
  • docs/articles/new-expensify/connect-credit-cards/Set-up-a-Commercial-Card-Feed-Connection.md — same change for "Who can set up a commercial card feed connection".
  • docs/articles/new-expensify/connect-credit-cards/Import-Company-Card-Transactions-From-a-Spreadsheet.md — same change for "Who can import company card transactions from a spreadsheet". Also corrected UI labels to match the product: Company CardsCompany cards and Add card / Add CardAdd cards.
  • docs/articles/new-expensify/settings/Act-as-a-Copilot.md — new FAQ entry: "Can I add a company card feed as a Copilot?"

How UI labels were verified

The live-UI check could not run — the handed-off browser session never got past the splash screen, so sign-in was impossible. Labels were taken from src/languages/en.ts on main instead: workspace.companyCards.addCards is Add cards and workspace.moreFeatures.companyCards.title is Company cards. Access levels render as Full / Limited in delegate.role; the articles use the existing help site wording Full Access / Limited Access for consistency with Act-as-a-Copilot and Manage-Copilot-Access.

Note: #98600 lifts only the client-side gate. If the backend does not yet permit a full-access copilot's add-feed call, these articles will overstate what works — please confirm before marking this ready for review.

Written against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. npm run spell-changed passes on all four files.

Fixed Issues

$ #98328
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests before marking this PR "ready for review". This is a docs-only change, so verification means confirming the described behavior matches the product: a Full Access copilot can complete the add-new-feed flow (direct, commercial, and spreadsheet import) end to end, and a Limited Access copilot still sees the no-access message after selecting Add cards.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR "ready for review", or add "[No QA]" to the title since this changes help site content only.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@shubham1206agra, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 2, 2026 00:45
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants