Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This was referenced Sep 1, 2026
…compose/money-request-report-transactions-a4 # Conflicts: # src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx
40 tasks
This was referenced Sep 15, 2026
…compose/money-request-report-transactions-a4 # Conflicts: # src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx
…compose/money-request-report-transactions-a4
…compose/money-request-report-transactions-a4
sosek108
marked this pull request as ready for review
September 18, 2026 07:13
melvin-bot
Bot
requested review from
dylanexpensify and
suneox
and removed request for
a team
September 18, 2026 07:13
dylanexpensify
left a comment
Contributor
There was a problem hiding this comment.
Performance, no product input needed
Contributor
|
I'll take a look at this PR shortly. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppCleanShot.2026-09-21.at.22.49.29.2.mp4Android: mWeb ChromeCleanShot.2026-09-21.at.22.59.24.4.mp4iOS: HybridAppCleanShot.2026-09-21.at.22.57.05.3.mp4iOS: mWeb SafariCleanShot.2026-09-21.at.23.00.37.5.mp4MacOS: Chrome / SafariCleanShot.2026-09-21.at.18.07.05.1.mp4 |
Contributor
|
No regression found for the current change set, scroll behavior still matches latest main. However, there is an existing bug where the scroll-to-bottom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This is PR 5 of a 10-PR stack decomposing the MoneyRequestReport list components (
MoneyRequestReportActionsList/MoneyRequestReportTransactionList) into focused hooks and presentational sub-components (issue #99919, superseding drafts #99307 and #99417).Performance

Mount scenario is a real win - distributions don't even overlap (previous branch min 25.0 > this branch max 24.9)
Zero render-count change.
Fixed Issues
$ #99919
PROPOSAL:
Tests
npx jest tests/ui/MoneyRequestReportActionsListRejectModalTest.tsxand verify it passesOffline tests
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Nagranie.z.ekranu.2026-09-16.o.12.05.13.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-16.o.11.42.42.mov