Skip to content

R1: Handle Recruiting loading, errors, sync results, and offline behavior #99515

Closed

Description

@yuwenmemon

Parent: #637628
Design doc: https://docs.google.com/document/d/1a-CNZhDMXqLSBw33k6IfJKhw4GfdK0_QB9Fxq5WFefw/edit?usp=sharing

Scope

Handle the Recruiting page's non-happy paths: sync results, authentication errors, the manual-sync limit, and offline behavior. Add the English and Spanish translation keys.

Implementation notes (from design doc)

Generalize HRSyncResultsModal.tsx and its types. Add a new prop to differentiate between HR and ATS, so it can render "candidates" instead of "employees".

Display added, removed, and skipped results after each foreground sync. Include the skip reason where available.

Show a Reconnect action when Merge reports an authentication error.

Disable "Sync now" after the second successful manual-sync request in the rolling 24-hour period. Show the existing sync-limit message with Recruiting-specific copy.

While offline:

  • Continue rendering cached connection settings.
  • Show the standard offline indicator.
  • Disable Connect, Reconnect, Sync now, Disconnect, and connection-setting saves.
  • Do not open Merge Link.
  • Resume OpenPolicyRecruitingPage when connectivity returns.

Add English and Spanish translation keys. Let the normal translation process handle the remaining locales.

Issue OwnerCurrent Issue Owner: @bernhardoj

Activity

  1. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  2. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    @DylanDylann Huh... This is 4 days overdue. Who can take care of this?

  3. DylanDylann commented on Sep 1, 2026

    @DylanDylann
    Contributor

    Not overdue

  4. 10 remaining items

  5. bernhardoj commented on Sep 16, 2026

    @bernhardoj
    Contributor

    Opened the PR in the meantime

  6. yuwenmemon commented on Sep 16, 2026

    @yuwenmemon
    ContributorAuthor

    @bernhardoj whichever is easier. We don't need to fix HR as part of this project but we can always file follow-ups for issues we find.

  7. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    @bernhardoj / @DylanDylann

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.92-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    Contributor+ Checklist: The following checklist (instructions) needs to be completed before this issue can be closed:

    • [@bernhardoj / @DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

    If no checklist is needed for this issue, use the K2 [no checklist button].

  8. DylanDylann commented on Sep 28, 2026

    @DylanDylann
    Contributor

    Done

  9. melvin-bot commented on Sep 29, 2026

    @melvin-bot

    @bernhardoj Huh... This is 4 days overdue. Who can take care of this?

  10. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    @bernhardoj 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  11. ishpaul777 commented on Oct 5, 2026

    @ishpaul777
    Contributor

    looks like this is done, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringNewFeatureSomething to build that is a new item.Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions