Repository navigation
Tags - No change log in #admins after enabling "Show GL codes when selecting a tag" #98613
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.4.53-5
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #97094
Email or phone of affected tester (no customers): sdsiodjnosdjiodsj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
- Create a Control workspace.
- Enable Tags.
- Go to staging.new.expensify.com
- Go to workspace settings > Tags.
- Click More > Settings.
- Enable "Show GL codes when selecting a tag".
- Go to #admins.
- Open system message thread.
Expected Result:
There will be a change log in #admins after enabling "Show GL codes when selecting a tag".
Actual Result:
There is no change log in #admins after enabling "Show GL codes when selecting a tag".
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7232874_1786642125626.17.mp4
Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7232874
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
applause-bot commentedon Aug 13, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/8c59b39bd702ae1b9180007d0dc711115bfc908e20d42a8b77fa3f97d31fb6e2
melvin-bot commentedon Aug 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #97094
melvin-bot commentedon Aug 13, 2026
@blimpich @DylanDylann you have been assigned to this deploy blocker because you reviewed the offending PR: #97094
melvin-bot commentedon Aug 13, 2026
💬 A slack conversation has been started in #expensify-open-source
blimpich commentedon Aug 13, 2026
I don't think this is a deploy blocker. Too minor. @neerajbachani @DylanDylann do you mind putting up a follow up PR for this?
blimpich commentedon Aug 13, 2026
Well actually this probably needs a backend change doesn't it?
github-actions commentedon Aug 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 13, 2026
Current assignee @blimpich is eligible for the Engineering assigner, not assigning anyone new.
MelvinBot commentedon Aug 13, 2026
🔍 Investigation Summary
Classification: Backend bug
Causing PR: #97094 - "Add tag GL code display in tag picker" by @neerajbachani (High confidence this is the PR that introduced the feature; the missing change log itself is a backend gap)
Related Issues: #96390 (feature request implemented by the PR)
Recommendation: DEMOTE
The "Show GL codes when selecting a tag" toggle itself works and persists; the only gap is that the workspace change log (system message) in #admins is not written when the setting is toggled. That change log has to be emitted by the backend policy-update command, so it cannot be fixed in App. This is a minor, audit-trail-only gap on a brand-new feature (not core functionality), and the reviewing engineer already flagged it as too minor to block the deploy — best handled as a backend follow-up rather than reverting a working feature.
Assigned: @neerajbachani (PR author), @DylanDylann and @blimpich (approving reviewers) from PR #97094
Labels: No
DeployBlockerCash/DeployBlockerlabel is currently applied to this issue, so no label change was made. Recommending demotion so this does not block the deploy.📋 Detailed Analysis
Evidence
Verification
WorkspaceTagsSettingsPageand thesetPolicyShowTagGLCodesaction insrc/libs/actions/Policy/Tag.ts(confirmed in the PR's file list and diff).showTagGLCodespolicy flag pluspendingFields/errorFields(optimistic / success / failure data). It does not create any optimistic report action or system message in the #admins report — which is consistent with how App handles other policy toggles. Workspace policy change logs are generated server-side when the policy-update command is processed.Root Cause
Workspace change-log / system messages for policy setting changes are produced by the backend when the corresponding policy-update command runs, not by App. The new setting's backend command persists the flag but does not emit the change-log report action for this field, so nothing appears in #admins. Emitting that system message requires a backend/internal change outside the App repo; a separate internal investigation/follow-up is needed to add it. No App-side change would resolve the missing change log, and the App feature works, so a revert is not warranted.
neerajbachani commentedon Aug 14, 2026
@blimpich I beleive, we need a backend change to fix this.
blimpich commentedon Aug 14, 2026
I don't even know if this is worth doing honestly. Seems so minor. I'll wait to hear @flaviadefaria's take next week before moving forward here.
flaviadefaria commentedon Aug 17, 2026
We don't currently log in #admins when an admin enables/disables "Members must categorize all expenses," and I think this would be a similar action, so I believe it's fine not to have this post in #admins.
blimpich commentedon Aug 17, 2026
Sounds good! I agree that makes the most sense. Closing