Skip to content

[Due for payment 2026-09-02] Distance - Original and Removed commuter distance shows new exclusion instead of edited distance #98257

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.52-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93848
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Enable Distance rates.
  • Enable "Exclude a fixed distance per claim" in distance settings with 1 miles.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a map distance expense.
  4. Go to workspace settings > Distance rates.
  5. Click Settings > Exclude commutes.
  6. Edit Exclude a fixed distance per claim" to 20 miles (the distance should be larger than the created distance expense in Step 3).
  7. Go back to workspace chat and open the expense.
  8. Click Distance.
  9. Edit distance and save it.

Expected Result:

Original and Removed commuter distance should show the correct edited distance.

Actual Result:

Original and Removed commuter distance shows the new exclusion instead of the correct edited distance.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7230734_1786424280355.24.mp4
Image

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7230734

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 11, 2026
  2. melvin-bot commented on Aug 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #93848

  3. melvin-bot commented on Aug 11, 2026

    @melvin-bot

    @Gonals @marufsharifi you have been assigned to this deploy blocker because you reviewed the offending PR: #93848

  4. melvin-bot commented on Aug 11, 2026

    @melvin-bot

    @fedirjh you have been assigned to this deploy blocker because you authored the offending PR: #93848

  5. melvin-bot commented on Aug 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Aug 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. changed the title [-]Distance-Original and Removed commuter distance shows new exclusion instead of edited distance[/-] [+]Distance - Original and Removed commuter distance shows new exclusion instead of edited distance[/+] on Aug 11, 2026
  8. 20 remaining items

  9. marufsharifi commented on Aug 31, 2026

    @marufsharifi
    Contributor

    Regarding the linked regression PR, I don’t think that should affect this, since this scenario wasn’t discussed or clearly defined during testing. Thanks for understanding.

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 1, 2026
  11. melvin-bot commented on Sep 1, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. melvin-bot commented on Sep 1, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  13. mallenexpensify commented on Sep 1, 2026

    @mallenexpensify
    Contributor

    Regarding the linked regression PR, I don’t think that should affect this, since this scenario wasn’t discussed or clearly defined during testing. Thanks for understanding.

    @Gonals can you help confirm if this is a regression or not? The framework below might help

    A followup is not a regression. Ask one question: if the followup work is never done, is the original issue still correctly closed?

    • If yes, it is a followup, and the merged PR delivered what the issue asked for.
    • If no, it is a regression.
  14. mallenexpensify commented on Sep 1, 2026

    @mallenexpensify
    Contributor

    No payment is due on this issue. It's a regression from #93848, which @marufsharifi reviewed.

    Regression issues that spawned from the project's PRs are closed with no payment. The amount for the project as a whole gets discussed and settled on the parent issue, https://github.com/Expensify/Expensify/issues/642599, once everything has been on production for a week. @Gonals agreed to this approach on #98248.

    @marufsharifi on your point that this scenario wasn't discussed or clearly defined during testing, that describes the test coverage, not the scope. A scenario nobody thought to test is the usual way a regression reaches production. Either way, payment for this work settles on the parent, not here.

  15. mallenexpensify commented on Sep 1, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    Correction to the comment above. The parent issue is in the Expensify/Expensify repo, which external contributors can't access. Payment for this project's regression set will be discussed and settled on #100085 instead.

  16. marufsharifi commented on Sep 2, 2026

    @marufsharifi
    Contributor

    @mallenexpensify, @Gonals, I think we can close this now, since the PR has been in production since last week. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions