You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-02] Distance - Original and Removed commuter distance shows new exclusion instead of edited distance #98257
Version Number: 9.4.52-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#93848 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Enable Distance rates.
Enable "Exclude a fixed distance per claim" in distance settings with 1 miles.
Go to staging.new.expensify.com
Go to workspace chat.
Create a map distance expense.
Go to workspace settings > Distance rates.
Click Settings > Exclude commutes.
Edit Exclude a fixed distance per claim" to 20 miles (the distance should be larger than the created distance expense in Step 3).
Go back to workspace chat and open the expense.
Click Distance.
Edit distance and save it.
Expected Result:
Original and Removed commuter distance should show the correct edited distance.
Actual Result:
Original and Removed commuter distance shows the new exclusion instead of the correct edited distance.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Distance-Original and Removed commuter distance shows new exclusion instead of edited distance[/-][+]Distance - Original and Removed commuter distance shows new exclusion instead of edited distance[/+]on Aug 11, 2026
Regarding the linked regression PR, I don’t think that should affect this, since this scenario wasn’t discussed or clearly defined during testing. Thanks for understanding.
Regarding the linked regression PR, I don’t think that should affect this, since this scenario wasn’t discussed or clearly defined during testing. Thanks for understanding.
@Gonals can you help confirm if this is a regression or not? The framework below might help
A followup is not a regression. Ask one question: if the followup work is never done, is the original issue still correctly closed?
If yes, it is a followup, and the merged PR delivered what the issue asked for.
No payment is due on this issue. It's a regression from #93848, which @marufsharifi reviewed.
Regression issues that spawned from the project's PRs are closed with no payment. The amount for the project as a whole gets discussed and settled on the parent issue, https://github.com/Expensify/Expensify/issues/642599, once everything has been on production for a week. @Gonals agreed to this approach on #98248.
@marufsharifi on your point that this scenario wasn't discussed or clearly defined during testing, that describes the test coverage, not the scope. A scenario nobody thought to test is the usual way a regression reaches production. Either way, payment for this work settles on the parent, not here.
Correction to the comment above. The parent issue is in the Expensify/Expensify repo, which external contributors can't access. Payment for this project's regression set will be discussed and settled on #100085 instead.
Activity
applause-bot commentedon Aug 11, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/1e52637b9e86f98c9d2554f7338783994fb1c75cb3e3fb38e1e3d9a8a51d8749
https://platform.applause.com/services/links/v1/external/e557d709722f29db71336126ef86601a0dfb20550e4ef48757c3715365484c7f
melvin-bot commentedon Aug 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #93848
melvin-bot commentedon Aug 11, 2026
@Gonals @marufsharifi you have been assigned to this deploy blocker because you reviewed the offending PR: #93848
melvin-bot commentedon Aug 11, 2026
@fedirjh you have been assigned to this deploy blocker because you authored the offending PR: #93848
melvin-bot commentedon Aug 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Distance-Original and Removed commuter distance shows new exclusion instead of edited distance[/-][+]Distance - Original and Removed commuter distance shows new exclusion instead of edited distance[/+]20 remaining items
marufsharifi commentedon Aug 31, 2026
Regarding the linked regression PR, I don’t think that should affect this, since this scenario wasn’t discussed or clearly defined during testing. Thanks for understanding.
melvin-bot commentedon Sep 1, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Sep 1, 2026
Payment Summary
Resolving PRs:
[Commuter Mileage Exclusion] [R1] Preserve commuter exclusion on distance edits #98273
Contributor: @fedirjh does not require payment (Contractor)
Assignee: @marufsharifi requires payment (Needs manual offer from BZ)
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Sep 1, 2026
@Gonals can you help confirm if this is a regression or not? The framework below might help
mallenexpensify commentedon Sep 1, 2026
No payment is due on this issue. It's a regression from #93848, which @marufsharifi reviewed.
Regression issues that spawned from the project's PRs are closed with no payment. The amount for the project as a whole gets discussed and settled on the parent issue, https://github.com/Expensify/Expensify/issues/642599, once everything has been on production for a week. @Gonals agreed to this approach on #98248.
@marufsharifi on your point that this scenario wasn't discussed or clearly defined during testing, that describes the test coverage, not the scope. A scenario nobody thought to test is the usual way a regression reaches production. Either way, payment for this work settles on the parent, not here.
mallenexpensify commentedon Sep 1, 2026
Claude posting on behalf of Matt:
Correction to the comment above. The parent issue is in the Expensify/Expensify repo, which external contributors can't access. Payment for this project's regression set will be discussed and settled on #100085 instead.
marufsharifi commentedon Sep 2, 2026
@mallenexpensify, @Gonals, I think we can close this now, since the PR has been in production since last week. Thanks!