[Due for payment 2026-08-21] Distance - Missing Original amount and Removed commuter miles when submitted from self DM

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: 9.4.52-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93848
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.
• Enable Distance rates.
• Enable "Exclude a fixed distance per claim" in distance settings with 1 miles.

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Open FAB > Track distance > Manual.
4. Enter amount > Next.
   → On confirm page, Distance field does not show Original amount and Removed commuter miles.
5. Create the expense.
6. Open the expense.
   → Distance field shows Original amount and Removed commuter miles.

Expected Result:

In Step 4, on confirm page, Distance field should show Original amount and Removed commuter miles (it shows the data in expense details page in Step 6).

Actual Result:

In Step 4, on confirm page, Distance field does not show Original amount and Removed commuter miles.
In Step 6, on expense details page, Distance field shows Original amount and Removed commuter miles.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7230585_1786404901681.17.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7230585

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #93848

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/b6d9779cd41b035302bb4511b1e1c113a8a6b7dac4c3e4be98bd312a64057fd9

[melvin-bot]

@Gonals @marufsharifi you have been assigned to this deploy blocker because you reviewed the offending PR: #93848

[melvin-bot]

@fedirjh you have been assigned to this deploy blocker because you authored the offending PR: #93848

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

🔍 Deploy Blocker Analysis

Causing PR: #93848 (Commuter Mileage Exclusion) — confirmed, high confidence. The auto-assignment is correct.

Root cause: The confirm page and the expense-details page render the Distance row from the same field (transaction.comment.customUnit.commuterExclusion), but populate it differently:

• Details page reads the value the backend wrote onto the created transaction → breakdown shows.
• Confirm page relies on optimistic client computation in getTransactionCommuterExclusionData, which returns early and computes nothing for this repro, so the row stays plain.

It returns early on two independent grounds for the self-DM + manual flow:

1. The request type is DISTANCE_MANUAL (repro uses Track distance > Manual), and
2. On a self DM the resolved policy is the personal policy, which has no commuterExclusions.

Either condition alone suppresses the optimistic breakdown. The backend applies the exclusion regardless, producing the confirm-vs-details mismatch. Self DM is the gap: manual distance from self DM passes the commuter-exclusion guard modal (personal policy has no exclusions, so it isn't blocked) and gets created anyway.

Recommendation: targeted fix, NOT revert. #93848 is a ~60-file feature with an already-deployed Web-Expensify counterpart — reverting would rip out the whole shipped feature. The created expense is correct (backend value is right); only the confirm-page preview is missing the breakdown, and only in this not-in-prod flow.

The correct fix depends on the intended contract, which fedirjh + backend should confirm:

• If commuter exclusion should NOT apply to manually-entered distance (matches App's own design — the blocking modal + the DISTANCE_MANUAL guard): the App confirm page is already right; the fix belongs in the backend (stop applying the exclusion to manual/odometer self-DM expenses), and the details page is the surprising one.
• If it SHOULD apply to self-DM manual distance: the fix is in App but is not a one-liner — relaxing the DISTANCE_MANUAL guard at DistanceRequestUtils.ts:359 alone won't work, because the self-DM confirm page resolves the personal policy (no commuterExclusions) and so also trips condition 2 at line 361. A real fix must resolve the effective exclusion policy for the self-DM track flow before the preview can predict the server value.

Code path & evidence

• Confirm-page render: DistanceField.tsx:53-56 — reads customUnit off the draft transaction.
• Details-page render: MoneyRequestView.tsx:614-618 — reads customUnit off the created (server-populated) transaction.
• Optimistic seed path: DistanceRequestController.tsx:250-261 → setMoneyRequestCommuterExclusionFields in MoneyRequest.ts:803-837 → the early-return guard in DistanceRequestUtils.ts:357-364.
• PR [Payment due @marufsharifi] [Commuter Mileage Exclusion] [R1] Display and enforce fixed distance exclusions #93848's diff adds all four load-bearing pieces (details-page path, getCommuterExclusionDisplayData, getTransactionCommuterExclusionData, and the DISTANCE_MANUAL guard) as new additions. Reproduces staging-only (new feature) — consistent with a [Payment due @marufsharifi] [Commuter Mileage Exclusion] [R1] Display and enforce fixed distance exclusions #93848 regression.

---

Next Steps for Contributor+ team:
fedirjh — can you confirm the intended contract (should commuter exclusion apply to self-DM manual/odometer distance)? That decides whether the fix lands in App or in the backend.
To implement (only if App-side is confirmed): @MelvinBot implement this
To refine: @MelvinBot <your feedback>