[Due for payment 2026-07-23] AI promo modal - Next button loads infinitely after clicking Next button

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.34-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92498
Email or phone of affected tester (no customers): jsdijionsdiojisoisoj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with new account.
3. Refresh the page.
4. Click Next button on Concierge AI promo modal.

Expected Result:

Next button will not load infinitely after clicking Next button.

Actual Result:

Next button loads infinitely after clicking Next button.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7207961_1784029122261.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7207961

Issue Owner

Current Issue Owner: @OlGierd03

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/6aab0f5ccb5621033a8baad6c55c618906fdc88adda8f02999b79cf0f48fd245

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #92498

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Root Cause

Regression from #92498, which added an "instant spinner" to FormAlertWithSubmitButton and made it on by default via shouldShowLoadingImmediatelyOnPress = true (FormAlertWithSubmitButton.tsx:120).

The AI Features promo modal is a carousel. Its Next button reuses that same FormAlertWithSubmitButton in FeatureTrainingContentBody.tsx:111-117 — with no isLoading prop and no opt-out. Pressing Next on a non-final page runs confirmPage → advanceCarousel(), which only scrolls the carousel to the next page (FeatureTrainingCarousel.tsx:127-133). That is a state-only change.

The instant spinner is designed to hand off to a real loading state, but neither reset path can ever fire here:

• The declarative handoff if (isPressed && isLoading) setIsPressed(false) never triggers because no isLoading is passed → it's always false.
• The useFocusEffect reset never fires because advancing the carousel is inside a modal — the navigation screen never loses/regains focus.

So isPressed stays true and the Next button spins forever. See usePressLoading.ts:27-58. This is exactly the "consumers who make early returns via onSubmit with state-only change" case the PR intended to exclude but missed for this button.

Proposed Fix

Opt this button out of the instant spinner, since its action either advances the carousel (state-only) or navigates back — neither drives a loading state.

In FeatureTrainingContentBody.tsx:111:

<FormAlertWithSubmitButton
    onSubmit={() => onConfirm?.(willShowAgain)}
    buttonText={confirmText}
    enabledWhenOffline
    shouldShowLoadingImmediatelyOnPress={false}
    sentryLabel={confirmSentryLabel}
    containerStyles={styles.flex1}
/>

Why this is the right scope

This button is shared by every FeatureTrainingModal / FeatureTrainingContent / carousel consumer (feature onboarding modals, AIFeaturesPromoModal, etc.). None of them drive an Onyx isLoading into it, and it lives inside a modal where useFocusEffect won't reset the flag — so the instant spinner can never safely clear for any of them. The final "Get started" page happens to not exhibit the bug only because it calls Navigation.goBack() and unmounts the modal; every intermediate Next press is stuck.

Alternatively, reverting #92498 would clear this deploy blocker, but the targeted opt-out above is the minimal fix.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/96055) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[OlGierd03]

Looking into it

[OlGierd03]

@MelvinBot implement this