Sub-issue of #94595.
Source plan: fabioh8010 comment.
Goal
Remove the deprecated 3rd dependencies argument from Navigation, Wallet, Travel, and Debug components.
Scope (8 files)
Navigation/NavigationTabBar/InboxTabButton
Navigation/QuickCreationActionsBar/index
inbox/sidebar/FABPopoverContent/menuItems/CreateReportMenuItem (USECALLBACK)
settings/Wallet/ExpensifyCardPage/index
Travel/TripDetailsPage (RESTRUCTURE)
Debug/Report/DebugReportActions
Debug/Report/DebugReportPage
Debug/ReportAction/DebugReportActionPage
Change types
RESTRUCTURE (TripDetailsPage); USECALLBACK (CreateReportMenuItem).
Dependencies
Blocked by PR 1 (ESLint guard) merged.
Tests / QA
Bottom-tab Inbox button (unread state), FAB create-report menu, Expensify Card page, Trip details (RESTRUCTURE — verify traveler details), Debug report/report-action pages.
Acceptance criteria
npm run fmt on changed files
npm run lint-changed — seatbelt count for rulesdir/no-useonyx-dependencies-arg must drop (never increase)
npm run typecheck stays green
npm run react-compiler-compliance-check check <files> — USECALLBACK/bailout files must not gain new failures vs main
- Relevant
npm run test for touched areas
- Manual smoke test per batch QA steps — no stale data, infinite re-renders, or JS console errors
Issue Owner
Current Issue Owner: @hoangzinh
Sub-issue of #94595.
Source plan: fabioh8010 comment.
Goal
Remove the deprecated 3rd
dependenciesargument from Navigation, Wallet, Travel, and Debug components.Scope (8 files)
Navigation/NavigationTabBar/InboxTabButtonNavigation/QuickCreationActionsBar/indexinbox/sidebar/FABPopoverContent/menuItems/CreateReportMenuItem(USECALLBACK)settings/Wallet/ExpensifyCardPage/indexTravel/TripDetailsPage(RESTRUCTURE)Debug/Report/DebugReportActionsDebug/Report/DebugReportPageDebug/ReportAction/DebugReportActionPageChange types
RESTRUCTURE (
TripDetailsPage); USECALLBACK (CreateReportMenuItem).Dependencies
Blocked by PR 1 (ESLint guard) merged.
Tests / QA
Bottom-tab Inbox button (unread state), FAB create-report menu, Expensify Card page, Trip details (RESTRUCTURE — verify traveler details), Debug report/report-action pages.
Acceptance criteria
npm run fmton changed filesnpm run lint-changed— seatbelt count forrulesdir/no-useonyx-dependencies-argmust drop (never increase)npm run typecheckstays greennpm run react-compiler-compliance-check check <files>— USECALLBACK/bailout files must not gain new failures vsmainnpm run testfor touched areasIssue Owner
Current Issue Owner: @hoangzinh