Skip to content

[Due for payment 2026-07-30] [Split #94595] Batch D - Remove useOnyx deps from MR headers and preview #95577

Description

@mountiny

Sub-issue of #94595.
Source plan: fabioh8010 comment.

Goal

Remove the deprecated 3rd dependencies argument from Money Request headers, preview, and primary actions.

Scope (9 files)

  • MoneyReportHeaderActions/MoneyReportHeaderSecondaryActions
  • MoneyReportHeaderActions/MoneyReportHeaderSelectionDropdown
  • MoneyReportHeaderPrimaryAction/SubmitPrimaryAction
  • ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewProvider
  • ReportActionItem/MoneyRequestReportPreview/ReportPreviewActionButton
  • ReportActionItem/MoneyRequestReportPreview/SubmitActionButton
  • hooks/useLifecycleActions
  • pages/ReportSubmitToContent
  • TransactionItemRow/DataCells/ChatBubbleCell

Dependencies

Blocked by PR 1 (ESLint guard) merged.

Tests / QA

Open an IOU/expense report; verify Pay/Approve/Submit dropdowns and KYC gating; report preview card in chat; submit primary action; chat-bubble cell in transaction rows.

Acceptance criteria

  1. npm run fmt on changed files
  2. npm run lint-changed — seatbelt count for rulesdir/no-useonyx-dependencies-arg must drop (never increase)
  3. npm run typecheck stays green
  4. npm run react-compiler-compliance-check check <files> — USECALLBACK/bailout files must not gain new failures vs main
  5. Relevant npm run test for touched areas
  6. Manual smoke test per batch QA steps — no stale data, infinite re-renders, or JS console errors
Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions