Repository navigation
[Due for payment 2026-07-16] [Sentry: APP-H08] Crash toggling Sage Intacct default vendor when vendors list is empty #95342
Description
Sentry
https://expensify.sentry.io/issues/APP-H08
Impact (snapshot at filing)
- Users (total since first seen): 1
- Events: 3
- Users (last 14d): 1
- First seen: 2026-07-03
- Last seen: 2026-07-03 (ongoing)
- Platform: web
- App version(s): 9.4.25-2
- Affected route(s) (parameterized): /workspaces/:policyID/accounting/sage-intacct/export/reimbursable
- Mechanism: auto.browser.browserapierrors.requestAnimationFrame
Stack trace (top frames, first-party only)
Switch.tsx:75 (<anonymous>) → onToggle(!isOn)
ToggleSettingsOptionRow.tsx:240 (t16) → onToggle(isOn)
SageIntacctReimbursableExpensesPage.tsx:83 (menuItems.onToggle) → vendors?.[0].id
Suspected cause
Optional chaining stops at vendors?.[0]; when the vendors array is empty, [0] is undefined and accessing .id throws. Same pattern exists on the non-reimbursable export page.
Reproduction
- Connect a workspace to Sage Intacct with an empty vendors list (or before vendors sync completes).
- Navigate to Accounting → Sage Intacct → Export → Reimbursable expenses.
- Toggle "Default vendor" ON.
- Observe TypeError in console: Cannot read properties of undefined (reading 'id').
Related
- Sibling Sentry IDs (if any): none
- Prior GH issues: none
- Fix PR: pending
Issue Owner
Current Issue Owner: @mallenexpensifyMetadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
mountiny commentedon Jul 5, 2026
Fix PR: #95345
MelvinBot commentedon Jul 6, 2026
Issue Analysis
Root Cause: Optional chaining stops one level too early. In both Sage Intacct export pages the default-vendor toggle reads
vendors?.[0].id— the?.guardsvendorsbeing nullish, but not the array being empty. When the synced vendors list is[],vendors?.[0]isundefinedand.idthrowsCannot read properties of undefined (reading 'id'), matching the Sentry crash on theonTogglepath.SageIntacctReimbursableExpensesPage.tsx:90SageIntacctNonReimbursableExpensesPage.tsx:108Recommended Fix: Add optional chaining before
.id→vendors?.[0]?.id. The result is already coalesced with?? ''at the call site, so an empty list safely produces''.✅ This is exactly what PR #95345 does — it changes
vendors?.[0].id→vendors?.[0]?.idon both pages and nothing else. The fix is correct and complete for the reported crash.Investigation details
Symptom → mechanism → confirmation
SageIntacctReimbursableExpensesPage.tsxmenuItems.onToggle→vendors?.[0].id, bubbling up throughToggleSettingsOptionRowandSwitch. Verified the toggle callback is the only placevendors?.[0].idis dereferenced.enabled ? …vendors?.[0].id : ''— the crash only fires when toggling ON with an empty/unsynced vendors array, which lines up with the reproduction steps (empty vendors list / before sync completes) and the low event count (needs a Sage Intacct workspace in that transient state).Alternative explanations considered & ruled out
vendors(that branch is already guarded by?.) — the failure requiresvendorsto be a non-null but empty array.policy/connections/dataissue — those are all guarded by the same optional-chaining chain; only the[0]index access is unguarded.Scope check: The pattern appears on both the reimbursable and non-reimbursable pages, and PR #95345 patches both — matching the "same pattern exists on the non-reimbursable export page" note in the issue. No other
vendors?.[0].idoccurrences exist in the codebase.Confidence: High — code evidence matches the Sentry stack trace exactly, the failure condition is reproducible from the code path, and the existing fix targets precisely the faulty expression.
The open fix PR already implements this correctly, so no further code change is needed — this analysis just confirms the root cause and validates the fix.
[-][Sentry: APP-H08] Crash toggling Sage Intacct default vendor when vendors list is empty[/-][+][Due for payment 2026-07-16] [Sentry: APP-H08] Crash toggling Sage Intacct default vendor when vendors list is empty[/+]8 remaining items
QichenZhu commentedon Jul 10, 2026
No new Sentry records since the fix went to staging. I believe the crash is resolved.
I'll be OOO from the 13th to 29th of July 2026. If this issue needs attention during that time, please reassign it.
melvin-bot commentedon Jul 15, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jul 15, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Jul 17, 2026
Payment Summary
Contributor+: @QichenZhu due $250 via NewDot
^ Test case created. Thx
trjExpensify commentedon Aug 3, 2026
approved $250 for @QichenZhu