[Due for payment 2026-08-12] Android & iOS - Expense - Contact list modal closes after rotating device

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.26-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94392
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.
• Create a Submit workspace on OD.

1. Launch Expensify app.
2. Go to workspace chat.
3. Create an expense.
4. Open the report.
5. Tap Submit.
6. Rotate device to landscape mode.

Expected Result:

Contact list modal will not close after rotating device.

Actual Result:

Contact list modal closes after rotating device.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7196912_1782937824919.Screen_Recording_20260702_042806_Expensify.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7196912

Issue Owner

Current Issue Owner: @truph01

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/6449ab23e07a36897fe0cdb987d938dadde820324b1a6f4e58b37462d4ace4ff

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #94392

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On a submit workspace, tapping Submit on an expense report opens the "Submit to" manager/contact list popover. Rotating the device to landscape closes that popover — it should stay open. Introduced by #94392.

What is the root cause of that problem?

It is not the popover/Modal component or any orientation listener calling onClose. The popover's open flag is component-local state — useReportSubmitToPopover.tsx:69 — so anything that unmounts the owning subtree resets it to false.

Rotating flips isInLandscapeMode, which flips shouldShowHeaderButtonsInHeaderRow at MoneyReportHeader.tsx:79. That boolean gates two mutually-exclusive render positions for <MoneyReportHeaderActions> — one inside HeaderWithBackButton, one in a separate sibling <View> — at MoneyReportHeader.tsx:131-150. Because these are different positions in the React tree, rotation unmounts the subtree from one branch and remounts it in the other. That subtree contains SubmitPrimaryAction → ReportSubmitToPopoverAnchor → useReportSubmitToPopover, so the remount discards isVisible and the popover closes.

Evidence / data flow

1. Tap Submit → SubmitPrimaryAction → openReportSubmitToPopover() → setIsVisible(true); popover shows.
2. Rotate → useResponsiveLayout recomputes isInLandscapeMode = true (on a native phone isSmallScreenWidth is hardcoded true, so isInLandscapeMode is the only term that flips).
3. shouldShowHeaderButtonsInHeaderRow flips false → true.
4. <MoneyReportHeaderActions> unmounts from the portrait branch (L141) and mounts in the landscape branch (L131).
5. useReportSubmitToPopover re-initializes isVisible = false → popover dismissed.

Ruled out: PopoverWithMeasuredContent/bottom-docked Modal has supportedOrientations including landscape and no Dimensions/orientation listener that calls onClose; on native there is no Popover↔Modal swap on rotation.

What changes do you think we should make in order to solve the problem?

Stop rendering MoneyReportHeaderActions in two separate tree positions so React keeps the same instance across rotation and the popover state survives. In MoneyReportHeader.tsx:131-150, render <MoneyReportHeaderActions> once and switch only its placement/wrapper styling based on shouldShowHeaderButtonsInHeaderRow, rather than mounting it under two different parents.

If a full header restructure is too risky for a deploy-blocker hotfix, the alternative is to hoist the popover's open state out of the remounting subtree using the existing Host pattern (ReportSubmitToPopoverHost in ReportSubmitToPopoverAnchor.tsx) placed above both branches, so remounting the rows no longer drops isVisible.

Confidence: High — code path fully traced. Worth a quick on-device confirm that MoneyReportHeader is the header shown in the reported flow (vs. an RHP variant); the two-branch remount pattern applies either way.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/95096) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[hungvu193]

We can also demote this one. This modal only show up with submit ws