Skip to content

[Due for payment 2026-07-08] Use X close icon (not back chevron) for the #admins room in the side panel on desktop #94809

Description

@MelvinBot

Problem

On desktop/wide screens, when a report is shown in the side panel ("third pane"), the header shows a back-arrow chevron (<). Clicking it slides the panel closed to the right, which contradicts the < (back/left) affordance. This was already fixed for the Concierge chat in #78870 / #78955 by swapping the chevron for an X, but that fix was intentionally scoped to Concierge only — so the #admins room shown in the side panel still shows the inconsistent <.

Context

The side-panel/third-pane header (src/pages/inbox/HeaderView.tsx) only ever renders the Concierge DM or the active workspace #admins room (confirmed via SidePanelContextProvider, which is the sole source of the side-panel reportID). In that layout the control opens/closes a panel rather than navigating a hierarchy, so an X is the correct affordance for both.

Solution

Widen the close-button gate in HeaderView.tsx so any report shown in the side panel on wide screens uses the X, dropping the Concierge-only condition:

- const shouldShowCloseButton = !!isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report, conciergeReportID);
+ const shouldShowCloseButton = !!isInSidePanel && !shouldUseNarrowLayout;

Small screens keep the back arrow (the !shouldUseNarrowLayout guard is unchanged).

Slack thread: https://expensify.slack.com/archives/C03TME82F/p1782401698342299

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions