Repository navigation
Auto-scroll pill should point down (e.g. Approve ⌄) when there's something to approve below the current scroll position #94796
Description
Description
Update the auto-scroll bubble/pill at the top of the chat to point down (i.e., Approve ⌄) when there is something to approve beneath the current scroll position.
Context
Today the action pill points the user toward an action badge that is above the current scroll window (see #86064, which shows the pill with a ^ up-arrow). This issue is the complementary case: when the actionable item (e.g. a report that needs Approve/Pay/Fix) is below the current scroll position, the pill should point down (Approve ⌄) and, when clicked, scroll the user down to that item.
Expected Behavior
- When there is an action badge below the current scroll window, show the colored action pill (Approve/Pay/Fix/etc.) with a downward (
⌄) arrow. - Clicking it scrolls the user down to the row causing the action badge.
- Arrow direction reflects whether the target is above (
^) or below (⌄) the current scroll position.
Reported in Slack.
Activity
aimane-chnaif commentedon Aug 13, 2026
@MelvinBot implement this
MelvinBot commentedon Aug 13, 2026
🤖 Draft PR created: #98576
Please mark it as "Ready for review" when it is ready for review.
What I implemented
Extended the floating action-badge pill (from #86064, which only handled the target being above the scroll position with a
^arrow) to the complementary "below" case:⌄) arrow, and clicking it scrolls down to that row.Code changes
useReportUnreadMessageScrollTracking.ts— now also tracksisActionBadgeBelowViewport(in the inverted list, target index< minIndex= below/newer,> maxIndex= above/older).useReportActionsScroll.ts— threads the new value through.ReportActionsList.tsx— shows the pill when the target is above or below, and passes the direction down.FloatingMessageCounter.tsx— rendersDownArrowinstead ofUpArrowwhen the target is below.The existing click handler already uses
scrollToIndex(...), which scrolls in either direction (as called for in #90278), so no scroll-logic change was needed. Behavior stays gated to non-production, matching the existing rollout.Verification
FloatingMessageCounterTest,useReportUnreadMessageScrollTrackingTest, 25 + tracking cases green).typecheck(tsgo) ✅, ESLint on changed files ✅ (only pre-existing grandfathered warnings), React Compiler compliance ✅ (no regression / no new divergence — the one flagged file already failed identically onmain).Testssteps in the PR before marking it Ready for review.melvin-bot commentedon Oct 26, 2026
@aimane-chnaif, @mkhutornyi, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.