Skip to content

[Due for payment 2026-07-03] Tags - Tag description is shown in two lines #94506

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.19-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93855
Email or phone of affected tester (no customers): sdjnoisdjdosijsonssjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace has dependant tags.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Tags.

Expected Result:

Tag description will be shown in single line.

Actual Result:

Tag description is hown in two lines.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7190130_1782330115616!Dependent_-_Multi_Level_tags_NEWW.csv

Image

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7190130

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 24, 2026
  2. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #93855

  3. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Jun 24, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on Jun 24, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The Tags page header description is wrapped in styles.workspaceSection, which caps its width at workspaceSectionMaxWidth + sectionMargin * 2 = 712px, while the tags table rendered directly below it spans the full page width.

    The regular tags subtitle is short and fits on one line within 712px, but the dependent-tags copy (subtitleWithDependentTags — "Tags add more detailed ways to classify costs. You are using dependent tags. You can reimport a spreadsheet to update your tags.") is longer and overflows 712px, so it wraps to two lines. This is the cap introduced when PR #93855 restyled the page header.

    Evidence

    The same workspaceSection cap is used by the restyled Categories page header, so the cap itself is the intended new-style behavior — the wrap only shows up here because the dependent-tags copy is the longest of the header strings.

    What changes do you think we should make in order to solve the problem?

    Let the header description use the full available content width (matching the table beneath it) instead of the 712px workspaceSection cap — i.e. don't apply the workspaceSection maxWidth to the header subtitle on the Tags page, so the dependent-tags sentence renders on a single line on wide screens.

    This is ultimately a small design decision between two options:

    1. Widen the header so the description matches the full-width table (single line — matches the tester's expectation).
    2. Shorten the dependent-tags copy so it fits within 712px.

    I'd recommend option 1 since the table is already full-width and the capped description looks visually truncated next to it, but confirm the preferred width with design before implementing.

    What alternative solutions did you explore? (Optional)

    Accepting the two-line wrap as expected — the 712px readable-column cap is intentional and shared with other workspace pages, so a long description wrapping there is not strictly broken. Flagging in case the team considers this acceptable rather than a code change.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94506) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  6. luacmartins commented on Jun 24, 2026

    @luacmartins
    Contributor

    @Expensify/design should we just remove the 712px max width here?

  7. luacmartins commented on Jun 24, 2026

    @luacmartins
    Contributor

    I'll demote this one since it's a small issue.

  8. 1 remaining item

  9. dannymcclain commented on Jun 24, 2026

    @dannymcclain
    Contributor

    Yeah I think that would probably be fine.

  10. shawnborton commented on Jun 25, 2026

    @shawnborton
    Contributor

    Totally agree, not sure why that exists.

  11. changed the title [-]Tags - Tag description is shown in two lines[/-] [+][Due for payment 2026-07-03] Tags - Tag description is shown in two lines[/+] on Jun 26, 2026
  12. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.20-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-03. 🎊

  14. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  15. luacmartins commented on Jun 26, 2026

    @luacmartins
    Contributor

    Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions