Skip to content

[Due for payment 2026-07-02] [No QA] Reorder unread indicator predicates to short-circuit cheaply #94447

Closed
Closed
[Due for payment 2026-07-02] [No QA] Reorder unread indicator predicates to short-circuit cheaply#94447
Assignees
TMisiukiewiczmallenexpensifymountinyZhenjaHorbach
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Description

@mountiny
mountiny
opened on Jun 24, 2026

Problem

getUnreadReportsForUnreadIndicator runs on every Onyx update (report, report-action, NVP, draft) and previously walked every report computing six locals up front — including the expensive getOneTransactionThreadReportID call — before running the cheapest guards. On accounts with 100k reports this took ~1.1s per invocation.

Solution

Reordered the predicates to short-circuit as early as possible with no behavioral change: mute and hidden-for-current-user checks run first, isUnread runs third, and getOneTransactionThreadReportID plus report-action/NVP lookups are deferred behind those rejections. The heaviest predicate (shouldReportBeInOptionList) runs last, only for reports that are unread, non-muted, and non-hidden. This reduces runtime from ~1.1s to ~400ms on 100k-report accounts.

PR

#94424

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. mountiny
    assigned
    mountiny
    and
    TMisiukiewicz
    on Jun 24, 2026
  2. mountiny
    added
    ReviewingHas a PR in review
    DailyKSv2
    InternalRequires API changes or must be handled by Expensify staff
    Task
    on Jun 24, 2026
  3. mountiny
    assigned
    ZhenjaHorbach
    on Jun 24, 2026
  4. mountiny
    added this to [#whatsnext] #qualityon Jun 24, 2026
  5. melvin-bot
    added
    WeeklyKSv2
    DailyKSv2
    and removed
    DailyKSv2
    ReviewingHas a PR in review
    WeeklyKSv2
    on Jun 24, 2026
  6. melvin-bot
    changed the title [-][No QA] Reorder unread indicator predicates to short-circuit cheaply[/-] [+][Due for payment 2026-07-02] [No QA] Reorder unread indicator predicates to short-circuit cheaply[/+] on Jun 25, 2026

  7. melvin-bot commented on Jun 25, 2026

    @melvin-bot
    melvin-botBot
    on Jun 25, 2026 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Jun 25, 2026

    @melvin-bot
    melvin-botBot
    on Jun 25, 2026 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-02. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on Jun 30, 2026

    @melvin-bot
    melvin-botBot
    on Jun 30, 2026 – with Melvin Bot

    @ZhenjaHorbach Eep! 4 days overdue now. Issues have feelings too...

  10. melvin-bot
    added
    Overdue
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jun 30, 2026
  11. melvin-bot
    assigned
    mallenexpensify
    on Jul 1, 2026

  12. melvin-bot commented on Jul 1, 2026

    @melvin-bot
    melvin-botBot
    on Jul 1, 2026 – with Melvin Bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. melvin-bot
    removed
    Overdue
    on Jul 1, 2026

  14. melvin-bot commented on Jul 1, 2026

    @melvin-bot
    melvin-botBot
    on Jul 1, 2026 – with Melvin Bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  15. mallenexpensify commented on Jul 3, 2026

    @mallenexpensify
    mallenexpensify
    on Jul 3, 2026
    Contributor

    Payment Summary

    Contributor+: @ZhenjaHorbach due $250 via NewDot

    @ZhenjaHorbach plz complete the BZ checklist and tag me in a post once you have. Thx

  16. ZhenjaHorbach commented on Jul 4, 2026

    @ZhenjaHorbach
    ZhenjaHorbach
    on Jul 4, 2026
    Contributor

    It's a performance issue
    So I think we don't need a checklist here

  17. melvin-bot
    added
    Overdue
    on Jul 6, 2026

  18. garrettmknight commented on Jul 6, 2026

    @garrettmknight
    garrettmknight
    on Jul 6, 2026
    Contributor

    $250 approved for @ZhenjaHorbach

  19. mallenexpensify
    closed this as completedon Jul 6, 2026
  20. melvin-bot
    removed
    Overdue
    on Jul 6, 2026
  21. github-project-automation
    moved this to Done in [#whatsnext] #qualityon Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions